Re: server: KeyNameInformation returns the full name of the key. (try 3)

[Austin English]

On Mon, Oct 13, 2014 at 10:25 AM, Akihiro Sagawa <sagawa.aki(a)gmail.com>
wrote:
> Try 3:
>   - Avoid allocating memory. (Based on Alexandre's comment, thanks.)
>   - Use k != root_key instead of k->namelen != 0.
>   - Add insufficient buffer test.
>
> ---
>  dlls/ntdll/tests/reg.c | 19 ++++++++++++++-----
>  server/registry.c      | 25 ++++++++++++++++++++++++-
>  2 files changed, 38 insertions(+), 6 deletions(-)

Hi Akihiro,

This change breaks the tests on my machine (causing wineserver to crash and
the ntdll/reg test to fail), see
https://bugs.winehq.org/show_bug.cgi?id=37411

Could you please take a look?

Thanks,
-Austin

server: KeyNameInformation returns the full name of the key. (try 3)

[Austin English]

On Thu, Oct 16, 2014 at 4:24 PM, Austin English <austinenglish(a)gmail.com>
wrote:
> On Mon, Oct 13, 2014 at 10:25 AM, Akihiro Sagawa <sagawa.aki(a)gmail.com>
> wrote:
> > Try 3:
> >   - Avoid allocating memory. (Based on Alexandre's comment, thanks.)
> >   - Use k != root_key instead of k->namelen != 0.
> >   - Add insufficient buffer test.
> >
> > ---
> >  dlls/ntdll/tests/reg.c | 19 ++++++++++++++-----
> >  server/registry.c      | 25 ++++++++++++++++++++++++-
> >  2 files changed, 38 insertions(+), 6 deletions(-)
>
> Hi Akihiro,
>
> This change breaks the tests on my machine (causing wineserver to crash
> and the ntdll/reg test to fail), see
> https://bugs.winehq.org/show_bug.cgi?id=37411
>
> Could you please take a look?
>
> Thanks,
> -Austin

+Akihiro, -wine-patches

(Sorry for double post)

-- 
-Austin