Re: Win64 patch 2/2 (winedbg)

[Alexandre Julliard]

Ge van Geldorp <ge(a)gse.nl> writes:
> case AddrModeFlat: 
> -        dbg_printf("0x%08lx", addr->Offset); 
> +        dbg_printf("0x%08llx", addr->Offset);

%ll formats are not portable, please avoid them.

-- 
Alexandre Julliard
julliard(a)winehq.org

Win64 patch 2/2 (winedbg)

[Francois Gouget]

On Tue, 25 Jul 2006, Alexandre Julliard wrote:
> Ge van Geldorp <ge(a)gse.nl> writes:
> > case AddrModeFlat:
> > -        dbg_printf("0x%08lx", addr->Offset);
> > +        dbg_printf("0x%08llx", addr->Offset);
>
> %ll formats are not portable, please avoid them.

'grep -t "%ll" *' finds 149 instances, mostly traces who there are some 
printfs in tools/winedump.

Should this be turned into a janitorial project?
What is the recommended alternative?

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
   Good judgment comes from experience, and experience comes from bad judgment
                                -- Barry LePatner

Win64 patch 2/2 (winedbg)

[Alexandre Julliard]

Francois Gouget <fgouget(a)free.fr> writes:
> 'grep -t "%ll" *' finds 149 instances, mostly traces who there are
> some printfs in tools/winedump.
>
> Should this be turned into a janitorial project?
> What is the recommended alternative?

That would be a good idea. In traces we should use
wine_dbgstr_longlong. In tests we don't want to use debug macros
so we should use the %lx%08lx trick.

-- 
Alexandre Julliard
julliard(a)winehq.org