Re: [PATCH] ole32: Add stub for OleGetIconOfFile.

[Dmitry Timoshkov]

Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> +HGLOBAL WINAPI OleGetIconOfFile(LPOLESTR path, BOOL use_file_as_label)
> +{
> +    FIXME("(%p, %d), stub!\n", path, use_file_as_label);
> +    return NULL;
> +}

Probably 'path' should be printed with debugstr_w(),
> +@ stdcall OleGetIconOfFile(ptr long)

... and argument type should be 'wstr' instead of 'ptr'.

-- 
Dmitry.

[PATCH] ole32: Add stub for OleGetIconOfFile.

[Alex Henrie]

2017-06-21 0:02 GMT-06:00 Dmitry Timoshkov <dmitry(a)baikal.ru>:
> Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> > +HGLOBAL WINAPI OleGetIconOfFile(LPOLESTR path, BOOL use_file_as_label)
> > +{
> > +    FIXME("(%p, %d), stub!\n", path, use_file_as_label);
> > +    return NULL;
> > +}
>
> Probably 'path' should be printed with debugstr_w(),
> > +@ stdcall OleGetIconOfFile(ptr long)
>
> ... and argument type should be 'wstr' instead of 'ptr'.

Thanks for the feedback. I have made both changes.

-Alex