Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> ---
>  dlls/ntdll/file.c | 31 +++++++++++++++----------------
>  1 file changed, 15 insertions(+), 16 deletions(-)

Why do you need that?  It doesn't look to me like an improvement.

-- 
Alexandre Julliard
julliard(a)winehq.org

[2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

[Dmitry Timoshkov]

Alexandre Julliard <julliard(a)winehq.org> wrote:
> Why do you need that?  It doesn't look to me like an improvement.

IMO it simplifies the code and avoids using two different code paths
for normal files.

-- 
Dmitry.

[2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> Alexandre Julliard <julliard(a)winehq.org> wrote:
> > Why do you need that?  It doesn't look to me like an improvement.
>
> IMO it simplifies the code and avoids using two different code paths
> for normal files.

At the cost of two extra seeks, plus introducing race conditions.
I don't think it's a good idea.

-- 
Alexandre Julliard
julliard(a)winehq.org