[PATCH] mmdevapi/tests: remove todo in traces for capture tests
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47876 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> --- dlls/mmdevapi/tests/capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c index 0fa9f0cab83..c6142fc4360 100644 --- a/dlls/mmdevapi/tests/capture.c +++ b/dlls/mmdevapi/tests/capture.c @@ -392,7 +392,7 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) if(hr == S_OK){ /* Only PulseAudio goes here; despite snd_pcm_drop it manages * to fill GetBufferSize with a single snd_pcm_read */ - trace("Test marked todo: only PulseAudio gets here\n"); + trace("only PulseAudio gets here\n"); todo_wine ok(flags & AUDCLNT_BUFFERFLAGS_DATA_DISCONTINUITY, "expect DISCONTINUITY %x\n", flags); /* Reset zeroes padding, not the position */ ok(pos >= sum, "Position %u last %u\n", (UINT)pos, sum); -- 2.21.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=57954 Your paranoid android. === w7pro64 (32 bit report) === mmdevapi: capture.c:181: Test failed: Position 1344 expected 0 === w8 (32 bit report) === mmdevapi: capture.c:103: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:116: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:144: Test failed: GetNextPacketSize 448 vs. GCP 20160 capture.c:231: Test failed: Position 1792 expected 1344 capture.c:261: Test failed: Position 1792 expected 1344 capture.c:318: Test failed: Position 2240 last 1792 frames 448 capture.c:338: Test failed: Position 2688 expected 2240 capture.c:363: Test failed: Position 3447 expected 2688 capture.c:364: Test failed: flags 1 capture.c:414: Test failed: Valid IAudioCaptureClient_GetBuffer returns 08890001 === w8adm (32 bit report) === mmdevapi: capture.c:103: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:116: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:144: Test failed: GetNextPacketSize 448 vs. GCP 2688 capture.c:231: Test failed: Position 1792 expected 1344 capture.c:261: Test failed: Position 1792 expected 1344 capture.c:318: Test failed: Position 2240 last 1792 frames 448 capture.c:338: Test failed: Position 2688 expected 2240 capture.c:363: Test failed: Position 3136 expected 2688 === w864 (32 bit report) === mmdevapi: capture.c:103: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:116: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:144: Test failed: GetNextPacketSize 448 vs. GCP 896 === w1064v1507 (32 bit report) === mmdevapi: capture.c:103: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:116: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:144: Test failed: GetNextPacketSize 448 vs. GCP 1792 === w1064v1809 (32 bit report) === mmdevapi: capture.c:103: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:116: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:144: Test failed: GetNextPacketSize 448 vs. GCP 3584 === w7pro64 (64 bit report) === mmdevapi: capture.c:103: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:116: Test failed: Initial IAudioCaptureClient_GetBuffer returns 00000000 capture.c:144: Test failed: GetNextPacketSize 448 vs. GCP 896
On Fri, 18 Oct 2019, Vijay Kiran Kamuju wrote: [...]
diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c index 0fa9f0cab83..c6142fc4360 100644 --- a/dlls/mmdevapi/tests/capture.c +++ b/dlls/mmdevapi/tests/capture.c @@ -392,7 +392,7 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) if(hr == S_OK){ /* Only PulseAudio goes here; despite snd_pcm_drop it manages * to fill GetBufferSize with a single snd_pcm_read */ - trace("Test marked todo: only PulseAudio gets here\n"); + trace("only PulseAudio gets here\n");
Do you know why Windows gets there too? -- Francois Gouget <fgouget(a)free.fr>
On 18-10-19 14:08, Francois Gouget wrote:
On Fri, 18 Oct 2019, Vijay Kiran Kamuju wrote: [...]
diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c index 0fa9f0cab83..c6142fc4360 100644 --- a/dlls/mmdevapi/tests/capture.c +++ b/dlls/mmdevapi/tests/capture.c @@ -392,7 +392,7 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx) if(hr == S_OK){ /* Only PulseAudio goes here; despite snd_pcm_drop it manages * to fill GetBufferSize with a single snd_pcm_read */ - trace("Test marked todo: only PulseAudio gets here\n"); + trace("only PulseAudio gets here\n");
Do you know why Windows gets there too?
I also can't find any test results where Wine actually follows this path (so does PulseAudio really get here?). On the other hand, on one of the Windows 8 machines for instance, this path actually gives rise to a test failure:
https://test.winehq.org/data/8c74027ba60a360f24cf232ee233e71262d8f1ff/win8_n... Note that this is the only failure left on that machine, so fixing it would mean green tests! Best, Sven
participants (4)
-
Francois Gouget -
Marvin -
Sven Baars -
Vijay Kiran Kamuju