Re: League of Legends shop in game fix

[Austin English]

On Thu, Jan 29, 2015 at 9:19 AM, Monster <manuiglesias96(a)yahoo.es> wrote:
> @@ -220,7 +220,10 @@ BOOL wined3d_resource_allocate_sysmem(struct
> wined3d_resource *resource)
> SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p);
> void *mem;
> - if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> resource->size + align)))
> + UINT size = resource->size;
> + if (resource->width <= 128 && resource->height <= 128)
> + size *= 2;
> + if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size +
> align)))
> return FALSE;
> p = (void **)(((ULONG_PTR)mem + align) & ~(RESOURCE_ALIGNMENT - 1)) - 1;

Please use your real name when sending patches.

-- 
-Austin

League of Legends shop in game fix

[Alex Henrie]

You'll also need to use `git format-patch` to generate your diffs, and
`git send-email` so that your mail client doesn't add extra line
breaks like it did, and linking to the bug report that this patch is
supposed to fix is always a good idea. Also, Alexandre is going to
expect you to include some new, relevant unit tests in the patch.

-Alex

League of Legends shop in game fix

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

While the patch style hints are right, the more fundamental issue is
that this patch is a game-specific hack that happens to work by chance
rather than fix the real issue. As such it isn't acceptable to Wine.

The proper fix is to move memory allocation into the container. This
is not a simple task though.

Am 2015-01-30 um 00:45 schrieb Alex Henrie:
> You'll also need to use `git format-patch` to generate your diffs,
> and `git send-email` so that your mail client doesn't add extra
> line breaks like it did, and linking to the bug report that this
> patch is supposed to fix is always a good idea. Also, Alexandre is
> going to expect you to include some new, relevant unit tests in the
> patch.
>
> -Alex

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUy07rAAoJEN0/YqbEcdMwYRgQAIDIs9tbI6fI1JF4KuqyhwoJ
nXlM+DVBSMSn2xsbPLXFY8y5slwzRdlkoFOf7mZJWKbJ8F6jlDSkFlZuksqGQFbb
o/ROcMGEPgEeOKD3MpVqdDP9DXwulrw16PkZIN1bCidBUZC1bhwRpaqfS2YR849p
kh3Dtghg4QiJuotvsQecVQTaJP+QLyFHHOnqSJ4LnoGqHzQ5vG52orNy4AYzjhuc
zFXoP7uhLW09q/QeYf1uajYpzu/O6IHPpEuVghaOegMJHawo5uDorWAVMMJLoo0G
vTewO60d4BcCQk0eaYp5jDoVSt+TwJT54Rk8sddCdxeh4G6W+BFWCpRjrrWH46vW
/7ZFZeBgVFNlR4/gtCejOSKRQm3sRUCNIVMg0RrN7Yd76WDPG0FtNvqVHX2JZaNH
pQGKf9pXVsyxgOW/oj/FtsrF/rINhIchLcjO6Gtj9vxCJCiQ4l72f5wrjn/v72tC
wQ7yxw14FjlFFl8JEiU3VEhOS1YjMwxVaK/D0vSiZKnmCF8RmTQZ3und0D22shbC
mMtOzeRq20PWrxspJ9G274Trc0n34sKfAcn180rUEyjwoO8ZUUjYfvG74iv5RbPl
XNQtlbht6uT5bJTEARtViCK4nxa1FEsS+Tt5hT1cXCI8L8S6AUop9B10m4QkZYAX
gWFDAeroxDP0clx2hlDB
=zU9Z
-----END PGP SIGNATURE-----