Re: [PATCH 1/6] ddraw/tests: Add position tests for D3DPROCESSVERTICES_TRANSFORM.
On 3 September 2016 at 21:42, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
+ color = get_surface_color(rt, 18, 18); + ok(compare_color(color, 0x00000000, 1), "Got unexpected color %#x\n", color); + color = get_surface_color(rt, 22, 18); + ok(compare_color(color, 0x00000000, 1), "Got unexpected color %#x\n", color); + color = get_surface_color(rt, 18, 22); + ok(compare_color(color, 0x00000000, 1), "Got unexpected color %#x\n", color); ... + color = get_surface_color(rt, 222, 418); + ok(compare_color(color, 0x00000000, 1), "Got unexpected color %#x\n", color); + color = get_surface_color(rt, 218, 422); + ok(compare_color(color, 0x00000000, 1), "Got unexpected color %#x\n", color); + color = get_surface_color(rt, 222, 422); + ok(compare_color(color, 0x00000000, 1), "Got unexpected color %#x\n", color); These fail on Windows here: ddraw1.c:9659: Test failed: Got unexpected color 0xff ddraw1.c:9661: Test failed: Got unexpected color 0xff ddraw1.c:9663: Test failed: Got unexpected color 0xff ddraw1.c:9670: Test failed: Got unexpected color 0xff ddraw1.c:9672: Test failed: Got unexpected color 0xff ddraw1.c:9674: Test failed: Got unexpected color 0xff
As an aside, that's also why we usually use 0x%08x for colours.
Am 2016-09-05 um 12:16 schrieb Henri Verbeet:
These fail on Windows here: ddraw1.c:9659: Test failed: Got unexpected color 0xff ddraw1.c:9661: Test failed: Got unexpected color 0xff ddraw1.c:9663: Test failed: Got unexpected color 0xff ddraw1.c:9670: Test failed: Got unexpected color 0xff ddraw1.c:9672: Test failed: Got unexpected color 0xff ddraw1.c:9674: Test failed: Got unexpected color 0xff Sounds like the clear isn't limited to the viewport dimensions. I vaguely remember seeing that on Windows before. Is that on AMD?
It will be a while before I can send an updated patch. My next weekends are full...
On 6 September 2016 at 21:16, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
Am 2016-09-05 um 12:16 schrieb Henri Verbeet:
These fail on Windows here: ddraw1.c:9659: Test failed: Got unexpected color 0xff ddraw1.c:9661: Test failed: Got unexpected color 0xff ddraw1.c:9663: Test failed: Got unexpected color 0xff ddraw1.c:9670: Test failed: Got unexpected color 0xff ddraw1.c:9672: Test failed: Got unexpected color 0xff ddraw1.c:9674: Test failed: Got unexpected color 0xff Sounds like the clear isn't limited to the viewport dimensions. I vaguely remember seeing that on Windows before. Is that on AMD?
AMD, yes.
participants (2)
-
Henri Verbeet -
Stefan Dösinger