Re: [PATCH 1/2] quartz: Restore a comment explaining mediatime.

[Matteo Bruni]

2017-06-19 21:15 GMT+02:00 Zebediah Figura <z.figura12(a)gmail.com>:
> This comment was removed by 0a6f11c8, possibly by accident.
> The usage of the term "media time" here is confusing, both
> because it does not describe time (or any meaningful unit)
> and also because it conflicts with the normal definition of
> "media time", viz. length in number of samples.
>
> Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>
> ---
>  dlls/quartz/quartz_private.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h
> index 7cad3a75640..a9855e95acd 100644
> --- a/dlls/quartz/quartz_private.h
> +++ b/dlls/quartz/quartz_private.h
> @@ -33,6 +33,7 @@
>  #include "wine/strmbase.h"
>  #include "wine/list.h"
>
> +/* see IAsyncReader::Request on MSDN for the explanation of this */
>  #define MEDIATIME_FROM_BYTES(x) ((LONGLONG)(x) * 10000000)
>  #define SEC_FROM_MEDIATIME(time) ((time) / 10000000)
>  #define BYTES_FROM_MEDIATIME(time) SEC_FROM_MEDIATIME(time)

Is it reasonable to put some short explanation right here (i.e.
removing the middle man) instead?

[PATCH 1/2] quartz: Restore a comment explaining mediatime.

[Zebediah Figura]

On 06/21/2017 02:57 PM, Matteo Bruni wrote:
> 2017-06-19 21:15 GMT+02:00 Zebediah Figura <z.figura12(a)gmail.com>:
> > This comment was removed by 0a6f11c8, possibly by accident.
> > The usage of the term "media time" here is confusing, both
> > because it does not describe time (or any meaningful unit)
> > and also because it conflicts with the normal definition of
> > "media time", viz. length in number of samples.
> >
> > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>
> > ---
> >   dlls/quartz/quartz_private.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h
> > index 7cad3a75640..a9855e95acd 100644
> > --- a/dlls/quartz/quartz_private.h
> > +++ b/dlls/quartz/quartz_private.h
> > @@ -33,6 +33,7 @@
> >   #include "wine/strmbase.h"
> >   #include "wine/list.h"
> >
> > +/* see IAsyncReader::Request on MSDN for the explanation of this */
> >   #define MEDIATIME_FROM_BYTES(x) ((LONGLONG)(x) * 10000000)
> >   #define SEC_FROM_MEDIATIME(time) ((time) / 10000000)
> >   #define BYTES_FROM_MEDIATIME(time) SEC_FROM_MEDIATIME(time)
>
> Is it reasonable to put some short explanation right here (i.e.
> removing the middle man) instead?

Presumably such an explanation would include the reason for using media 
time in all of our internals, but I don't know what the reason for that is.