Re: [PATCH] Tell dosbox to read the current user's config

[Austin English]

On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com <shankao(a)gmail.com> wrote:
> Fixes https://bugs.winehq.org/show_bug.cgi?id=40380

Hi,

Thanks for the patch, but please see
https://wiki.winehq.org/Submitting_Patches for how to submit a patch
(sorry for not linking originally).

In particular, you need a real name on the patch and to add a sign-off.

-- 
-Austin

[PATCH] Tell dosbox to read the current user's config

Thanks, sending again. Please, let me know if it's correct.

On Thu, Jun 2, 2016 at 11:37 AM Austin English <austinenglish(a)gmail.com>
wrote:
> On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com <shankao(a)gmail.com>
> wrote:
> > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380
>
> Hi,
>
> Thanks for the patch, but please see
> https://wiki.winehq.org/Submitting_Patches for how to submit a patch
> (sorry for not linking originally).
>
> In particular, you need a real name on the patch and to add a sign-off.
>
> --
> -Austin

[PATCH] Tell dosbox to read the current user's config

[Austin English]

On 06/01/2016 10:48 PM, shankao(a)gmail.com wrote:
> Thanks, sending again. Please, let me know if it's correct.
>
> On Thu, Jun 2, 2016 at 11:37 AM Austin English <austinenglish(a)gmail.com
> <mailto:austinenglish(a)gmail.com>> wrote:
>
> On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com
>     <mailto:shankao(a)gmail.com> <shankao(a)gmail.com
>     <mailto:shankao(a)gmail.com>> wrote:
>     > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380
>
> Hi,
>
> Thanks for the patch, but please see
>     https://wiki.winehq.org/Submitting_Patches for how to submit a patch
>     (sorry for not linking originally).
>
> In particular, you need a real name on the patch and to add a sign-off.
>
> --
>     -Austin

Yes, looks good, thanks.

-- 
-Austin
GPG: 14FB D7EA A041 937B

[PATCH] Tell dosbox to read the current user's config

Great. Should I send it in a new email or something like that? I still see
the previous unsigned patch at https://source.winehq.org/patches/

On Thu, Jun 2, 2016 at 11:51 AM Austin English <austinenglish(a)gmail.com>
wrote:
> On 06/01/2016 10:48 PM, shankao(a)gmail.com wrote:
> > Thanks, sending again. Please, let me know if it's correct.
> >
> > On Thu, Jun 2, 2016 at 11:37 AM Austin English <austinenglish(a)gmail.com
> > <mailto:austinenglish(a)gmail.com>> wrote:
> >
> > On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com
> >     <mailto:shankao(a)gmail.com> <shankao(a)gmail.com
> >     <mailto:shankao(a)gmail.com>> wrote:
> >     > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380
> >
> > Hi,
> >
> > Thanks for the patch, but please see
> >     https://wiki.winehq.org/Submitting_Patches for how to submit a patch
> >     (sorry for not linking originally).
> >
> > In particular, you need a real name on the patch and to add a
> > sign-off.
> >
> > --
> >     -Austin
>
> Yes, looks good, thanks.
>
> --
> -Austin
> GPG: 14FB D7EA A041 937B

[PATCH] Tell dosbox to read the current user's config

[Henri Verbeet]

On 2 June 2016 at 05:50, Austin English <austinenglish(a)gmail.com> wrote:
> On 06/01/2016 10:48 PM, shankao(a)gmail.com wrote:
> > Thanks, sending again. Please, let me know if it's correct.
>
> Yes, looks good, thanks.

Does that work? It seems somewhat suspicious to combine the -userconf
and -conf options into a single argument.

[PATCH] Tell dosbox to read the current user's config

I can change it to a different argument. It may be more readable too
> > Yes, looks good, thanks. > Does that work? It seems somewhat suspicious to combine the -userconf and -conf options into a single argument.

[PATCH] Tell dosbox to read the current user's config

Reconverted to use a different argument for the userconf option.

On Thu, Jun 2, 2016 at 5:18 PM shankao(a)gmail.com <shankao(a)gmail.com> wrote:
> I can change it to a different argument. It may be more readable too
> > > Yes, looks good, thanks. > Does that work? It seems somewhat
> > suspicious to combine the -userconf and -conf options into a single
> > argument.

[PATCH] Tell dosbox to read the current user's config

[Bruno Jesus]

On Thu, Jun 2, 2016 at 6:02 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
> On 2 June 2016 at 05:50, Austin English <austinenglish(a)gmail.com> wrote:
> > On 06/01/2016 10:48 PM, shankao(a)gmail.com wrote:
> > > Thanks, sending again. Please, let me know if it's correct.
> >
> > Yes, looks good, thanks.
>
> Does that work? It seems somewhat suspicious to combine the -userconf
> and -conf options into a single argument.

Yes according to the dosbox man [1]:
-userconf Load the configuration file located in ~/.dosbox. Can be
combined with the -conf option.

http://linux.die.net/man/1/dosbox

[PATCH] Tell dosbox to read the current user's config

Yes, dosbox supports that trick.
But I think that Henri was referring about having it in the same args
C variable. It's separated in the last patch.
Should I resend it again? I'm a bit confused about how wine deals with
patch resend.
> Yes according to the dosbox man [1]: -userconf Load the configuration file located in ~/.dosbox. Can be combined with the -conf option. http://linux.die.net/man/1/dosbox