Re: [PATCH 4/5] wined3d: Remove a texture dimension check in state_alpha().

[Stefan Dösinger]

Alexandre: The patch is OK, this mail is just some random note on why the code 
was there in the first place.

Am Donnerstag, 8. März 2012, 20:27:15 schrieb Henri Verbeet:
> I don't think there's any reason color-keying shouldn't work on e.g. cube
> textures, although it probably isn't very common either.
> Fyi, I believe the original reason for this check was this line of code, 
> removed by commit 70ed814b95f7719d52fa5b18a375d566a185a9ec.

surf = (IWineD3DSurfaceImpl *) ((IWineD3DTextureImpl *)stateblock-
> textures[0])->surfaces[0];

The implication for the current code is that there should be tests for color 
keying with mipmaps and cubemaps. Cubemaps are unlikely to be used with color 
keying as you say, and writing tests for mipmapping is on my todo list for 
proper color keying with the ffp replacement shader and blit shaders once I 
have time for this.