Re: [PATCH] ws2_32/tests: Add IDN resolution test for GetAddrInfoW

[Alexandre Julliard]

Bruno Jesus <00cpxxx(a)gmail.com> writes:
> I'm using €.linux.it because I could not find any standard domain name
> for validation. Maybe winehq.org could have a IDN sub-domain name to
> test.

I created テスト.winehq.org for this purpose.
> Also instead of broken'ing every test to catch Windows <= 7 I'm
> skipping before, so real failures are not lost due to broken covering
> them in Win >= 8.

I still think it's better to avoid version checks. You can do broken()
on the first test and skip the others if you detect the Win 7 behavior.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] ws2_32/tests: Add IDN resolution test for GetAddrInfoW

[Bruno Jesus]

On Tue, Nov 29, 2016 at 12:10 PM, Alexandre Julliard
<julliard(a)winehq.org> wrote:
> Bruno Jesus <00cpxxx(a)gmail.com> writes:
> > I'm using €.linux.it because I could not find any standard domain name
> > for validation. Maybe winehq.org could have a IDN sub-domain name to
> > test.
>
> I created テスト.winehq.org for this purpose.

Thanks, I have updated the tests but testbot VMs are not resolving it
yet, so I didn't send the patch yet.
> > Also instead of broken'ing every test to catch Windows <= 7 I'm
> > skipping before, so real failures are not lost due to broken covering
> > them in Win >= 8.
>
> I still think it's better to avoid version checks. You can do broken()
> on the first test and skip the others if you detect the Win 7 behavior.

Ok, no problem.

Best wishes,
Bruno