Re: [PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.
On 8 October 2014 14:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
These two patches fix test failures when the process is not in foreground that print changing error lines. This avoids generating warnings from the testbot whenever d3d8/tests/device.c is touched.
There are many more failures in d3d8:device when the test is not in foreground. Those failures write static lines and I'd prefer the testbot to be changed to run them in foreground instead. Why does this affect d3d8, but not d3d9?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-10-09 16:52, schrieb Henri Verbeet:
Why does this affect d3d8, but not d3d9? Creating a fullscreen d3d9 device puts the process in foreground somehow, but creating a d3d8 device does not. I don't know which behavior is the bug and which is the feature. After creating a fullscreen device the focus window is the foreground window and SetForegroundWindow succeeds. A windowed device does not change the foreground window.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUNqa6AAoJEN0/YqbEcdMwDU8P/iuHUm+5uDBDQ9GnulffoER/ WoA9kL+royZ+Pno64VazQFAzafOte9vyox56oMmet50Flfka+fgTYlywicZhWkfK 21/BDA9rgLbZUSNl+u6kBheaeoCENdhY4Gs+0dbq9BLNN86KQQLCfIe3Rmx6U+X1 csuyu/6Z0zz+w7lgnt8/KM3Gq3QFr8dAE0xPokqZ+2X6Hi1BJL5BKcUDF+Qwp4oh xpiAcd8gWJWzGajh8VBwly9Soo67AjwgI7XdheFb87ZzZ2yio/SHFgF92CvyXzzB Jc9GK631Uh8+EtyOsa0PkS6rWLekA1f30N1SYd0XCgzeDNhia2l+iwNjrdOABCr7 Z+jC025WFykGeSTvKvw6aWfbIZbiq+p0Vam5qkviAzVEziBzG5PEOpCFJLh21PLU 9qHUd7lMbcVBNKyHUn3umiOm1yhM1rdjXxGiJsyO2WTAVb5/daxcnYGdH1RSfIxF wivJ9Y0odHUa4HmcaAglyXywMlx9vmwRsGgkJPOybncxoD7/XZoNt2XR573708iL mqvfunOsQUsYvXeLBImFlUJQjfquyEYUqSQdu6QXZWy+lr9dAUzMyyaYpPjkQ/z1 CtV4/JoleRKoz4+U2p9sL5oxsKuSVrjyUgrGlAN5siEMVhdvY7FrPnzSFDUeEW/t MbbJz5TCfiYj9S/wUzX7 =cb55 -----END PGP SIGNATURE-----
participants (2)
-
Henri Verbeet -
Stefan Dösinger