[PATCH] dsound: Report when a DMO object has tailing data.

[Alistair Leslie-Hughes]

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 dlls/dsound/mixer.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c
index 05ca99b5df..53b5f9f576 100644
--- a/dlls/dsound/mixer.c
+++ b/dlls/dsound/mixer.c
@@ -443,8 +443,9 @@ static void DSOUND_MixToTemporary(IDirectSoundBufferImpl *dsb, DWORD frames)
 		for (i = 0; i < dsb->num_filters; i++) {
 			if (dsb->filters[i].inplace) {
 				hr = IMediaObjectInPlace_Process(dsb->filters[i].inplace, size_bytes, (BYTE*)dsb->device->tmp_buffer, 0, DMO_INPLACE_NORMAL);
-
-				if (FAILED(hr))
+				if(hr == S_FALSE)
+					FIXME("Processing of tailing data currently not implemented.\n");
+				else if (FAILED(hr))
 					WARN("IMediaObjectInPlace_Process failed for filter %u\n", i);
 			} else
 				WARN("filter %u has no inplace object - unsupported\n", i);
-- 
2.17.1

[Andrew Eikum]

On Fri, Sep 06, 2019 at 06:23:26AM +0000, Alistair Leslie-Hughes wrote:
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/dsound/mixer.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c
> index 05ca99b5df..53b5f9f576 100644
> --- a/dlls/dsound/mixer.c
> +++ b/dlls/dsound/mixer.c
> @@ -443,8 +443,9 @@ static void DSOUND_MixToTemporary(IDirectSoundBufferImpl *dsb, DWORD frames)
>       for (i = 0; i < dsb->num_filters; i++) {
>       	if (dsb->filters[i].inplace) {
>       		hr = IMediaObjectInPlace_Process(dsb->filters[i].inplace, size_bytes, (BYTE*)dsb->device->tmp_buffer, 0, DMO_INPLACE_NORMAL);
> -
> -				if (FAILED(hr))
> +				if(hr == S_FALSE)
> +					FIXME("Processing of tailing data currently not implemented.\n");

Would you be OK with a WARN? This is in a tight loop, so I think it
has a good chance of spamming logs that don't have +dsound.

Andrew

[Alistair Leslie-Hughes]

Hi Andrew,

On 9/9/19 10:29 pm, Andrew Eikum wrote:
> Would you be OK with a WARN? This is in a tight loop, so I think it
> has a good chance of spamming logs that don't have +dsound.

The main concern is that a WARN will be only be visible when tracing

dsound.  So, the expect behavior is going to be easily missed. From the 
three

games that I've tested that use dsdmo, none have reported they needed

this feature as yet.

How about, once a game reports they need this feature, we can create

a bug report and changed it to be a warning? or implement it.


Regards

Alistair.