Re: [PATCH] oledb32: Downgrade IDataSourceLocator_QueryInterface FIXME to WARN

[Huw Davies]

On Fri, Mar 10, 2017 at 04:31:02AM +0000, Alistair Leslie-Hughes wrote:
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/oledb32/dslocator.c      | 2 +-
>  dlls/oledb32/tests/database.c | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/oledb32/dslocator.c b/dlls/oledb32/dslocator.c
> index 11ed3e9..055357e 100644
> --- a/dlls/oledb32/dslocator.c
> +++ b/dlls/oledb32/dslocator.c
> @@ -80,7 +80,7 @@ static HRESULT WINAPI dslocator_QueryInterface(IDataSourceLocator *iface, REFIID
>        return S_OK;
>      }
>
> -    FIXME("interface %s not implemented\n", debugstr_guid(riid));
> +    WARN("interface %s not implemented\n", debugstr_guid(riid));
>      return E_NOINTERFACE;
>  }

I think leaving the FIXME, but skipping it if the iid is
IID_IRunnableObject would be better.

Huw.