[PATCH 0/1] MR304: mshtml: Enable CSS grid layout.

[Arek Hiler (＠ivyl)]

This helps with Final Fantasy XIV launcher not rendering correctly under Wine. The login form should be to the right of the news section but due to grid layout being unsupported it renders below and requires scrolling to be accessed which is non-obvious.

The CSS grid is not fully implemented in Gecko version we are using.

https://bugzilla.mozilla.org/show_bug.cgi?id=1217086 + bugs it depends on seems to be representative of the state of the implementation in version ~47.

Looks like it's mostly some nesting cases that were still being implemented.

The only real problem seems to require a very specific setup https://bugzilla.mozilla.org/show_bug.cgi?id=1316649 but we still may want to pick up the fix for it for wine-gecko.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/304

[PATCH 1/1] mshtml: Enable CSS grid layout.

[Arkadiusz Hiler]

From: Arkadiusz Hiler <ahiler(a)codeweavers.com>

Final Fantasy XIV launcher uses it to show login form next to the news.

Signed-off-by: Arkadiusz Hiler <ahiler(a)codeweavers.com>
---
 dlls/mshtml/nsembed.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c
index e34861b13fa..8f456b40ef2 100644
--- a/dlls/mshtml/nsembed.c
+++ b/dlls/mshtml/nsembed.c
@@ -540,6 +540,7 @@ static void set_preferences(void)
     set_lang(pref);
     set_bool_pref(pref, "security.warn_entering_secure", FALSE);
     set_bool_pref(pref, "security.warn_submit_insecure", FALSE);
+    set_bool_pref(pref, "layout.css.grid.enabled", TRUE);
     set_int_pref(pref, "layout.spellcheckDefault", 0);
 
     nsIPrefBranch_Release(pref);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/304

[PATCH 0/1] MR304: mshtml: Enable CSS grid layout. - approved

[Jacek Caban (＠jacek)]

This merge request was approved by Jacek Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/304