re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

[Dan Kegel]

James wrote:
> Is there anything wrong with this patch?

Well, it doesn't have a conformance test...
- Dan


-- 
Wine for Windows ISVs: http://kegel.com/wine/isv

oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

[James Hawkins]

On 6/5/06, Dan Kegel <dank(a)kegel.com> wrote:
> James wrote:
> > Is there anything wrong with this patch?
>
> Well, it doesn't have a conformance test...

The test would require us to have an idl file compiled by widl.  The
attached file is a part of the initial type marshalling tests written
by Rob Shearman.  The idl file can't be compiled by widl until many
more features of widl are implemented.

On 6/5/06, Robert Shearman <rob(a)codeweavers.com> wrote:
> Note: it's going to take a lot more work before widl can generate a
> typelib from this IDL. There are unimplemented features blocking it,
> like widl being unable to express pointers correctly and not being able
> to process importlibs.

One option is to compile the idl with midl and add the resulting
output files to git, but I don't know if Alexandre will accept this.

-- 
James Hawkins

oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

[Dan Kegel]

On 6/5/06, James Hawkins <truiken(a)gmail.com> wrote:
> The test would require us to have an idl file compiled by widl.

I bet that'd be ok, at least until our idl compiler shapes up.
How big is the output file?  Maybe you could even embed it
inside the .c file if it's not too huge.

oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

[James Hawkins]

On 6/5/06, Dan Kegel <dank(a)kegel.com> wrote:
> On 6/5/06, James Hawkins <truiken(a)gmail.com> wrote:
> > The test would require us to have an idl file compiled by widl.
>
> I bet that'd be ok, at least until our idl compiler shapes up.
> How big is the output file?  Maybe you could even embed it
> inside the .c file if it's not too huge.

There are two or three files that are generated, and until we compile
them ourselves, we should keep them in git, because we need some of
the files to compile the tests.

-- 
James Hawkins

oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]

[Dan Kegel]

On 6/5/06, James Hawkins <truiken(a)gmail.com> wrote:
> There are two or three files that are generated, and until we compile
> them ourselves, we should keep them in git, because we need some of
> the files to compile the tests.

Oh, right.  Anyway, lzexpand/tests/lzexpand_main.c is an example of
a golden file embedded in a .c file.  And if that was ok, checking
in your couple of files ought to be ok...

-- 
Wine for Windows ISVs: http://kegel.com/wine/isv