[PATCH] msxml3: deep-copy properties in attach_xmldoc
The 64bit msxml3:domdoc testcase always crash, the properties are freed twice. It seems this was due to attach_xmldoc not creating a copy of the properties, but using the same instance. Signed-off-by: Marcus Meissner <meissner(a)suse.de> --- dlls/msxml3/domdoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index a40fac2106..12309e6e28 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -689,7 +689,7 @@ static HRESULT attach_xmldoc(domdoc *This, xmlDocPtr xml ) if(This->node.node) { xmldoc_add_ref(get_doc(This)); - priv_from_xmlDocPtr(get_doc(This))->properties = This->properties; + priv_from_xmlDocPtr(get_doc(This))->properties = copy_properties(This->properties); } return S_OK; -- 2.15.0
participants (1)
-
Marcus Meissner