Re: ieframe: implement clicking on Properties

[Jacek Caban]

Hi Jared,

On 06/30/15 16:00, Jared Smudde wrote:
> When the user clicks on the properties menu in ieframe, launch inetcpl.cpl.
>
> dlls/ieframe/iexplore.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/dlls/ieframe/iexplore.c b/dlls/ieframe/iexplore.c
> index 08bb167..c1d0d74 100644
> --- a/dlls/ieframe/iexplore.c
> +++ b/dlls/ieframe/iexplore.c
> @@ -402,6 +402,11 @@ static void ie_dialog_about(HWND hwnd)
>      DestroyIcon(icon);
>  }
>
> +static void ie_dialog_properties(HWND hwnd)
> +{
> +   ShellExecuteW(hwnd, NULL, L"inetcpl.cpl", NULL, NULL, 0);
> +}

I think that we should call inetcpl.cpl functions directly here
(probably LaunchInternetControlPanel). Also, you can't use L"" for
strings due to compatibility problems, see how other strings are declared.
> +
>  static void add_tb_separator(HWND hwnd)
>  {
>      TBBUTTON btn;
> @@ -629,6 +634,10 @@ static LRESULT iewnd_OnCommand(InternetExplorer *This, HWND hwnd, UINT msg, WPAR
>          case ID_BROWSE_QUIT:
>              ShowWindow(hwnd, SW_HIDE);
>              break;
> +			
> +        case ID_BROWSE_PROPERTIES:
> +            ie_dialog_properties(hwnd);
> +			break;

Broken indention.

Thanks,
Jacek