As your patch is a little malformed and conflicts with mine (a big one) i send my patch merged with yours, can you look if all is correct.
Why did you not send a patch against a tree patched with Christian's ? And moreover, it seems you have another patch lying around (the one adding the IDirectInputDevice2A interface to the QueryInterface call). The problem is not the Changelog one, it's just that it's now really hard to do any code review with these kinds of stuff as change are accumulating :-/ Lionel -- Lionel Ulmer - http://www.bbrox.org/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le Lundi 09 Juin 2003 21:32, Lionel Ulmer a écrit :
As your patch is a little malformed and conflicts with mine (a big one) i send my patch merged with yours, can you look if all is correct.
Why did you not send a patch against a tree patched with Christian's ?
simply because his patch cannot be applied. I have to do it manually. I have merged it to simplify alexandre work.
And moreover, it seems you have another patch lying around (the one adding the IDirectInputDevice2A interface to the QueryInterface call).
i have this since a lot of time, but as you said i it paul the first patch.
The problem is not the Changelog one, it's just that it's now really hard to do any code review with these kinds of stuff as change are accumulating :-/
yes i know, but this patch cannot be really splittable ;( and as you have catched we always have many bugs to be fixed
Lionel
Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE+5Oo2p7NA3AmQTU4RAuhrAJ0bmgCGWws9XsVQTARSFhm+uXl1SQCZAVya EYWvAGpYRnbTHRzRfXerjpA= =bm3/ -----END PGP SIGNATURE-----
Raphaël Junqueira wrote: Sorry for the delay Raphael, I was offline...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Le Lundi 09 Juin 2003 21:32, Lionel Ulmer a écrit :
As your patch is a little malformed and conflicts with mine (a big one) i send my patch merged with yours, can you look if all is correct.
Why did you not send a patch against a tree patched with Christian's ?
simply because his patch cannot be applied. I have to do it manually. I have merged it to simplify alexandre work.
Your're right, a blank line has been removed by mistake. Sorry for that. Well, as I write these lines, Alexandre has already applied my patch... Now concerning your patch, why do you use DIRECTINPUT_VERSION in some conditional code? This should be use only for winelib application, no ? Christian
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi,
Your're right, a blank line has been removed by mistake.Sorry for that.
Well, alexandre have already commited your patch without errors so don't worry ;)
Well, as I write these lines, Alexandre has already applied my patch...
Now concerning your patch, why do you use DIRECTINPUT_VERSION in some conditional code? This should be use only for winelib application, no ?
yes, i know but i find it more readable with that #ifdef/#endif ;)
Christian
Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE+7Fnop7NA3AmQTU4RAmk9AJ95nV7YmdJequsVnwiv/bh9YFRNMQCbBFRy rrHBmXiOl/UICb20SBVBNKc= =EZDw -----END PGP SIGNATURE-----
Raphaël Junqueira wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
Your're right, a blank line has been removed by mistake.Sorry for that.
Well, alexandre have already commited your patch without errors so don't worry ;)
Well, as I write these lines, Alexandre has already applied my patch...
Now concerning your patch, why do you use DIRECTINPUT_VERSION in some conditional code? This should be use only for winelib application, no ?
yes, i know but i find it more readable with that #ifdef/#endif ;)
Personaly I find it confusing... :-) Why not just use comments ?
Christian
Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE+7Fnop7NA3AmQTU4RAmk9AJ95nV7YmdJequsVnwiv/bh9YFRNMQCbBFRy rrHBmXiOl/UICb20SBVBNKc= =EZDw -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi
Now concerning your patch, why do you use DIRECTINPUT_VERSION in some conditional code? This should be use only for winelib application, no ?
yes, i know but i find it more readable with that #ifdef/#endif ;)
Personaly I find it confusing... :-) Why not just use comments ?
well, if you want ;)
Christian
Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE+7gz8p7NA3AmQTU4RArq7AJ9eSgQPkcpOtzai6uFeiwAlAptk0wCeLMy+ beBbaAXyU7pfQIAAcvvECEM= =qZAu -----END PGP SIGNATURE-----
participants (3)
-
Christian Costa -
Lionel Ulmer -
Raphaël Junqueira