Re: wine/dlls/shell32 shellord.c shlexec.c

[Duane Clark]

Alexandre Julliard wrote:
> ChangeSet ID:	1027537179446510804425092
> CVSROOT:	/opt/cvs-commit
> Module name:	wine
> Changes by:	julliard(a)wine.codeweavers.com	02/07/24 13:59:39
>
> Modified files:
>   dlls/shell32   : shellord.c shlexec.c
>
> Log message:
>   Duane Clark <dclark(a)akamail.com>
>   Combined implementations of ShellExecute/Ex.
>
> Patch: http://cvs.winehq.com/patch.py?id=1027537179446510804425092
>
> Revision  Changes    Path
>  1.100    +0 -186    wine/dlls/shell32/shellord.c
>  1.4      +326 -111  wine/dlls/shell32/shlexec.c

Ouch, that version had some serious bugs. It would be much better to 
apply the version I posted to wine-devel, which I think works pretty 
good. I can supply a diff between this version and the fixed one, if 
desired.

wine/dlls/shell32 shellord.c shlexec.c

[Alexandre Julliard]

Duane Clark <dclark(a)akamail.com> writes:
> Ouch, that version had some serious bugs. It would be much better to
> apply the version I posted to wine-devel, which I think works pretty
> good.

Oops sorry, that was the one I intended to apply, I didn't notice it
was only sent to wine-devel.
> I can supply a diff between this version and the fixed one, if
> desired.

Yes please.

-- 
Alexandre Julliard
julliard(a)winehq.com

wine/dlls/shell32 shellord.c shlexec.c

[Tony Lambregts]

Alexandre Julliard wrote:
> Duane Clark <dclark(a)akamail.com> writes:
> > Ouch, that version had some serious bugs. It would be much better to
> > apply the version I posted to wine-devel, which I think works pretty
> > good.
>
> Oops sorry, that was the one I intended to apply, I didn't notice it
> was only sent to wine-devel.
> > I can supply a diff between this version and the fixed one, if
> > desired.
>
> Yes please.

It seems that one of  the patches to shlexec.c has broken WinZip.  The 
following is a trace from WinZip from this morning.


fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS
err:shell:SHGetFileInfoA pidl is null!
fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray 0x405b689c
err:shell:SHGetFileInfoA pidl is null!

I have been trying to debug this for a while and it did not have this 
problem yesterday. If you want to download WinZip here is the url 
http://www.winzip.com/


Tony Lambregts

wine/dlls/shell32 shellord.c shlexec.c

[Duane Clark]

Tony Lambregts wrote:
> It seems that one of  the patches to shlexec.c has broken WinZip.  The 
> following is a trace from WinZip from this morning.
>
> fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
> fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
> fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS
> err:shell:SHGetFileInfoA pidl is null!
> fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray 0x405b689c
> err:shell:SHGetFileInfoA pidl is null!
>
> I have been trying to debug this for a while and it did not have this 
> problem yesterday. If you want to download WinZip here is the url 
> http://www.winzip.com/

Ahh, that was one of the parts I mentioned that I didn't test because I 
did not know how to. Please tell me what you do to generate this error.

wine/dlls/shell32 shellord.c shlexec.c

[Duane Clark]

Duane Clark wrote:
> Ahh, that was one of the parts I mentioned that I didn't test because I 
> did not know how to. Please tell me what you do to generate this error.

Oh, and please mention exactly which version of Winzip.

Thanks

wine/dlls/shell32 shellord.c shlexec.c

[Tony Lambregts]

Duane Clark wrote:
> Duane Clark wrote:
> > Ahh, that was one of the parts I mentioned that I didn't test because 
> > I did not know how to. Please tell me what you do to generate this 
> > error.
>
> Oh, and please mention exactly which version of Winzip.
>
> Thanks

The version of winzip is 8.1. This bug is reproduced as follows:
1.  start WinZip --> wine "F:\program files\winzip\winzip32.exe"
2. When the startup screen appears click on  the "I agree" button.
3. A message box pops up with the Title "WinZip","Out of resources 
error, unable to continue. " for the text, and an "OK" button.  - click 
on "OK" button.
4. Another message box pops up with the  Title "WinZip", two buttons and 
the following text:
> WinZip internal error in file listview.c line 1236
>
> *WinZip will exit. Please restart WinZip and try again.*
>
> If this is a recurring problem and you would like WinZip to create a

log
> file with details about the error so that you can report this 
> problem to the
>  developers, you can do so now.

The two buttons are "Close WinZip" and "Close WinZip after creating 
error log file"

Clicking on either button will close the wine session.

As I said before you can download the program at 
http://www.winzip.com/ddchomea.htm . This is the version that I am using.


Tony Lambregts

wine/dlls/shell32 shellord.c shlexec.c

[Sylvain Petreolle]

Couldn't Winzip be designed without thinking about an unsupported
listview control ? I know this should have appear before, but the facts
are here : WinZip fails in a source file called listview.c and the log
shows a line upper a
fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS
> > WinZip internal error in file listview.c line 1236
> >
> > *WinZip will exit. Please restart WinZip and try again.*

___________________________________________________________
Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français !
Yahoo! Mail : http://fr.mail.yahoo.com

wine/dlls/shell32 shellord.c shlexec.c

[Guy L. Albertelli]

----- Original Message -----
From: "Sylvain Petreolle" <spetreolle(a)yahoo.fr>
To: "Tony Lambregts" <tony_lambregts(a)telusplanet.net>;
<wine-devel(a)winehq.com>
Sent: Thursday, July 25, 2002 6:29 PM
Subject: Re: wine/dlls/shell32 shellord.c shlexec.c
> Couldn't Winzip be designed without thinking about an unsupported
> listview control ? I know this should have appear before, but the facts
> are here : WinZip fails in a source file called listview.c and the log
> shows a line upper a
> fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS

In general yes, but in this particular case no. I am running the 20020710
version with all the new Common control patches including Listview (but none
of the other patches above 20020710). Both WinZip 8.1 (Evaluation) and 8.0
generate similar message streams:

WINZIP 8.0:
/home/albertel/t1/mywine/wine -- G:\Program Files\WinZip\WINZIP32.exe
Could not stat /mnt/winflp (No such file or directory), ignoring drive A:
fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS
fixme:shell:SHGetFileInfoA set icon to shell size, stub
fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray 0x40536a3c



WINZIP 8.1 Evaluation version:
/home/albertel/t1/mywine/wine -- C:\Program Files\WinZip\WINZIP32.exe
Could not stat /mnt/winflp (No such file or directory), ignoring drive A:
fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS
fixme:shell:SHGetFileInfoA set icon to shell size, stub
fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray 0x405368a4

All the toolbar and listview fixme's are related to window styles that are
not correctly implemented. The toolbar is the inability to drag buttons
around. The listview is related to who frees the imagelist at termination.
The SetColumnOrderArray I think is a mistyped TRACE.

I agree that the problem is one of the other patches.

Guy

wine/dlls/shell32 shellord.c shlexec.c

[Duane Clark]

Tony Lambregts wrote:
> It seems that one of  the patches to shlexec.c has broken WinZip.  The 
> following is a trace from WinZip from this morning.
>
> fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
> fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
> fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS
> err:shell:SHGetFileInfoA pidl is null!
> fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray 0x405b689c
> err:shell:SHGetFileInfoA pidl is null!
>
> I have been trying to debug this for a while and it did not have this 
> problem yesterday. If you want to download WinZip here is the url 
> http://www.winzip.com/

Well, I do see the same thing, but the patch that breaks it for me is 
this one:

http://www.winehq.com/hypermail/wine-cvs/2002/07/0189.html

wine/dlls/shell32 shellord.c shlexec.c

[Uwe Bonnes]

> > > > > "Duane" == Duane Clark <dclark(a)akamail.com> writes:

Duane> Tony Lambregts wrote:
    >>  It seems that one of the patches to shlexec.c has broken WinZip.
    >> The following is a trace from WinZip from this morning.
    >> 
    >> 
    >> fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not
    >> implemented fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG
    >> not implemented fixme:listview:LISTVIEW_UnsupportedStyles
    >> !LVS_SHAREIMAGELISTS err:shell:SHGetFileInfoA pidl is null!
    >> fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray
    >> 0x405b689c err:shell:SHGetFileInfoA pidl is null!
    >> 
    >> I have been trying to debug this for a while and it did not have this
    >> problem yesterday. If you want to download WinZip here is the url
    >> http://www.winzip.com/


    Duane> Well, I do see the same thing, but the patch that breaks it for
    Duane> me is this one:

    Duane> http://www.winehq.com/hypermail/wine-cvs/2002/07/0189.html

This patch has to do with environment string handling when using builtin
msvcrt.  Please verify that the problem  is still there when you use native
msvcrt. An perhaps debug a little how environment strings handling
influences your problem.

Bye

-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------

wine/dlls/shell32 shellord.c shlexec.c

[Duane Clark]

Uwe Bonnes wrote:
> This patch has to do with environment string handling when using builtin
> msvcrt.  Please verify that the problem  is still there when you use native
> msvcrt. An perhaps debug a little how environment strings handling
> influences your problem.

At least in my case, I am using native msvcrt (because I have problems 
with CxxFrameHandler in Xilinx ISE).

wine/dlls/shell32 shellord.c shlexec.c

[Alexandre Julliard]

Duane Clark <dclark(a)akamail.com> writes:
> At least in my case, I am using native msvcrt (because I have problems
> with CxxFrameHandler in Xilinx ISE).

If you still have problems with CxxFrameHandler in latest CVS, please
send me a +seh trace and I'll look into it.

-- 
Alexandre Julliard
julliard(a)winehq.com

wine/dlls/shell32 shellord.c shlexec.c

[Duane Clark]

I wrote:
> Well, I do see the same thing, but the patch that breaks it for me is 
> this one:

Oops, I was going back and forth with CVS, and apparently screwed up. My 
apologies to Uwe.

So this time I went back and forth twice and carefully watched which 
files were being patched. Would you believe these two patches (they 
apparently are a pair)?

http://www.winehq.com/hypermail/wine-cvs/2002/07/0191.html
http://www.winehq.com/hypermail/wine-cvs/2002/07/0192.html


Alexandre Julliard wrote:
> Duane Clark <dclark(a)akamail.com> writes:
> > At least in my case, I am using native msvcrt (because I have problems
> > with CxxFrameHandler in Xilinx ISE).
>
> If you still have problems with CxxFrameHandler in latest CVS, please
> send me a +seh trace and I'll look into it.

Okay, just checked. That particular bug is indeed gone.

wine/dlls/shell32 shellord.c shlexec.c

[Tony Lambregts]

Duane Clark wrote:
> Tony Lambregts wrote:
> > It seems that one of  the patches to shlexec.c has broken WinZip.  
> > The following is a trace from WinZip from this morning.
> >
> > fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
> > fixme:toolbar:TOOLBAR_CheckStyle [10026] TBSTYLE_ALTDRAG not implemented
> > fixme:listview:LISTVIEW_UnsupportedStyles   !LVS_SHAREIMAGELISTS
> > err:shell:SHGetFileInfoA pidl is null!
> > fixme:listview:LISTVIEW_SetColumnOrderArray iCount 9 lpiArray 0x405b689c
> > err:shell:SHGetFileInfoA pidl is null!
> >
> > I have been trying to debug this for a while and it did not have this 
> > problem yesterday. If you want to download WinZip here is the url 
> > http://www.winzip.com/
>
> Well, I do see the same thing, but the patch that breaks it for me is 
> this one:
>
> http://www.winehq.com/hypermail/wine-cvs/2002/07/0189.html

My appologies to you Duane. It was not your patch, It was Juergen 
Schmied's patch,

http://www.winehq.com/hypermail/wine-cvs/2002/07/0191.html

and **this one by Alexandre Julliard which is required by the previous 
patch.

http://www.winehq.com/hypermail/wine-cvs/2002/07/0192.html

Of course its a huge patch that covers lots of files so I have know idea 
what its doing wrong.  I was right about it beeing a shell32 problem 
though. <Grin>


Tony Lambregts