Re: [PATCH] WINSPOOL.DRV: Choose first printer found as the default

[Detlef Riekenberg]

On Di, 2007-07-03 at 14:06 -0300, Pedro Araujo Chaves Jr. wrote:
> # [PATCH] WINSPOOL.DRV: Choose first printer found as the default

Why do you think, that you need this?

Different default Printers (CUPS and Wine) confuse most Users.
>

-- 
 
By by ... Detlef

[PATCH] WINSPOOL.DRV: Choose first printer found as the default

[Pedro Araujo Chaves Jr.]

Detlef Riekenberg wrote:
> On Di, 2007-07-03 at 14:06 -0300, Pedro Araujo Chaves Jr. wrote:
> > # [PATCH] WINSPOOL.DRV: Choose first printer found as the default
>
> Why do you think, that you need this?
>
> Different default Printers (CUPS and Wine) confuse most Users.

Unless I'm mistaken:

1. The patch only sets a printer as the default if CUPS doesn't define
one itself;
2. Windows always has a default printer, unless none is installed — of
course, the user may change the default from Windows' first choice;
3. On Windows, if the default printer is deleted, another one is
automatically assigned as default (and thus #2 above is always true);
4. This fixes bugs #8475 [1] and #8476 [2]. (Those two applications
are kinda critical here in my company.)

[1] http://bugs.winehq.org/show_bug.cgi?id=8475
[2] http://bugs.winehq.org/show_bug.cgi?id=8476

- Pedro.

--
"It is assumed that the reader is reasonably familiar with the dpkg
System Administrator's manual. Unfortunately this manual does not yet
exist."  (Debian Packaging Manual)

[PATCH] WINSPOOL.DRV: Choose first printer found as the default

[Detlef Riekenberg]

On Mi, 2007-07-04 at 00:00 -0300, Pedro Araujo Chaves Jr. wrote:
> 1. The patch only sets a printer as the default if CUPS doesn't define
> one itself;

Sorry, I misinterpreted the Patch because of the subject.

I'm fine with your Patch, when you fix your typo:
> +    if (hadprinter & !haddefault)
> +        WINSPOOL_SetDefaultPrinter(dests[0].name, dests[i].name, TRUE);

With greetings from Copy and Paste: [i]  =>  [0]


For the subject, I suggest to include "Fallback":
winspool.drv: Fallback to the first found printer as default printer


Thanks.

-- 
 
By by ... Detlef