Re: [PATCH] wined3d: Fix some videocards property detection
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Please keep wine-devel in CC. There are more developers than just myself :-) . Am 2015-03-28 um 12:38 schrieb Sergey Isakov:
I know this crash. It was appeared because this patch was introduced in the wrong place as I describe in the bug 38277 Too slow test Advanced Pixel Shaders in 3DMark2001SE <https://bugs.winehq.org/show_bug.cgi?id=38277> My patch works fine. It may work fine on the Macs you tested or even all the macs that ever shipped, but it is still ugly to hardcode GPU capabilities that the driver should provide.
There are OpenGL flags winemac.drv can set to disable the software fallback: https://developer.apple.com/library/mac/qa/qa1502/_index.html . What happens when you set them? Do they influence the reported capabilities? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFpW6AAoJEN0/YqbEcdMwaz4P/298Ha4rtgWPYEFF+w6HzAWP f7G9fenhHkgjaudNwjcFXTr1dweYTVwvVll5Ahpu9bRd4iC/hM4jyKf2TVcpcXbM +yIri1UnsgSt63YJ1+XRfvVsV28BYlhqnlZvqKkmNHf/5dxg0iOfz0noDYAcspFZ BjfVQOFgaRmuiS9AyVpgc5WO2+IptKvDa1ExSOSNhOO5ye7T9Nh071QoWCgakqza invrADPRjRm/Ri7JV6CtQeRZCLYdMjeONchhJOHif2KYjk8/J5PNVAUeSSt73ZXQ TPA/VmPAs9mge3QlKgD9NgIab8auPt0tHW3MLLluKbLmwOJSMsOuxx85VC4yxlvK K/h0Q7Ldx8BvmsraLjmNMPmB9FMUNuxmEhjrkdbN90v9FwfsfZs5PGm6V+Rmt4uq gBHQxY2wd6xUt6I4AFH+6s088Ubl7zQRdAsE12LTMnRHF0ctIvHZCVdtdgVG/0hu ZpxrnHgoWm4E9arzslkHOxaqAh1Tln8k9WtpF6PcGNv4xbLWKLNiRBHMF4fK9MQI PtbT7gzL71+38lArzqnCzKb4Ijw1X7PkgA//4ZlkENyCp9SKxWpLQaDq853mhGlQ Q8z6TqAgb1wIwqO/rfiX6Rqj+aWt9Zet4XDhLaLbsifRnGjr4gad9LSC28GzQfet d80ZXwigJshmdtl05+I6 =+1lX -----END PGP SIGNATURE-----
On Mar 28, 2015, at 6:51 AM, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
There are OpenGL flags winemac.drv can set to disable the software fallback: https://developer.apple.com/library/mac/qa/qa1502/_index.html . What happens when you set them? Do they influence the reported capabilities?
The Mac driver is already setting those, by default. Software rendering is disabled unless you set a registry setting. That doesn't mean that fragment processing and vertex processing are done on the GPU, though. Disabling the software renderer is not the same as insisting that nothing significant gets done in software. So, evidently, it doesn't affect how many uniforms are reported. -Ken
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-28 um 13:00 schrieb Ken Thomases:
The Mac driver is already setting those, by default. Software rendering is disabled unless you set a registry setting. In that situation I'd expect Sergey to get a black screen in the affected 3dmark2001 test rather than slow rendering. Sergey, do you have HKCU\Software\Wine\Mac Driver\AllowSoftwareRendering set?
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFpfOAAoJEN0/YqbEcdMwEu8QAIbbxnWHSeuQIPMidiYSDD13 BtbiDGMslKfSRLoMKOsCbeXBoXMLHh4tzYMj3ns2DsmQBiP8LziT6wwdT0WOPpEX g1KUHNhYMG0hdUeX5lgSuTA1pjcXVbgZwL5MgJosalZmdx8LoVc9kfVeqZ2qijBX EMWF1Ld6PalNxCEqnqWsqrzOhGluKEFoObB8/W8ETaeypvXIr+BYwKKMBWsFd7Dn 7rxeZTr07uu85sb+eyfM9twEy7OCqKiAKlHwmoaxVILftDNyShn/27BisvU1ThSa jO6lJUIgUeWNYZCdX4BSHlNLRbM5MkjpmglALLdk1RarG/XpihUvtJggnqlqj+f8 VQeRhr8ZZ6kzALTF7YlOsIAmWt0CgTKsGQ7uyc+7MJsc+s+AR1Lm4iqYZX55hVRN nHwriFqvZSxy41w3kTaXFZPiVgs6u5StpMCp+QduM7wLH8aCyFgXqfb+h3xl+yTe tAz2d1dVG0Nrj9jzXQou1wSrB1Jur1O/7u+MuDcD+71oZrZj7hPZSxu5X46ju5SY oaOrgj5wdSUvZ23yEXzNvA0RCtfEBg7KjJF+5gmJtIkP4F5LgM9v4D+B+/xtEior iYOJ63VbTcc/Yd8U7oplAL+0Kg8QRGSmxVafvK8vMM0jAXsFUgk0yNQAyQExhglZ k/+BCb8R2taOaTqgJre7 =/wRR -----END PGP SIGNATURE-----
participants (2)
-
Ken Thomases -
Stefan Dösinger