Re: [PATCH 4/5] riched20: Stub for ITextFont interface and implement ITextRange::GetFont.

[Huw Davies]

On Wed, Sep 17, 2014 at 05:39:23PM +0800, Jactry Zeng wrote:
> +typedef struct ITextFontImpl {
> +    ITextFont ITextFont_iface;
> +    LONG ref;
> +    struct list entry;
> +
> +    IRichEditOleImpl *reOle;
> +    ITextRangeImpl *txtRge;
> +    ITextSelectionImpl *txtSel;
> +} ITextFontImpl;

Since the ITextFont objects do hold a ref on their parent range /
selection objects I don't think we need the list stuff again.

I wouldn't store the reOle pointer here, but use txtRge / txtSel
to access it (and check for disconnections).  You probably
want a helper function to do that.

Huw.

[PATCH 4/5] riched20: Stub for ITextFont interface and implement ITextRange::GetFont.

[Jactry Zeng]

Hi Huw,
2014-09-17 18:23 GMT+08:00 Huw Davies <huw(a)codeweavers.com>:
> Since the ITextFont objects do hold a ref on their parent range /
> selection objects I don't think we need the list stuff again.
>
> I wouldn't store the reOle pointer here, but use txtRge / txtSel
> to access it (and check for disconnections).  You probably
> want a helper function to do that.

I will have another try.
Thanks for your review!

-- 
Regards,
Jactry Zeng