Re : shell32: Add IShellFolderView:: GetSelectedObjects implementation for IShellView.
Hi Nikolay, I know this one's already been comitted, but I have a small complaint about a comment: + /* it's documented that caller shouldn't PIDLs, only array itself */ I think you're missing a verb there. A caller shouldn't do what to PIDLs, exactly? Perhaps it should be obvious to me, but I couldn't guess by looking at it. Thanks, --Juan
On 3/22/2010 19:35, Juan Lang wrote:
Hi Nikolay,
I know this one's already been comitted, but I have a small complaint about a comment: + /* it's documented that caller shouldn't PIDLs, only array itself */
I think you're missing a verb there. A caller shouldn't do what to PIDLs, exactly? Perhaps it should be obvious to me, but I couldn't guess by looking at it.
Hi, Juan. Caller shouldn't free PIDLs, that's what I meant, and that's why internally stored is returned instead of cloning it. Thanks for that, I'll fix it.
Thanks, --Juan
participants (2)
-
Juan Lang -
Nikolay Sivov