Re: [4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.

[Stefan Dösinger]

Does the enum_device_entry structure have to be in ddraw_private.h? I think you can just declare it in ddraw.c because it is used only there.

At some point we'll want to get rid of the ddraw device type strings and call wined3d_get_adapter_identifier - but that needs more work and some more tests.


Am 31.05.2011 um 12:50 schrieb Andrew Nguyen:
> ---
> dlls/ddraw/ddraw.c         |   43 +++++++++++++------
> dlls/ddraw/ddraw_private.h |    8 ++++
> dlls/ddraw/tests/d3d.c     |   98 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 136 insertions(+), 13 deletions(-)
>
> <0004-ddraw-Extend-the-lifetime-of-the-EnumDevices-strings-b.txt>

[4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.

[Andrew Nguyen]

On 05/31/2011 10:47 AM, Stefan Dösinger wrote:
> Does the enum_device_entry structure have to be in ddraw_private.h? I
> think you can just declare it in ddraw.c because it is used only there.

No, I simply defined the structure there to be consistent with the role
of the unused structure definitions I removed earlier. I can certainly
move the definition to ddraw.c.

[4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.

[Stefan Dösinger]

Am 31.05.2011 um 18:00 schrieb Andrew Nguyen:
> No, I simply defined the structure there to be consistent with the role
> of the unused structure definitions I removed earlier. I can certainly
> move the definition to ddraw.c.
> Yes, please. And yeah, the existing code could use some improvement in this regard too, but that is of course beyond the scope of this patch.