Re: WINE Regression due to patch applied Feb 22, 2005 10:50 CDT
The patch that changed these files is: ChangeSet ID: 16245 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/02/22 09:50:14
That patch isn't directly responsible for the bug, it has probably just revealed it. The bugfix will be sent as soon as the previous bugfixes are accepted. It looks more or less like this: Index: editor.c =================================================================== RCS file: /home/wine/wine/dlls/riched20/editor.c,v retrieving revision 1.59 diff -u -r1.59 editor.c --- editor.c 3 Oct 2005 18:45:39 -0000 1.59 +++ editor.c 9 Oct 2005 15:00:34 -0000 @@ -2062,10 +2075,10 @@ if (item->member.run.nFlags & MERF_ENDPARA) { - *buffer++ = '\r'; + *buffer = '\r'; if (bCRLF) { - *buffer = '\n'; + *(++buffer) = '\n'; nWritten++; } assert(nLen == 1); Check it out, it works for me. Krzysztof
Krzysztof Foltman wrote:
The bugfix will be sent as soon as the previous bugfixes are accepted. It looks more or less like this:
This fixes the installer for me. Arren's original problem running KeyNote should be fixed with the attached patch... can you confirm if it fixes the problem or not Arren? Mike
Unfortunately, the patch you sent me didn't seem to have any effect on the application. It still crashes with exactly the same error. Here's a new backtrace if it helps. alex(a)ALEX:~$ wine winedbg /win/D/Program\ Files/KeyNote/keynote.exe WineDbg starting on pid 0xa In 32 bit mode. 0x404be83c start_process+0xfc [/home/alex/Base/wine-20050930/dlls/kernel/../../include/winternl.h:1679] in kernel32: jmp 0x404be82b start_process+0xeb [/home/alex/Base/wine-20050930/dlls/kernel/process.c:992] in kernel32 1679 static inline void WINAPI DbgBreakPoint(void) { __asm__ __volatile__("int3"); } Wine-dbg>cont fixme:tab:TAB_WindowProc Unimplemented msg TCM_SETEXTENDEDSTYLE fixme:tab:TAB_WindowProc Unimplemented msg TCM_SETEXTENDEDSTYLE fixme:tab:TAB_WindowProc Unimplemented msg TCM_GETEXTENDEDSTYLE fixme:richedit:RichEditANSIWndProc EM_LIMITTEXT: stub fixme:richedit:RichEditANSIWndProc EM_EXLIMITTEXT: stub fixme:richedit:RichEditANSIWndProc EM_GETOPTIONS: stub fixme:richedit:RichEditANSIWndProc EM_SETOPTIONS: stub fixme:richedit:RichEditANSIWndProc EM_AUTOURLDETECT: stub fixme:richedit:RichEditANSIWndProc EM_SETUNDOLIMIT: stub fixme:richedit:RichEditANSIWndProc EM_SETTEXTMODE: stub fixme:richedit:RichEditANSIWndProc EM_SETLANGOPTIONS: stub fixme:richedit:RichEditANSIWndProc EM_SETOLECALLBACK: stub fixme:richedit:RichEditANSIWndProc EM_GETOLEINTERFACE 0x4153fdc0: stub fixme:richedit:IRichEditOle_fnSetHostNames stub 0x403b7808 keynote keynote fixme:richedit:RichEditANSIWndProc EM_HIDESELECTION: stub fixme:richedit:RichEditANSIWndProc EM_SETUNDOLIMIT: stub fixme:winspool:WINSPOOL_EnumPrinters We don't handle PRINTER_ENUM_CONNECTIONS fixme:winspool:WINSPOOL_EnumPrinters We don't handle PRINTER_ENUM_CONNECTIONS err:psdrv:PSDRV_PPDDecodeHex Invalid hex char in hex string err:psdrv:PSDRV_PPDDecodeHex Invalid hex char in hex string err:psdrv:PSDRV_PPDDecodeHex Invalid hex char in hex string err:psdrv:PSDRV_PPDDecodeHex Invalid hex char in hex string err:psdrv:PSDRV_PPDDecodeHex Invalid hex char in hex string err:psdrv:PSDRV_PPDDecodeHex Invalid hex char in hex string First chance exception: page fault on read access to 0x00000000 in 32-bit code (0x404c6151). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:0000 EIP:404c6151 ESP:407bfbd0 EBP:407bfc10 EFLAGS:00210216( - 00 -RIAP1) EAX:403d4c78 EBX:404f871c ECX:00000000 EDX:00002000 ESI:403d4c78 EDI:00000000 Stack dump: 0x407bfbd0: 403cf320 407bfc00 401a6aa1 402da8dc 0x407bfbe0: 41555e8c 00000018 403cf320 00000018 0x407bfbf0: 00000018 401c81a8 40555f80 00000000 0x407bfc00: 407bfc2c 404f871c 407bfc88 00000000 0x407bfc10: 407bfc50 404c677a 403cf300 00000000 0x407bfc20: 00000000 403d4c78 00002000 403cf320 Backtrace: =>1 0x404c6151 PROFILE_GetPrivateProfileString(section=0x403cf300, entry=0x0, def_val=0x0, buffer=0x403d4c78, len=0x2000, filename=0x403cf320, win32=0x1) [/home/alex/Base/wine-20050930/dlls/kernel/../../include/winbase.h:2034] in kernel32 (0x407bfc10) 2 0x404c677a GetPrivateProfileStringW+0x5a(section=0x403cf300, entry=0x0, def_val=0x0, buffer=0x403d4c78, len=0x2000, filename=0x403cf320) [/home/alex/Base/wine-20050930/dlls/kernel/profile.c:1231] in kernel32 (0x407bfc50) 3 0x404c6607 GetPrivateProfileStringA(section=0x415442b0, entry=0x0, def_val=0x0, buffer=0x41566f6c, len=0x2000, filename=0x41555e8c) [/home/alex/Base/wine-20050930/dlls/kernel/profile.c:1200] in kernel32 (0x407bfcb4) 4 0x0045b51a in keynote (+0x5b51a) (0x407bfd0c) 5 0x0045b5f7 in keynote (+0x5b5f7) (0x407bfd50) 6 0x00476809 in keynote (+0x76809) (0x407bfd74) 7 0x00476d07 in keynote (+0x76d07) (0x407bfda8) 8 0x00430f4d in keynote (+0x30f4d) (0x407bfee8) 9 0x00436321 in keynote (+0x36321) (0x407bff0c) 10 0x0053d57c EntryPoint in keynote (0x407bff20) 11 0x404be830 start_process(arg=0x0) [/home/alex/Base/wine-20050930/dlls/kernel/process.c:992] in kernel32(0x407bfff4) 12 0x4002c025 (0x00000000) 0x404c6151 PROFILE_GetPrivateProfileString+0x1a1 [/home/alex/Base/wine-20050930/dlls/kernel/../../include/winbase.h:2034] in kernel32: movzwl 0x0(%edi),%eax 2034 while ((count > 1) && *s) Wine-dbg> _________________________________________________________________ Powerful Parental Controls Let your child discover the best the Internet has to offer. http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=htt... Start enjoying all the benefits of MSN® Premium right now and get the first two months FREE*.
Arren Lex wrote:
Unfortunately, the patch you sent me didn't seem to have any effect on the application. It still crashes with exactly the same error. Here's a new backtrace if it helps.
Does this patch do any better? (you'll need to back out the other one first...) cd ~/wine patch -p0 -R < getpps-null.diff patch -p0 < getpps-null-2.diff make thanks, Mike
Whoa! It works now!!! Beautiful!!! Thank you so much for helping me! You rock! Will this patch be made an official part of wine or will I have to apply it every time I upgrade? And THANK YOU AGAIN!! _________________________________________________________________ Take charge with a pop-up guard built on patented Microsoft® SmartScreen Technology http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=htt... Start enjoying all the benefits of MSN® Premium right now and get the first two months FREE*.
participants (3)
-
Arren Lex -
Krzysztof Foltman -
Mike McCormack