re: [PATCH 13/19] vbscript: Added class functions parser implementation

[Dan Kegel]

Fails here under WINEDEBUG=warn-heap:

../../../tools/runtest -q -P wine -M vbscript.dll -T ../../.. -p
vbscript_test.exe.so run.c && touch run.ok
wine: Unhandled page fault on read access to 0x55555555 at address
0x4004c1e4 (thread 0019), starting debugger...
Backtrace:
=>0 0x4004c1e4 add_class_function+0x29(ctx=0x33fad8,
class_decl=0x151dd4, decl=0x151dbc) [dlls/vbscript/parser.y:638]
  1 0x4004b63e parser_parse+0xee6(ctx=0x33fad8) [dlls/vbscript/parser.y:294]
  2 0x4004c3a2 parse_script+0xae(ctx=0x33fad8, code="...",
ret=0x33fbe8) [dlls/vbscript/compile.c:961]
  4 0x40049685 VBScriptParse_ParseScriptText+0x12d(iface=0x125e5c,
pstrCode="...", pstrItemName=0x0(nil), punkContext=(nil),
pstrDelimiter=0x0(nil), dwSourceContextCookie=0, ulStartingLine=0,
dwFlags=0, pvarResult=(nil), pexcepinfo=(nil))
[dlls/vbscript/vbscript.c:554]
  5 0x684b796d parse_script+0x32c(flags=0x8, script_str="...")
[dlls/vbscript/tests/run.c:683]
  6 0x684b7e99 run_from_res+0x15b(name="lang.vbs")
[dlls/vbscript/tests/run.c:784]
  7 0x684b845c run_tests+0x4eb() [dlls/vbscript/tests/run.c:841]
  8 0x684b854c func_run+0x7a() [dlls/vbscript/tests/run.c:871]
  9 0x684bb2d3 run_test+0x9e(name="run.c")
[dlls/vbscript/tests/../../../include/wine/test.h:556]
0x4004c1e4 add_class_function+0x29 [dlls/vbscript/parser.y:638] in
vbscript: movl       0x0(%eax),%eax
638             if(!strcmpiW(iter->name, decl->name)) {


On Thu, Sep 15, 2011 at 8:16 AM,  <buildbot(a)kegel.com> wrote:
> This is an experimental automated build and test service.
> Please feel free to ignore this email while we work the kinks out.
>
> For more info about this message, see http://wiki.winehq.org/BuildBot
>
> The Buildbot has detected a failed build on builder runtests-heaptest while building Wine.
> Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/92 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting)
> BUILD FAILED: failed shell_3
>
> Errors:
> make: *** [run.ok] Error 5

[PATCH 13/19] vbscript: Added class functions parser implementation

[Jacek Caban]

On 09/15/11 18:38, Dan Kegel wrote:
> Fails here under WINEDEBUG=warn-heap:
>
> ../../../tools/runtest -q -P wine -M vbscript.dll -T ../../.. -p
> vbscript_test.exe.so run.c&&  touch run.ok
> wine: Unhandled page fault on read access to 0x55555555 at address
> 0x4004c1e4 (thread 0019), starting debugger...
> Backtrace:
> =>0 0x4004c1e4 add_class_function+0x29(ctx=0x33fad8,
> class_decl=0x151dd4, decl=0x151dbc) [dlls/vbscript/parser.y:638]
>    1 0x4004b63e parser_parse+0xee6(ctx=0x33fad8) [dlls/vbscript/parser.y:294]
>    2 0x4004c3a2 parse_script+0xae(ctx=0x33fad8, code="...",
> ret=0x33fbe8) [dlls/vbscript/compile.c:961]
>    4 0x40049685 VBScriptParse_ParseScriptText+0x12d(iface=0x125e5c,
> pstrCode="...", pstrItemName=0x0(nil), punkContext=(nil),
> pstrDelimiter=0x0(nil), dwSourceContextCookie=0, ulStartingLine=0,
> dwFlags=0, pvarResult=(nil), pexcepinfo=(nil))
> [dlls/vbscript/vbscript.c:554]
>    5 0x684b796d parse_script+0x32c(flags=0x8, script_str="...")
> [dlls/vbscript/tests/run.c:683]
>    6 0x684b7e99 run_from_res+0x15b(name="lang.vbs")
> [dlls/vbscript/tests/run.c:784]
>    7 0x684b845c run_tests+0x4eb() [dlls/vbscript/tests/run.c:841]
>    8 0x684b854c func_run+0x7a() [dlls/vbscript/tests/run.c:871]
>    9 0x684bb2d3 run_test+0x9e(name="run.c")
> [dlls/vbscript/tests/../../../include/wine/test.h:556]
> 0x4004c1e4 add_class_function+0x29 [dlls/vbscript/parser.y:638] in
> vbscript: movl       0x0(%eax),%eax
> 638             if(!strcmpiW(iter->name, decl->name)) {

Thanks for the report. It lacks initialization of a variable (that was 
done in later, not yet sent patch). I've sent a fix.

Jacek