libs don't compile without warnings

[Fabian Maurer]

Hello,

The integrated libraries under libs don't compile without warnings.
Is there a way to suppress those warnings, but keep the ones from normal wine
files? I'd like to compile wine with Werror, and fix the warnings we have, but
this makes it impossible.

Regards,
Fabian Maurer

[Nikolay Sivov]

On 4/23/22 22:08, Fabian Maurer wrote:
> Hello,
>
> The integrated libraries under libs don't compile without warnings.
> Is there a way to suppress those warnings, but keep the ones from normal wine
> files? I'd like to compile wine with Werror, and fix the warnings we have, but
> this makes it impossible.

What are you compiling with? With "current" debian testing tools, 
including mingw-w64, I don't get compilation warnings.
> Regards,
> Fabian Maurer

[Fabian Maurer]

Hello Nikolay,
> > The integrated libraries under libs don't compile without warnings.
> > Is there a way to suppress those warnings, but keep the ones from normal
> > wine files? I'd like to compile wine with Werror, and fix the warnings we
> > have, but this makes it impossible.
>
> What are you compiling with? With "current" debian testing tools,
> including mingw-w64, I don't get compilation warnings.

That's probably because I compile with -Wall. There's for example a lot unused
variable/function and format string errors.

My gcc/mingw version is 11.2.0 (Arch Linux)

Regards,
Fabian Maurer

[Rémi Bernon]

On 4/24/22 01:33, Fabian Maurer wrote:
> Hello Nikolay,
> > > The integrated libraries under libs don't compile without warnings.
> > > Is there a way to suppress those warnings, but keep the ones from normal
> > > wine files? I'd like to compile wine with Werror, and fix the warnings we
> > > have, but this makes it impossible.
> >
> > What are you compiling with? With "current" debian testing tools,
> > including mingw-w64, I don't get compilation warnings.
>
> That's probably because I compile with -Wall. There's for example a lot unused
> variable/function and format string errors.
>
> My gcc/mingw version is 11.2.0 (Arch Linux)
>
> Regards,
> Fabian Maurer

That's probably because third-party libs are built without Wine warning 
flags, but not without user-specified warning flags. You will probably 
have to change something in makedep.c to make sure user warnings are 
filtered out there too, or add -Wall / -Werror to Wine warnings in 
configure.ac instead.

-- 
Rémi Bernon <rbernon(a)codeweavers.com>

[Fabian Maurer]

On Sonntag, 24. April 2022 14:18:14 CEST Rémi Bernon wrote:
> On 4/24/22 01:33, Fabian Maurer wrote:
> > Hello Nikolay,
> > > > The integrated libraries under libs don't compile without warnings.
> > > > Is there a way to suppress those warnings, but keep the ones from normal
> > > > wine files? I'd like to compile wine with Werror, and fix the warnings
> > > > we
> > > > have, but this makes it impossible.
> > >
> > > What are you compiling with? With "current" debian testing tools,
> > > including mingw-w64, I don't get compilation warnings.
> >
> > That's probably because I compile with -Wall. There's for example a lot
> > unused variable/function and format string errors.
> >
> > My gcc/mingw version is 11.2.0 (Arch Linux)
> >
> > Regards,
> > Fabian Maurer
>
> That's probably because third-party libs are built without Wine warning
> flags, but not without user-specified warning flags. You will probably
> have to change something in makedep.c to make sure user warnings are
> filtered out there too, or add -Wall / -Werror to Wine warnings in
> configure.ac instead.

Ah, seems I was wrong, there is no need for -Wall, since Wine uses that per 
default already. Thanks for pointing me the right way, it's part of 
EXTRACFLAGS.

Though that means that my warnings/errors are not due to additional flags.
For completeness, attaching a patch that shows all the warnings I god.
It's a bunch of "might not be initialized" and three cases of "string 
overflow".

Regards,
Fabian Maurer

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=113234

Your paranoid android.


=== w10pro64_ja (64 bit report) ===

dwrite:
layout.c:4816: Test failed: 0: unexpected name L"Meiryo UI".

=== w10pro64_zh_CN (64 bit report) ===

dwrite:
layout.c:4816: Test failed: 0: unexpected name L"Meiryo UI".

=== w8adm (32 bit report) ===

kernel32:
path: Timeout