Re: fusion: add a stub for CopyPDBs

[Sebastian Lackner]

On 02.12.2015 07:19, Austin English wrote:
> +void WINAPI CopyPDBs(const WCHAR *module)

Did you find the prototype somewhere? The output doesn't really look a WCHAR string:

fixme:fusion:CopyPDBs (L"\4141\636a\304d\7257\5355\666c\4262\3552\7445\5063\3353\5338\3533\5656\6f63\7674\427a\7457\6249\4d41\7858\7362\5135\6164\6b36\4c71\5277\3351\642f\796c\5755\7452\3735\6a50\3658\5a59\546d\5763\4276\7a45\4b43\5362\7655\5132\4b39\4339\4d37\5131\4f79\5645\452b\5364\4272\4a51\3832\4458\5435\6b77\3454\3135\2f52"...) stub!

It could be a char *, but on the other hand also some internal data, so its probably better to use void *.
For the result, several hints on the internet seem to suggest that its HRESULT.

Regards,
Sebastian

fusion: add a stub for CopyPDBs

[Austin English]

On Fri, Dec 4, 2015 at 1:39 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote:
> On 02.12.2015 07:19, Austin English wrote:
> > +void WINAPI CopyPDBs(const WCHAR *module)
>
> Did you find the prototype somewhere? The output doesn't really look a WCHAR string:

The only example I've found was here:
https://github.com/dotnet/coreclr/blob/master/src/vm/ceeload.cpp#L3896
> fixme:fusion:CopyPDBs (L"\4141\636a\304d\7257\5355\666c\4262\3552\7445\5063\3353\5338\3533\5656\6f63\7674\427a\7457\6249\4d41\7858\7362\5135\6164\6b36\4c71\5277\3351\642f\796c\5755\7452\3735\6a50\3658\5a59\546d\5763\4276\7a45\4b43\5362\7655\5132\4b39\4339\4d37\5131\4f79\5645\452b\5364\4272\4a51\3832\4458\5435\6b77\3454\3135\2f52"...) stub!
>
> It could be a char *, but on the other hand also some internal data, so its probably better to use void *.

Ok.
> For the result, several hints on the internet seem to suggest that its HRESULT.

Yeah, you're right. I misread the source (FusionCopyPDBs vs CopyPDBs).
Later in FusionCopyPDBs there's:
    HRESULT hr;
    hr = CopyPDBs(pAssembly->GetFusionAssembly());

Thanks for reviewing.

-- 
-Austin