Re: [PATCH 2/2] winebrowser: Open the default browser if called without an argument.
Zebediah Figura <zfigura(a)codeweavers.com> writes:
xdg-open can't handle this, so work around with the following command (suggested by Vincent Povirk): gtk-launch `xdg-mime query default x-scheme-handler/http`
Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- programs/winebrowser/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
I'd suggest to simply open the default start page in that case. That's what iexplore does when there are no arguments. -- Alexandre Julliard julliard(a)winehq.org
I'd suggest to simply open the default start page in that case. That's what iexplore does when there are no arguments.
That's the intent. We don't know what the default start page is for the user's default browser, but it should open it when started with no arguments.
Vincent Povirk <madewokherd(a)gmail.com> writes:
I'd suggest to simply open the default start page in that case. That's what iexplore does when there are no arguments.
That's the intent. We don't know what the default start page is for the user's default browser, but it should open it when started with no arguments.
I don't mean the default page for the Unix browser, the behavior is apparently not guaranteed in that case. I mean get the default page configured on the Windows side, and open that. This way we don't need to worry about what the Unix browser will do with no arguments. -- Alexandre Julliard julliard(a)winehq.org
So, we'd just load winehq.org? Seems pretty weird to me. I think it's reasonable to expect that a browser will open when its desktop file is called with no arguments. Whether it loads to its default start page is unimportant. On Thu, Aug 3, 2017 at 1:24 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Vincent Povirk <madewokherd(a)gmail.com> writes:
I'd suggest to simply open the default start page in that case. That's what iexplore does when there are no arguments.
That's the intent. We don't know what the default start page is for the user's default browser, but it should open it when started with no arguments.
I don't mean the default page for the Unix browser, the behavior is apparently not guaranteed in that case. I mean get the default page configured on the Windows side, and open that. This way we don't need to worry about what the Unix browser will do with no arguments.
-- Alexandre Julliard julliard(a)winehq.org
Vincent Povirk <madewokherd(a)gmail.com> writes:
So, we'd just load winehq.org? Seems pretty weird to me.
You can open the default search page instead.
I think it's reasonable to expect that a browser will open when its desktop file is called with no arguments. Whether it loads to its default start page is unimportant.
It's reasonable to expect that winebrowser will open, yes. That's precisely what's broken if we simply pass through to the Unix browser, so providing a default argument seems like an obvious fix. I don't see any benefit in adding complexity to try to make the Unix browser use its default page instead of ours. -- Alexandre Julliard julliard(a)winehq.org
On 08/03/2017 01:24 AM, Alexandre Julliard wrote:
Vincent Povirk <madewokherd(a)gmail.com> writes:
I'd suggest to simply open the default start page in that case. That's what iexplore does when there are no arguments.
That's the intent. We don't know what the default start page is for the user's default browser, but it should open it when started with no arguments.
I don't mean the default page for the Unix browser, the behavior is apparently not guaranteed in that case. I mean get the default page configured on the Windows side, and open that. This way we don't need to worry about what the Unix browser will do with no arguments.
The program in question loads the value of HKCR/htmlfile/shell/open/command and calls it with no arguments. If I change that to something other than iexplore, the behaviour is left up to that program. So I'm not sure that just following iexplore's behaviour is necessarily appropriate.
participants (3)
-
Alexandre Julliard -
Vincent Povirk -
Zebediah Figura