Re: renewed: wine/dlls/d3d8/device.c cleanup-3

[Raphael]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

On Thursday 25 March 2004 21:47, hatky wrote:
> Generate ERRs for implementations that exists only
> with OpenGL extentions or versions that were not found
> at compile time, other wise is is presnted as just
> unimplemented
>
> ChangeLog:
> Â Â Ofir Petruska <hatky(a)users.sf.net>
>   Errs for implemented with an unavailable OpenGL ver
>  #else
> -            case D3DTADDRESS_MIRROR:      /* Unsupported in OpenGL pre-1.4 > 
> */ 
> +            case D3DTADDRESS_MIRROR: ERR("Implemented with GL1.4 or an ARB 
> extention only\n");     /* Unsupported in OpenGL pre-1.4 */
>  #endif

Why you want to put an ERR here ?
for me it should be a WARN but only for debug purpose. 
D3D games normally only use what we declare to support (using GetDeviceCaps)
so i we say not supported ...

#if defined(GL_VERSION_1_3)
    pCaps->TextureAddressCaps |= D3DPTADDRESSCAPS_MIRROR;
#endif
> +#else
> +    ERR("Implemented only with GL_EXT_paletted_texture defined\n");
>  #endif

Well, paletted textures are not supported by many cards and i don't think 
users will like scrolling of non-errors traces in some games (it can be a 
warning for devs but not an error). On windows you can call 
SetCurrentTexturePalette if you card don't support it (the function should 
return with an error)
 
> +#else
> +  ERR("Ipmlemented only for OpenGL 1.3 and up\n");
>  #endi

Here it should be a FIXME. It must be implemented using GLXPixmaps 
for olders GLX versions (see the function comment)

Regards,
Raphael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAY3qOp7NA3AmQTU4RAjQ0AJwNuhHeXKxnkDQ8I/7mn+ZyKdI13wCePyGt
7sS7J/45W6nMbG3CFD5jWfE=
=QazV
-----END PGP SIGNATURE-----