Re: [PATCH 1/2] ole32/tests: Release() doesn't return HRESULT code

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=10342

Your paranoid android.


=== wvistau64 (32 bit moniker) ===
moniker: unhandled exception c0000005 at 00425FC9

=== w2008s64 (32 bit moniker) ===
moniker: unhandled exception c0000005 at 00425FC9

=== w7u (32 bit moniker) ===
moniker: unhandled exception c0000005 at 00425FC9

=== w8 (32 bit moniker) ===
moniker: unhandled exception c0000005 at 00425FC9

=== wvistau64 (64 bit moniker) ===
moniker: unhandled exception c0000005 at 00000000004209EA

=== w2008s64 (64 bit moniker) ===
moniker: unhandled exception c0000005 at 00000000004209EA

[PATCH 1/2] ole32/tests: Release() doesn't return HRESULT code

[Nikolay Sivov]

On 11/19/2014 12:27 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=10342
>
> Your paranoid android.
>
> === wvistau64 (32 bit moniker) ===
> moniker: unhandled exception c0000005 at 00425FC9
>
> === w2008s64 (32 bit moniker) ===
> moniker: unhandled exception c0000005 at 00425FC9
>
> === w7u (32 bit moniker) ===
> moniker: unhandled exception c0000005 at 00425FC9
>
> === w8 (32 bit moniker) ===
> moniker: unhandled exception c0000005 at 00425FC9
>
> === wvistau64 (64 bit moniker) ===
> moniker: unhandled exception c0000005 at 00000000004209EA
>
> === w2008s64 (64 bit moniker) ===
> moniker: unhandled exception c0000005 at 00000000004209EA

I don't see how this patch could crash it like that,
it doesn't change test sequence at all. Also works just fine
on Win8.1 VM.