Re: dxdiagn: Added properties for hardware acceleration capabilities

[Stefan Dösinger]

Am 23.03.2014 um 04:18 schrieb Markus Weiland <mw(a)graph-ix.net>:
> This patch addresses bug http://bugs.winehq.org/show_bug.cgi?id=11114 I filed four years ago. It hardcodes the b3DAccelerationExists, b3DAccelerationEnabled, and bDDAccelerationEnabled properties to TRUE.
> IDirect3D9::GetDeviceCaps with D3DDEVTYPE_HAL should do. If the call suceeds you have hardware acceleration.

dxdiagn: Added properties for hardware acceleration capabilities

[Markus Weiland]

Is this implementation ok?


On 14-03-23 07:20 PM, Stefan Dösinger wrote:
> Am 23.03.2014 um 04:18 schrieb Markus Weiland <mw(a)graph-ix.net>:
> > This patch addresses bug http://bugs.winehq.org/show_bug.cgi?id=11114 I filed four years ago. It hardcodes the b3DAccelerationExists, b3DAccelerationEnabled, and bDDAccelerationEnabled properties to TRUE.
> > IDirect3D9::GetDeviceCaps with D3DDEVTYPE_HAL should do. If the call suceeds you have hardware acceleration.

dxdiagn: Added properties for hardware acceleration capabilities

[Dmitry Timoshkov]

Markus Weiland <mw(a)graph-ix.net> wrote:
> +        BOOL hardware_accel;

Shouldn't this be VARIANT_BOOL and take appropriate value?
Also, patches should be sent to wine-patches.

-- 
Dmitry.

dxdiagn: Added properties for hardware acceleration capabilities

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-03-24 02:24, schrieb Markus Weiland:
> Is this implementation ok?
> Looks good to me.

I guess there's a difference between those 3 flags and I guess at
least bDDAccelerationEnabled should be queried from ddraw, but I think
your patch is a reasonable first step.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTMCGxAAoJEN0/YqbEcdMw+FoP/Ags1yIt7IQgX77r6wFsS+vM
n9LRuK2ZojOSCKrU/XeWy2X1txHSGXAA5ccqaqqr+EtFLOdOIYGM7qs8jpWBQFex
8nLSjYCMh6e0uG5qFZQUEH7WIcNgLd5SZmkbeqnCGdNem67YiSVrPGM8+9ujc9BY
xBPG4s5iittmj2Q0sOBSyCzgRNIJeA6WivtGqxPEGhiiG2+GgcJgMrPv271jpZgy
bCdF4M7f19TUofNEwLnyWbL7QJ9CvLPXJ3s6m0gQmz+N/GI9xG/hmhZHRo2yTWH7
jYirMqOZ5Q1/ycxdnE75y6bD9gF0tsWL0SELw8haluKAZXM1sapjT/rrQ8DtxhxQ
dn7xjtynIpQ4GQb4O5eLnC0rqSec5vNPt1HKaGonr+aJx39XNcpmGeTM13qn5zTA
2mFNOB4jYbjEhlYEkYWLQuFhsUFOeqxj9h3ruYYib/eM1BMfUQqN4pmTWc0+ttNi
hGtY0exJ2AAwDqWXxtt89zfSTAtx1hKJNJVSiU85Dj9NLDG9K/s4VKexntZh639c
Wc+XZKvsai1Ul/h6vAt59p5UId/50+b0bQb8kdU3izr4awjfXi86ESqt3hONvrm1
FCCW7j42Y3XvctL9HSfmOMIfVcpbREvYOLhFN6USD76NZWPTRpT/cN4tVTnzUhix
wlC4Z8CxRcTVaY2Wd+qG
=Vzxn
-----END PGP SIGNATURE-----