[PATCH 01/14] advapi32/tests: Fix some format-overflow warnings.
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/advapi32/tests/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c index 484167656f1..43d97386270 100644 --- a/dlls/advapi32/tests/service.c +++ b/dlls/advapi32/tests/service.c @@ -195,7 +195,7 @@ static void test_create_delete_svc(void) SC_HANDLE scm_handle, svc_handle1, svc_handle2; CHAR username[UNLEN + 1], domain[MAX_PATH]; DWORD user_size = UNLEN + 1; - CHAR account[UNLEN + 3]; + CHAR account[MAX_PATH + UNLEN + 1]; static const CHAR servicename [] = "winetest_create_delete"; static const CHAR pathname [] = "we_dont_care.exe"; static const CHAR empty [] = ""; -- 2.25.0
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/advpack/tests/files.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/advpack/tests/files.c b/dlls/advpack/tests/files.c index 1851dc16f07..135a09f97d6 100644 --- a/dlls/advpack/tests/files.c +++ b/dlls/advpack/tests/files.c @@ -101,7 +101,7 @@ static void test_AddDelBackupEntry(void) { BOOL ret; HRESULT res; - CHAR path[MAX_PATH]; + CHAR path[MAX_PATH + 13]; CHAR windir[MAX_PATH]; lstrcpyA(path, CURR_DIR); -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64927 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === debian10 (32 bit French report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === debian10 (32 bit Japanese:Japan report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === debian10 (32 bit Chinese:China report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === debian10 (32 bit WoW report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?) === debian10 (64 bit WoW report) === Report validation errors: advpack:files has no test summary line (early exit of the main process?)
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/fusion/tests/asmenum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/fusion/tests/asmenum.c b/dlls/fusion/tests/asmenum.c index 115089e6741..5892cfde7e9 100644 --- a/dlls/fusion/tests/asmenum.c +++ b/dlls/fusion/tests/asmenum.c @@ -381,7 +381,7 @@ static void test_enumerate_name(void) IAssemblyName *asmname, *next; WCHAR buf[MAX_PATH]; CHAR gac[MAX_PATH]; - CHAR path[MAX_PATH]; + CHAR path[MAX_PATH + 40]; CHAR disp[MAX_PATH]; WCHAR namestr[MAX_PATH]; CHAR exp[6][MAX_PATH]; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64928 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w8adm (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w864 (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1809 (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1809_2scr (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1809_ar (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1809_he (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w2008s64 (64 bit report) === === w864 (64 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1507 (64 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === w1064v1809 (64 bit report) === Report validation errors: fusion:asmenum has no test summary line (early exit of the main process?) === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/kernel32/tests/actctx.c | 14 +++++++------- dlls/kernel32/tests/path.c | 14 +++++++------- dlls/kernel32/tests/process.c | 34 +++++++++++++++++----------------- dlls/kernel32/tests/toolhelp.c | 2 +- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 19bb71816e4..99f3e1c3d25 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -3207,9 +3207,9 @@ static void test_settings(void) typedef struct { char path_tmp[MAX_PATH]; - char path_dll[MAX_PATH]; - char path_manifest_exe[MAX_PATH]; - char path_manifest_dll[MAX_PATH]; + char path_dll[MAX_PATH + 11]; + char path_manifest_exe[MAX_PATH + 12]; + char path_manifest_dll[MAX_PATH + 16]; ACTCTXA context; ULONG_PTR cookie; HANDLE handle_context; @@ -3332,7 +3332,7 @@ cleanup1: static void test_one_sxs_and_one_local_1(void) { sxs_info dll; - char path_dll_local[MAX_PATH]; + char path_dll_local[MAX_PATH + 11]; char path_application[MAX_PATH]; HMODULE module = NULL; char path1[MAX_PATH], path2[MAX_PATH]; @@ -3372,7 +3372,7 @@ cleanup: static void test_one_sxs_and_one_local_2(void) { sxs_info dll; - char path_dll_local[MAX_PATH]; + char path_dll_local[MAX_PATH + 11]; char path_application[MAX_PATH]; HMODULE module = NULL; char path1[MAX_PATH], path2[MAX_PATH]; @@ -3413,7 +3413,7 @@ cleanup: static void test_one_with_sxs_and_GetModuleHandleA(void) { sxs_info dll; - char path_dll_local[MAX_PATH]; + char path_dll_local[MAX_PATH + 11]; char path_tmp[MAX_PATH]; HMODULE module = NULL, module_temp; BOOL success; @@ -3451,7 +3451,7 @@ cleanup: static void test_builtin_sxs(void) { - char path_manifest[MAX_PATH]; + char path_manifest[MAX_PATH + 12]; char path_tmp[MAX_PATH]; HMODULE module_msvcp = 0, module_msvcr = 0; char path_msvcp[MAX_PATH], path_msvcr[MAX_PATH]; diff --git a/dlls/kernel32/tests/path.c b/dlls/kernel32/tests/path.c index 94037d636c2..3d717f7b1f2 100644 --- a/dlls/kernel32/tests/path.c +++ b/dlls/kernel32/tests/path.c @@ -108,10 +108,10 @@ static void test_ValidPathA(const CHAR *curdir, const CHAR *subdir, const CHAR * CHAR *shortstr, SLpassfail *passfail, const CHAR *errstr) { CHAR tmpstr[MAX_PATH], - fullpath[MAX_PATH], /*full path to the file (not short/long) */ + fullpath[MAX_PATH + 1], /*full path to the file (not short/long) */ subpath[MAX_PATH], /*relative path to the file */ - fullpathshort[MAX_PATH], /*absolute path to the file (short format) */ - fullpathlong[MAX_PATH], /*absolute path to the file (long format) */ + fullpathshort[2 * MAX_PATH], /*absolute path to the file (short format) */ + fullpathlong[2 * MAX_PATH], /*absolute path to the file (long format) */ curdirshort[MAX_PATH], /*absolute path to the current dir (short) */ curdirlong[MAX_PATH]; /*absolute path to the current dir (long) */ LPSTR strptr; /*ptr to the filename portion of the path */ @@ -333,7 +333,7 @@ static void test_InitPathA(CHAR *newdir, CHAR *curDrive, CHAR *otherDrive) CHAR tmppath[MAX_PATH], /*path to TEMP */ tmpstr[MAX_PATH], tmpstr1[MAX_PATH], - invalid_dir[MAX_PATH]; + invalid_dir[MAX_PATH + 29]; DWORD len,len1,drives; INT id; @@ -557,7 +557,7 @@ static void test_CurrentDirectoryA(CHAR *origdir, CHAR *newdir) /* Cleanup the mess we made while executing these tests */ static void test_CleanupPathA(CHAR *origdir, CHAR *curdir) { - CHAR tmpstr[MAX_PATH]; + CHAR tmpstr[MAX_PATH + 35]; sprintf(tmpstr,"%s\\%s\\%s",curdir,SHORTDIR,SHORTFILE); ok(DeleteFileA(tmpstr),"DeleteFileA failed\n"); sprintf(tmpstr,"%s\\%s\\%s",curdir,SHORTDIR,LONGFILE); @@ -602,7 +602,7 @@ static void test_PathNameA(CHAR *curdir, CHAR curDrive, CHAR otherDrive) { CHAR curdir_short[MAX_PATH], longdir_short[MAX_PATH]; - CHAR tmpstr[MAX_PATH],tmpstr1[MAX_PATH],tmpstr2[MAX_PATH]; + CHAR tmpstr[MAX_PATH + 15],tmpstr1[MAX_PATH + 22],tmpstr2[2 * MAX_PATH + 15]; LPSTR strptr; /*ptr to the filename portion of the path */ DWORD len; INT i; @@ -1780,7 +1780,7 @@ static void test_SearchPathA(void) static const CHAR testdeprelA[] = "./testdep.dll"; static const CHAR kernel32A[] = "kernel32.dll"; static const CHAR fileA[] = ""; - CHAR pathA[MAX_PATH], buffA[MAX_PATH], path2A[MAX_PATH], path3A[MAX_PATH], curdirA[MAX_PATH]; + CHAR pathA[MAX_PATH + 13], buffA[MAX_PATH], path2A[MAX_PATH], path3A[MAX_PATH + 13], curdirA[MAX_PATH]; CHAR tmpdirA[MAX_PATH], *ptrA = NULL; ULONG_PTR cookie; HANDLE handle; diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 89ad4175c7e..8dceffb59f0 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -598,7 +598,7 @@ static void ok_child_int( int line, const char *sect, const char *key, UINT expe static void test_Startup(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 25]; PROCESS_INFORMATION info; STARTUPINFOA startup,si; char *result; @@ -884,8 +884,8 @@ static void test_Startup(void) static void test_CommandLine(void) { - char buffer[MAX_PATH], fullpath[MAX_PATH], *lpFilePart, *p; - char buffer2[MAX_PATH]; + char buffer[2 * MAX_PATH + 65], fullpath[MAX_PATH], *lpFilePart, *p; + char buffer2[MAX_PATH + 44]; PROCESS_INFORMATION info; STARTUPINFOA startup; BOOL ret; @@ -1093,7 +1093,7 @@ static void test_CommandLine(void) static void test_Directory(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 25]; PROCESS_INFORMATION info; STARTUPINFOA startup; char windir[MAX_PATH]; @@ -1137,7 +1137,7 @@ static void test_Directory(void) static void test_Toolhelp(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 27]; STARTUPINFOA startup; PROCESS_INFORMATION info; HANDLE process, thread, snapshot; @@ -1306,7 +1306,7 @@ static void cmpEnvironment(const char* gesA) static void test_Environment(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 25]; PROCESS_INFORMATION info; STARTUPINFOA startup; char *child_env; @@ -1397,7 +1397,7 @@ static void test_Environment(void) static void test_SuspendFlag(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 25]; PROCESS_INFORMATION info; STARTUPINFOA startup, us; DWORD exit_status; @@ -1445,7 +1445,7 @@ static void test_SuspendFlag(void) static void test_DebuggingFlag(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 25]; void *processbase = NULL; PROCESS_INFORMATION info; STARTUPINFOA startup, us; @@ -1512,7 +1512,7 @@ static BOOL is_console(HANDLE h) static void test_Console(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 35]; PROCESS_INFORMATION info; STARTUPINFOA startup, us; SECURITY_ATTRIBUTES sa; @@ -1700,7 +1700,7 @@ static void test_Console(void) static void test_ExitCode(void) { - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 35]; PROCESS_INFORMATION info; STARTUPINFOA startup; DWORD code; @@ -2415,7 +2415,7 @@ static void _test_completion(int line, HANDLE port, DWORD ekey, ULONG_PTR evalue static void _create_process(int line, const char *command, LPPROCESS_INFORMATION pi) { BOOL ret; - char buffer[MAX_PATH]; + char buffer[MAX_PATH + 19]; STARTUPINFOA si = {0}; sprintf(buffer, "\"%s\" tests/process.c %s", selfname, command); @@ -2830,7 +2830,7 @@ static HANDLE test_AddSelfToJob(void) static void test_jobInheritance(HANDLE job) { - char buffer[MAX_PATH]; + char buffer[MAX_PATH + 23]; PROCESS_INFORMATION pi; STARTUPINFOA si = {0}; DWORD dwret; @@ -2864,7 +2864,7 @@ static void test_BreakawayOk(HANDLE job) JOBOBJECT_EXTENDED_LIMIT_INFORMATION limit_info; PROCESS_INFORMATION pi; STARTUPINFOA si = {0}; - char buffer[MAX_PATH]; + char buffer[MAX_PATH + 23]; BOOL ret, out; DWORD dwret; @@ -2934,7 +2934,7 @@ static void test_BreakawayOk(HANDLE job) static void test_StartupNoConsole(void) { #ifndef _WIN64 - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 25]; STARTUPINFOA startup; PROCESS_INFORMATION info; @@ -2962,7 +2962,7 @@ static void test_StartupNoConsole(void) static void test_DetachConsoleHandles(void) { #ifndef _WIN64 - char buffer[MAX_PATH]; + char buffer[2 * MAX_PATH + 25]; STARTUPINFOA startup; PROCESS_INFORMATION info; UINT result; @@ -3385,7 +3385,7 @@ static void test_SuspendProcessState(void) static void test_DetachStdHandles(void) { #ifndef _WIN64 - char buffer[MAX_PATH], tempfile[MAX_PATH]; + char buffer[2 * MAX_PATH + 25], tempfile[MAX_PATH]; STARTUPINFOA startup; PROCESS_INFORMATION info; HANDLE hstdin, hstdout, hstderr, htemp; @@ -4034,7 +4034,7 @@ START_TEST(process) } else if (!strcmp(myARGV[2], "nested") && myARGC >= 4) { - char buffer[MAX_PATH]; + char buffer[MAX_PATH + 26]; STARTUPINFOA startup; PROCESS_INFORMATION info; diff --git a/dlls/kernel32/tests/toolhelp.c b/dlls/kernel32/tests/toolhelp.c index bdb01b9824d..eb9a6759914 100644 --- a/dlls/kernel32/tests/toolhelp.c +++ b/dlls/kernel32/tests/toolhelp.c @@ -284,7 +284,7 @@ START_TEST(toolhelp) DWORD pid = GetCurrentProcessId(); int r; char *p, module[MAX_PATH]; - char buffer[MAX_PATH]; + char buffer[MAX_PATH + 21]; SECURITY_ATTRIBUTES sa; PROCESS_INFORMATION info; STARTUPINFOA startup; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64929 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: kernel32:actctx has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: kernel32:actctx has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: kernel32:actctx has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: kernel32:path has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: kernel32:path has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: kernel32:path has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: kernel32:process has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: kernel32:process has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: kernel32:process has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: kernel32:toolhelp has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: kernel32:toolhelp has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: kernel32:toolhelp has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/mscoree/tests/comtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mscoree/tests/comtest.c b/dlls/mscoree/tests/comtest.c index 4879e3b7622..69e24494e6d 100644 --- a/dlls/mscoree/tests/comtest.c +++ b/dlls/mscoree/tests/comtest.c @@ -71,7 +71,7 @@ static BOOL write_resource_file(const char *path_tmp, const char *name_res, cons static BOOL compile_cs_to_dll(char *source_path, char *dest_path) { const char *path_csc = "C:\\windows\\Microsoft.NET\\Framework\\v2.0.50727\\csc.exe"; - char cmdline[MAX_PATH]; + char cmdline[2 * MAX_PATH + 74]; char path_temp[MAX_PATH]; PROCESS_INFORMATION pi; STARTUPINFOA si = { 0 }; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64930 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: mscoree:comtest has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: mscoree:comtest has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: mscoree:comtest has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com>
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/msi/tests/action.c | 2 +- dlls/msi/tests/install.c | 6 +++--- dlls/msi/tests/msi.c | 2 +- dlls/msi/tests/package.c | 20 ++++++++++---------- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c index 89706249e45..48866e36f44 100644 --- a/dlls/msi/tests/action.c +++ b/dlls/msi/tests/action.c @@ -4623,7 +4623,7 @@ error: static void test_move_files(void) { UINT r; - char props[MAX_PATH]; + char props[4 * MAX_PATH + 74]; if (is_process_limited()) { diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index f7fd83cfc08..99d53e56570 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -3816,7 +3816,7 @@ error: static void test_currentworkingdir(void) { UINT r; - CHAR drive[MAX_PATH], path[MAX_PATH]; + CHAR drive[MAX_PATH], path[MAX_PATH + 12]; LPSTR ptr; if (is_process_limited()) @@ -4778,7 +4778,7 @@ error: static void test_sourcedirprop(void) { UINT r; - CHAR props[MAX_PATH]; + CHAR props[MAX_PATH + 18]; if (is_process_limited()) { @@ -6112,7 +6112,7 @@ static void check_file_matches(const char *filename, const char *text) static void test_deferred_action(void) { - char path[200], file[200], buffer[200]; + char path[200], file[200], buffer[211]; UINT r; GetTempPathA(sizeof(path), path); diff --git a/dlls/msi/tests/msi.c b/dlls/msi/tests/msi.c index 39a6638118c..eb547c98dce 100644 --- a/dlls/msi/tests/msi.c +++ b/dlls/msi/tests/msi.c @@ -827,7 +827,7 @@ static UINT set_summary_info(MSIHANDLE hdb, LPSTR prodcode) static MSIHANDLE create_package_db(LPSTR prodcode) { MSIHANDLE hdb = 0; - CHAR query[MAX_PATH]; + CHAR query[MAX_PATH + 72]; UINT res; DeleteFileA(msifile); diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 3b7b11d81e4..bf83c116fff 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -269,7 +269,7 @@ static void set_component_path(LPCSTR filename, MSIINSTALLCONTEXT context, WCHAR guidW[MAX_PATH]; WCHAR squashedW[MAX_PATH]; CHAR squashed[MAX_PATH]; - CHAR comppath[MAX_PATH]; + CHAR comppath[MAX_PATH + 81]; CHAR prodpath[MAX_PATH]; CHAR path[MAX_PATH]; LPCSTR prod = NULL; @@ -335,7 +335,7 @@ static void delete_component_path(LPCSTR guid, MSIINSTALLCONTEXT context, LPSTR WCHAR squashedW[MAX_PATH]; WCHAR substrW[MAX_PATH]; CHAR squashed[MAX_PATH]; - CHAR comppath[MAX_PATH]; + CHAR comppath[MAX_PATH + 81]; CHAR prodpath[MAX_PATH]; REGSAM access = KEY_ALL_ACCESS; @@ -1223,7 +1223,7 @@ static void query_file_path(MSIHANDLE hpkg, LPCSTR file, LPSTR buff) static void test_settargetpath(void) { - char tempdir[MAX_PATH+8], buffer[MAX_PATH], file[MAX_PATH]; + char tempdir[MAX_PATH+8], buffer[MAX_PATH], file[MAX_PATH + 20]; DWORD sz; MSIHANDLE hpkg; UINT r; @@ -2759,9 +2759,9 @@ static void test_formatrecord2(void) static void test_formatrecord_tables(void) { MSIHANDLE hdb, hrec, hpkg = 0; - CHAR buf[MAX_PATH]; + CHAR buf[MAX_PATH + 41]; CHAR curr_dir[MAX_PATH]; - CHAR expected[MAX_PATH]; + CHAR expected[MAX_PATH + 45]; CHAR root[MAX_PATH]; DWORD size; UINT r; @@ -4142,7 +4142,7 @@ done: static void test_appsearch_complocator(void) { MSIHANDLE hpkg, hdb; - char path[MAX_PATH], expected[MAX_PATH], prop[MAX_PATH]; + char path[MAX_PATH + 15], expected[MAX_PATH], prop[MAX_PATH]; LPSTR usersid; DWORD size; UINT r; @@ -4391,7 +4391,7 @@ error: static void test_appsearch_reglocator(void) { MSIHANDLE hpkg, hdb; - char path[MAX_PATH], expected[MAX_PATH], prop[MAX_PATH]; + char path[MAX_PATH + 20], expected[MAX_PATH], prop[MAX_PATH]; DWORD binary[2], size, val; BOOL space, version, is_64bit = sizeof(void *) > sizeof(int); HKEY hklm, classes, hkcu, users; @@ -4973,7 +4973,7 @@ static void delete_win_ini(LPCSTR file) static void test_appsearch_inilocator(void) { MSIHANDLE hpkg, hdb; - char path[MAX_PATH], expected[MAX_PATH], prop[MAX_PATH]; + char path[MAX_PATH + 14], expected[MAX_PATH], prop[MAX_PATH]; BOOL version; LPSTR ptr; DWORD size; @@ -5210,7 +5210,7 @@ static void search_absolute_directory(LPSTR absolute, LPCSTR relative) static void test_appsearch_drlocator(void) { MSIHANDLE hpkg, hdb; - char path[MAX_PATH], expected[MAX_PATH], prop[MAX_PATH]; + char path[MAX_PATH + 27], expected[MAX_PATH], prop[MAX_PATH]; BOOL version; DWORD size; UINT r; @@ -7968,7 +7968,7 @@ static void test_MsiGetProductProperty(void) MSIHANDLE hprod, hdb; CHAR val[MAX_PATH]; CHAR path[MAX_PATH]; - CHAR query[MAX_PATH]; + CHAR query[MAX_PATH + 17]; CHAR keypath[MAX_PATH*2]; CHAR prodcode[MAX_PATH]; WCHAR prodcodeW[MAX_PATH]; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64935 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: msi:action has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_ja (32 bit report) === msi: action: Timeout === w1064v1809_zh_CN (32 bit report) === msi: action: Timeout === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: msi:install has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ja (32 bit report) === msi: install: Timeout === w1064v1809_zh_CN (32 bit report) === msi: install: Timeout === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: msi:msi has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: msi:msi has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: msi:msi has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: msi:package has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_ja (32 bit report) === Report validation errors: msi:package has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Hans Leidekker <hans(a)codeweavers.com>
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/setupapi/tests/devinst.c | 2 +- dlls/setupapi/tests/install.c | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/dlls/setupapi/tests/devinst.c b/dlls/setupapi/tests/devinst.c index dcfe5cd231e..a9ac0d849f6 100644 --- a/dlls/setupapi/tests/devinst.c +++ b/dlls/setupapi/tests/devinst.c @@ -2315,7 +2315,7 @@ static void test_get_actual_section(void) static void test_driver_list(void) { - char inf_dir[MAX_PATH], inf_path[MAX_PATH], inf_path2[MAX_PATH]; + char inf_dir[MAX_PATH], inf_path[MAX_PATH + 10], inf_path2[MAX_PATH + 10]; static const char hardware_id[] = "bogus_hardware_id\0"; static const char compat_id[] = "bogus_compat_id\0"; SP_DEVINSTALL_PARAMS_A params = {sizeof(params)}; diff --git a/dlls/setupapi/tests/install.c b/dlls/setupapi/tests/install.c index fd10fd91332..36f29a72548 100644 --- a/dlls/setupapi/tests/install.c +++ b/dlls/setupapi/tests/install.c @@ -330,7 +330,7 @@ static void ok_registry(BOOL expectsuccess) static void test_cmdline(void) { static const char infwithspaces[] = "test file.inf"; - char path[MAX_PATH]; + char path[MAX_PATH + 16]; BOOL ret; create_inf_file(inffile, cmdline_inf); @@ -366,7 +366,7 @@ static void test_registry(void) { HKEY key; LONG res; - char path[MAX_PATH]; + char path[MAX_PATH + 9]; BOOL ret; /* First create a registry structure we would like to be deleted */ @@ -396,7 +396,7 @@ static void test_registry(void) static void test_install_from(void) { - char path[MAX_PATH]; + char path[MAX_PATH + 9]; HINF infhandle; HKEY key; LONG res; @@ -436,7 +436,7 @@ static void test_install_from(void) static void test_install_svc_from(void) { char inf[2048]; - char path[MAX_PATH]; + char path[MAX_PATH + 9]; HINF infhandle; BOOL ret; SC_HANDLE scm_handle, svc_handle; @@ -596,7 +596,7 @@ static void test_driver_install(void) HANDLE handle; SC_HANDLE scm_handle, svc_handle; BOOL ret; - char path[MAX_PATH], windir[MAX_PATH], driver[MAX_PATH]; + char path[MAX_PATH + 9], windir[MAX_PATH], driver[MAX_PATH]; DWORD attrs; /* Minimal stuff needed */ static const char *inf = @@ -665,7 +665,7 @@ static void test_driver_install(void) static void test_profile_items(void) { - char path[MAX_PATH], commonprogs[MAX_PATH]; + char path[MAX_PATH + 22], commonprogs[MAX_PATH]; static const char *inf = "[Version]\n" @@ -947,7 +947,7 @@ static const char dirid_inf[] = "[Version]\n" static void check_dirid(int dirid, LPCSTR expected) { char buffer[sizeof(dirid_inf)+11]; - char path[MAX_PATH], actual[MAX_PATH]; + char path[MAX_PATH + 9], actual[MAX_PATH]; LONG ret; DWORD size, type; HKEY key; @@ -1027,7 +1027,7 @@ static void test_install_files_queue(void) "[DestinationDirs]\n" "files_section=40000,dst\n"; - char path[MAX_PATH]; + char path[MAX_PATH + 9]; HSPFILEQ queue; void *context; HINF hinf; @@ -1349,7 +1349,7 @@ static void test_install_file(void) "[DestinationDirs]\n" "DefaultDestDir=40000,dst\n"; - char path[MAX_PATH]; + char path[MAX_PATH + 9]; INFCONTEXT infctx; HINF hinf; BOOL ret; @@ -1448,7 +1448,7 @@ static void test_need_media(void) "DefaultDestDir=40000,dst\n"; SP_FILE_COPY_PARAMS_A copy_params = {sizeof(copy_params)}; - char path[MAX_PATH]; + char path[MAX_PATH + 9]; HSPFILEQ queue; HINF hinf; BOOL ret; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64936 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === Report validation errors: setupapi:devinst has no test summary line (early exit of the main process?) === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: setupapi:devinst has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: setupapi:devinst has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: setupapi:devinst has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === Report validation errors: setupapi:install has no test summary line (early exit of the main process?) === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: setupapi:install has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: setupapi:install has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: setupapi:install has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/shell32/tests/shlexec.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/shell32/tests/shlexec.c b/dlls/shell32/tests/shlexec.c index 12ef18c1d89..030ab54525a 100644 --- a/dlls/shell32/tests/shlexec.c +++ b/dlls/shell32/tests/shlexec.c @@ -1096,7 +1096,7 @@ static filename_tests_t noquotes_tests[]= static void test_lpFile_parsed(void) { - char fileA[MAX_PATH]; + char fileA[MAX_PATH + 38]; INT_PTR rc; if (skip_shlexec_tests) @@ -1549,7 +1549,7 @@ static const argify_tests_t argify_tests[] = static void test_argify(void) { - char fileA[MAX_PATH], params[2*MAX_PATH+12]; + char fileA[MAX_PATH + 18], params[2 * MAX_PATH + 28]; INT_PTR rc; const argify_tests_t* test; const char *bad; @@ -1607,7 +1607,7 @@ static void test_argify(void) static void test_filename(void) { - char filename[MAX_PATH]; + char filename[MAX_PATH + 20]; const filename_tests_t* test; char* c; INT_PTR rc; @@ -1647,7 +1647,7 @@ static void test_filename(void) } else { - char quoted[MAX_PATH + 2]; + char quoted[MAX_PATH + 22]; quotedfile = TRUE; sprintf(quoted, "\"%s\"", filename); @@ -1873,7 +1873,7 @@ static void test_fileurls(void) static void test_urls(void) { - char url[MAX_PATH]; + char url[MAX_PATH + 15]; INT_PTR rc; if (!create_test_class("fakeproto", FALSE)) @@ -1968,7 +1968,7 @@ static void test_urls(void) static void test_find_executable(void) { char notepad_path[MAX_PATH]; - char filename[MAX_PATH]; + char filename[MAX_PATH + 17]; char command[MAX_PATH]; const filename_tests_t* test; INT_PTR rc; @@ -2114,8 +2114,8 @@ static filename_tests_t lnk_tests[]= static void test_lnks(void) { - char filename[MAX_PATH]; - char params[MAX_PATH]; + char filename[MAX_PATH + 26]; + char params[MAX_PATH + 18]; const filename_tests_t* test; INT_PTR rc; @@ -2208,7 +2208,7 @@ static void test_lnks(void) static void test_exes(void) { - char filename[MAX_PATH]; + char filename[2 * MAX_PATH + 17]; char params[1024]; INT_PTR rc; @@ -2386,7 +2386,7 @@ static void hook_WaitForInputIdle(DWORD (WINAPI *new_func)(HANDLE, DWORD)) static void test_dde(void) { - char filename[MAX_PATH], defApplication[MAX_PATH]; + char filename[MAX_PATH + 14], defApplication[MAX_PATH]; const dde_tests_t* test; char params[1024]; INT_PTR rc; @@ -2553,7 +2553,7 @@ static DWORD CALLBACK ddeThread(LPVOID arg) static void test_dde_default_app(void) { - char filename[MAX_PATH]; + char filename[MAX_PATH + 14]; HSZ hszApplication; dde_thread_info_t info = { filename, GetCurrentThreadId() }; const dde_default_app_tests_t* test; @@ -2655,7 +2655,7 @@ static void init_test(void) { HMODULE hdll; HRESULT (WINAPI *pDllGetVersion)(DLLVERSIONINFO*); - char filename[MAX_PATH]; + char filename[MAX_PATH + 26]; WCHAR lnkfile[MAX_PATH]; char params[1024]; const char* const * testfile; @@ -2812,7 +2812,7 @@ static void cleanup_test(void) static void test_directory(void) { - char path[MAX_PATH], curdir[MAX_PATH]; + char path[MAX_PATH + 10], curdir[MAX_PATH]; char params[1024], dirpath[1024]; INT_PTR rc; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64937 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === Report validation errors: shell32:shlexec has no test summary line (early exit of the main process?) === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: shell32:shlexec has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === shell32: shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x2008540", file="C:\Users\winetest\AppData\Local\Temp\wtB872.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtB872.tmp\test file.sde")]', got '' Report validation errors: shell32:shlexec has unaccounted for failure messages === w1064v1809 (32 bit report) === shell32: shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ddeExec expected '[open(C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde)]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtF02C.tmp\test file.sde")]', got '' === w1064v1809_2scr (32 bit report) === shell32: shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ddeExec expected '[open(C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde)]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt431.tmp\test file.sde")]', got '' === w1064v1809_ar (32 bit report) === shell32: shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ddeExec expected '[open(C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde)]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt2565.tmp\test file.sde")]', got '' === w1064v1809_he (32 bit report) === shell32: shlexec.c:1646: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt173C.tmp\test file.shlexec") WaitForSingleObject returned 258 shlexec.c:1646: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt173C.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1658: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt173C.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1668: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt173C.tmp\test file.noassoc") argvA3 expected 'Open', but key not found or empty shlexec.c:1670: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt173C.tmp\test file.noassoc") argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt173C.tmp\test file.noassoc', but key not found or empty shlexec.c:1894: Test failed: ShellExecute(verb="", file="fakeproto://foo/bar") WaitForSingleObject returned 258 shlexec.c:1894: Test failed: ShellExecute(file="fakeproto://foo/bar") Got different return value with empty string: 31 42 shlexec: Timeout === w1064v1809_ja (32 bit report) === shell32: shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde")]', got '' shlexec.c:2435: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" WaitForSingleObject(hProcess) returned 258 shlexec.c:2435: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" child returned 259 shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ddeExec expected '[open(C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde)]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1538.tmp\test file.sde")]', got '' Report validation errors: shell32:shlexec has no test summary line (early exit of the main process?) shell32:shlexec has unaccounted for failure messages === w1064v1809_zh_CN (32 bit report) === shell32: shlexec.c:1115: Test failed: ShellExecute(file=""C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\drawback_file.noassoc foo.shlexec"") WaitForSingleObject returned 258 shlexec.c:1140: Test failed: ShellExecute(verb="", file=""%TMPDIR%\simple.shlexec"") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ddeExec expected '[open(C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde)]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wt1B53.tmp\test file.sde")]', got '' === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === shell32: shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ddeExec expected '[open(C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde)]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde")]', got '' shlexec.c:2471: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ddeExec expected '[open("C:\Users\winetest\AppData\Local\Temp\wtEF70.tmp\test file.sde")]', got '' === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/user32/tests/cursoricon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c index 6687ebc4a89..7a5f9551615 100644 --- a/dlls/user32/tests/cursoricon.c +++ b/dlls/user32/tests/cursoricon.c @@ -1287,7 +1287,7 @@ static void test_LoadImage_working_directory(void) char executable_path[MAX_PATH]; int pos_slash; char old_PATH[10000]; - char new_PATH[10000]; + char new_PATH[10000 + MAX_PATH]; BOOL ret; GetCurrentDirectoryA(ARRAY_SIZE(old_working_dir), old_working_dir); -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64938 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === Report validation errors: user32:cursoricon has no test summary line (early exit of the main process?) === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: user32:cursoricon has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has unaccounted for failure messages === w1064v1809 (32 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has unaccounted for failure messages === w1064v1809_2scr (32 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has unaccounted for failure messages === w1064v1809_ar (32 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has unaccounted for failure messages === w1064v1809_he (32 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has no test summary line (early exit of the main process?) user32:cursoricon has unaccounted for failure messages === w1064v1809_ja (32 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has no test summary line (early exit of the main process?) user32:cursoricon has unaccounted for failure messages === w1064v1809_zh_CN (32 bit report) === user32: cursoricon.c:2366: Test failed: wrong info cursor 000203D3/00010003 cursoricon.c:2509: Test failed: cursor not shown in info === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has unaccounted for failure messages === w1064v1809 (64 bit report) === user32: cursoricon.c:2420: Test failed: cursor not shown in info cursoricon.c:2444: Test failed: cursor not shown in info cursoricon.c:2497: Test failed: cursor not shown in info cursoricon.c:2509: Test failed: cursor not shown in info Report validation errors: user32:cursoricon has unaccounted for failure messages === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/version/tests/install.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/version/tests/install.c b/dlls/version/tests/install.c index b06125ff503..d0e37e28094 100644 --- a/dlls/version/tests/install.c +++ b/dlls/version/tests/install.c @@ -31,7 +31,7 @@ static void test_find_file(void) DWORD ret; UINT dwCur, dwOut ; char tmp[MAX_PATH]; - char appdir[MAX_PATH]; + char appdir[MAX_PATH + 12]; char curdir[MAX_PATH]; char filename[MAX_PATH]; char outBuf[MAX_PATH]; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64939 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === Report validation errors: version:install has no test summary line (early exit of the main process?) === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: version:install has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: version:install has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: version:install has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- programs/services/tests/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/services/tests/service.c b/programs/services/tests/service.c index dcaf5f0b589..aa9878b9769 100644 --- a/programs/services/tests/service.c +++ b/programs/services/tests/service.c @@ -29,7 +29,7 @@ static SERVICE_STATUS_HANDLE (WINAPI *pRegisterServiceCtrlHandlerExA)(LPCSTR,LPHANDLER_FUNCTION_EX,LPVOID); static HANDLE pipe_handle = INVALID_HANDLE_VALUE; -static char service_name[100], named_pipe_name[100]; +static char service_name[100], named_pipe_name[114]; static SERVICE_STATUS_HANDLE service_handle; /* Service process global variables */ -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64940 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w1064v1809 (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w1064v1809_2scr (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w1064v1809_ar (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w1064v1809_he (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === Report validation errors: services.exe:service has no test summary line (early exit of the main process?) === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/msvcrt/tests/data.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/tests/data.c b/dlls/msvcrt/tests/data.c index b0acc60b20b..b664edbab18 100644 --- a/dlls/msvcrt/tests/data.c +++ b/dlls/msvcrt/tests/data.c @@ -133,7 +133,7 @@ static void test___getmainargs(void) { int argc, new_argc, mode; char **argv, **new_argv, **envp; - char tmppath[MAX_PATH], filepath[MAX_PATH]; + char tmppath[MAX_PATH], filepath[MAX_PATH + 14]; FILE *f; ok(GetTempPathA(MAX_PATH, tmppath) != 0, "GetTempPath failed\n"); @@ -194,7 +194,7 @@ static void test___getmainargs(void) static void test___getmainargs_parent(char *name) { char cmdline[3*MAX_PATH]; - char tmppath[MAX_PATH], filepath[MAX_PATH]; + char tmppath[MAX_PATH], filepath[MAX_PATH + 14]; STARTUPINFOA startup; PROCESS_INFORMATION proc; FILE *f; -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64941 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: msvcrt:data has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: msvcrt:data has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: msvcrt:data has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Piotr Caban <piotr(a)codeweavers.com>
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/ntdll/tests/directory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/tests/directory.c b/dlls/ntdll/tests/directory.c index 1109f7f3a4f..4618f4eaff2 100644 --- a/dlls/ntdll/tests/directory.c +++ b/dlls/ntdll/tests/directory.c @@ -737,7 +737,7 @@ done: static void set_up_case_test(const char *testdir) { BOOL ret; - char buf[MAX_PATH]; + char buf[MAX_PATH + 5]; HANDLE h; ret = CreateDirectoryA(testdir, NULL); -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64942 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: ntdll:directory has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: ntdll:directory has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === Report validation errors: ntdll:directory has no test summary line (early exit of the main process?) === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === === debian10 (32 bit French report) === === debian10 (32 bit Japanese:Japan report) === === debian10 (32 bit Chinese:China report) === === debian10 (32 bit WoW report) === === debian10 (64 bit WoW report) ===
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index e06743c2ea3..cb1bd27a8d2 100644 --- a/configure.ac +++ b/configure.ac @@ -1063,7 +1063,9 @@ then case $host_cpu in *i[[3456789]]86*) WINE_TRY_CROSSCFLAGS([-fno-omit-frame-pointer]) ;; - x86_64) WINE_TRY_CROSSCFLAGS([-Wno-format]) ;; + x86_64) WINE_TRY_CROSSCFLAGS([-Wno-format]) + WINE_TRY_CROSSCFLAGS([-Wformat-overflow]) + WINE_TRY_CROSSCFLAGS([-Wnonnull]) ;; esac dnl Default to dwarf-2 debug info -- 2.25.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64926 Your paranoid android. === wxppro (32 bit report) === === w2008s64 (32 bit report) === === w8 (32 bit report) === advapi32: service.c:1278: Test failed: Expected needed buffersize to be the same for A- and W-calls Report validation errors: advapi32:service has unaccounted for failure messages === w8adm (32 bit report) === === w864 (32 bit report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?) === w1064v1507 (32 bit report) === === w1064v1809 (32 bit report) === === w1064v1809_2scr (32 bit report) === === w1064v1809_ar (32 bit report) === === w1064v1809_he (32 bit report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?) === w1064v1809_ja (32 bit report) === advapi32: service.c:1740: Test failed: Expected a process id for this running service (sppsvc) Report validation errors: advapi32:service has no test summary line (early exit of the main process?) advapi32:service has unaccounted for failure messages === w1064v1809_zh_CN (32 bit report) === === w2008s64 (64 bit report) === === w864 (64 bit report) === === w1064v1507 (64 bit report) === === w1064v1809 (64 bit report) === === debian10 (32 bit report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?) === debian10 (32 bit French report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?) === debian10 (32 bit Japanese:Japan report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?) === debian10 (32 bit Chinese:China report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?) === debian10 (32 bit WoW report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?) === debian10 (64 bit WoW report) === Report validation errors: advapi32:service has no test summary line (early exit of the main process?)
participants (5)
-
Hans Leidekker -
Marvin -
Piotr Caban -
Rémi Bernon -
Vincent Povirk (they/them)