Re: [PATCH 1/2] Add definitions used by reparse points

[Paul TBBle Hampson]

On Wed, Jan 07, 2009 at 07:24:07PM +1100, Paul TBBle Hampson wrote:
> Resend, removing C++-style comments
> -- 
> Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com
> Shorter .sig for a more eco-friendly paperless office.

Any comments on this patch series? The only thing I've had for this
resend of the two patches is that it's kinda long.

I'm thinking if I need to split the second patch up further, I'd break
it up into a patch that creates the test without doing any actual
reparse point work (ie create directory, create files, count files,
delete files, count files, clean up) and then one that does the
junction point creation and tests that it matches the directory being
linked to...

I'm not sure that's a particularly useful change, but I can do it.
Otherwise, is there anything else I'm dong wrong?

-- 
-----------------------------------------------------------
Paul "TBBle" Hampson, B.Sc, LPI, MCSE
Very-later-year Asian Studies student, ANU
The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)
Paul.Hampson(a)Pobox.com

Of course Pacman didn't influence us as kids. If it did,
we'd be running around in darkened rooms, popping pills and
listening to repetitive music.
 -- Kristian Wilson, Nintendo, Inc, 1989

License: http://creativecommons.org/licenses/by/2.5/au/
-----------------------------------------------------------