Re: [PATCH 2/8] urlmon/tests: CoInternetCreateZoneManager not present on W95B

[Paul Vriens]

On 04/16/2010 12:20 AM, Detlef Riekenberg wrote:
> ---
>   dlls/urlmon/tests/sec_mgr.c |   29 +++++++++++++++++++++--------
>   1 files changed, 21 insertions(+), 8 deletions(-)

Hi Detlef,

After this patch none of the tests are actually run on W95B and we have 
loads of win_skip's.

Wouldn't it be better to just check for one (or all) and bail out with a 
(only one) win_skip()? I guess if one is not present, none are?

-- 
Cheers,

Paul.

[PATCH 2/8] urlmon/tests: CoInternetCreateZoneManager not present on W95B

[Detlef Riekenberg]

On Fr, 2010-04-16 at 08:57 +0200, Paul Vriens wrote:
> Wouldn't it be better to just check for one (or all) and bail out with
> a (only one) win_skip()? I guess if one is not present, none are?

The checks are in different test files and some tests work on W95B
(IE 4)

I prefer to have a complete winetest run for urlmon on various machines
(from winetestbot, francois and other), before we shrink the skips.

Thanks for the idea

-- 
By by ... Detlef

[PATCH 2/8] urlmon/tests: CoInternetCreateZoneManager not present on W95B

[Paul Vriens]

On 04/19/2010 01:23 AM, Detlef Riekenberg wrote:
> On Fr, 2010-04-16 at 08:57 +0200, Paul Vriens wrote:
> > Wouldn't it be better to just check for one (or all) and bail out with
> > a (only one) win_skip()? I guess if one is not present, none are?
>
> The checks are in different test files and some tests work on W95B
> (IE 4)
>
> I prefer to have a complete winetest run for urlmon on various machines
> (from winetestbot, francois and other), before we shrink the skips.

Ok, no problem. Let's wait a few rounds.

-- 
Cheers,

Paul.