Re: [PATCH 1/5] d3dx9/tests: Remove todo that succeeds now.

[Nikolay Sivov]

On 25.07.2015 12:23, Józef Kucia wrote:
> ---
>   dlls/d3dx9_36/tests/effect.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c
> index 482f064..dd88b29 100644
> --- a/dlls/d3dx9_36/tests/effect.c
> +++ b/dlls/d3dx9_36/tests/effect.c
> @@ -156,7 +156,7 @@ static void test_create_effect_and_pool(IDirect3DDevice9 *device)
>       ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK)\n", hr);
>
> hr = D3DXCreateEffect(device, effect_desc, sizeof(effect_desc), NULL, NULL, 0, NULL, &effect, NULL);
> -    todo_wine ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK)\n", hr);
> +    ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK)\n", hr);
>       if (FAILED(hr))
>       {
>           skip("Failed to compile effect, skipping test.\n");

Hi, Jozef.

There's no failures currently 
http://test.winehq.org/data/tests/d3dx9_36:mesh.html, so I'm not sure 
why it succeeds for you.

[PATCH 1/5] d3dx9/tests: Remove todo that succeeds now.

[Józef Kucia]

On Sun, Jul 26, 2015 at 3:56 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
> Hi, Jozef.
>
> There's no failures currently
> http://test.winehq.org/data/tests/d3dx9_36:mesh.html, so I'm not sure why it
> succeeds for you.

Hi Nikolay,

My bad. Thanks for finding this. I wasn't using a clean wine prefix.

The first patch from the series should be skipped.