Re: PR 16828 dlls/ntdll/serial.c clear IEXTEN when clearing ICANON

[Austin English]

On Tue, Jan 6, 2009 at 12:49 PM, G. Paul Ziemba <p-wine-bugs(a)ziemba.us> wrote:
> FreeBSD fix for Nirvis CDJ application, PR 16828
>
> --- dlls/ntdll/serial.c.orig    2008-12-20 06:55:38.000000000 -0800
> +++ dlls/ntdll/serial.c 2009-01-05 21:35:47.000000000 -0800
> @@ -648,7 +648,9 @@
>     port.c_cflag &= ~(HUPCL);
>     port.c_cflag |= CLOCAL | CREAD;
>
> -    port.c_lflag &= ~(ICANON|ECHO|ISIG);
> +    // on FreeBSD, turning off ICANON does not disable IEXTEN,
> +    // so we must turn it off explicitly. No harm done on Linux.
> +    port.c_lflag &= ~(ICANON|ECHO|ISIG|IEXTEN);
>     port.c_lflag |= NOFLSH;
>
> bytesize = slc->WordLength;
>
> --
> G. Paul Ziemba
> FreeBSD unix:
> 10:46AM  up 12 days, 21:25, 10 users, load averages: 0.21, 0.29, 0.23

Again, no C++ comments.

-- 
-Austin

PR 16828 dlls/ntdll/serial.c clear IEXTEN when clearing ICANON

[G. Paul Ziemba]

austinenglish(a)gmail.com ("Austin English") writes:
> Again, no C++ comments.

Oops. Self-LART applied. Should I resubmit patches with modified comments
to wine-patches?

 ~!paul
-- 
G. Paul Ziemba
FreeBSD unix:
11:06AM  up 12 days, 21:45, 11 users, load averages: 0.27, 0.23, 0.24

PR 16828 dlls/ntdll/serial.c clear IEXTEN when clearing ICANON

[Austin English]

On Tue, Jan 6, 2009 at 1:08 PM, G. Paul Ziemba <pz-wine-devel(a)ziemba.us> wrote:
> austinenglish(a)gmail.com ("Austin English") writes:
> > Again, no C++ comments.
>
> Oops. Self-LART applied. Should I resubmit patches with modified comments
> to wine-patches?
>
> ~!paul
> --
> G. Paul Ziemba
> FreeBSD unix:
> 11:06AM  up 12 days, 21:45, 11 users, load averages: 0.27, 0.23, 0.24

Please.

Thanks for helping Wine!

-- 
-Austin