Re: [PATCH] netapi32/test: Add trace to help narrow down failing test.

[Nikolay Sivov]

On 08.11.2016 13:07, Alistair Leslie-Hughes wrote:
> Based off a test run with extra traces
> https://testbot.winehq.org/JobDetails.pl?Key=26512&log_201=1#k201
> the intermittently failing test is in test_DavGetUNCFromHTTPPath.
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/netapi32/tests/access.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/dlls/netapi32/tests/access.c b/dlls/netapi32/tests/access.c
> index f095d77..0fab0de 100644
> --- a/dlls/netapi32/tests/access.c
> +++ b/dlls/netapi32/tests/access.c
> @@ -688,6 +688,7 @@ static void test_DavGetUNCFromHTTPPath(void)
>      for (i = 0; i < sizeof(tests)/sizeof(tests[0]); i++)
>      {
>          buf[0] = 0;
> +        trace("test: %d\n", i);
>          size = tests[i].size;
>          ret = pDavGetUNCFromHTTPPath( tests[i].path, buf, &size );
>          ok( ret == tests[i].ret, "%u: expected %u got %u\n", i, tests[i].ret, ret );

ok() lines already print failed test index, and in case of a crash
manual test as you is enough.