[PATCH] user32/tests: Don't mark the SW_SHOWMINIMIZED overlapped test as todo.

[Zebediah Figura]

This is window manager-dependent, but it succeeds on fvwm2 which the testbot
machines use.

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com>
---
 dlls/user32/tests/msg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 64c7967..a816919 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -5087,7 +5087,7 @@ static void test_messages(void)
 
     ShowWindow(hwnd, SW_MINIMIZE);
     flush_events();
-    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
+    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
     flush_sequence();
 
     if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)
-- 
2.7.4

[Alexandre Julliard]

Zebediah Figura <z.figura12(a)gmail.com> writes:
> This is window manager-dependent, but it succeeds on fvwm2 which the testbot
> machines use.

It fails here, which is why it's marked todo:

../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so msg && touch msg.ok
msg.c:5090: Test failed: ShowWindow(SW_SHOWMINIMIZED):overlapped: 52: the msg sequence is not complete: expected 0000 - actual 001f
msg.c:13507: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1'
msg.c:13823: Tests skipped: Unable to load Greek keyboard layout
Makefile:498: recipe for target 'msg.ok' failed

-- 
Alexandre Julliard
julliard(a)winehq.org

[Zebediah Figura]

On 11/27/2017 03:57 AM, Alexandre Julliard wrote:
> Zebediah Figura <z.figura12(a)gmail.com> writes:
> > This is window manager-dependent, but it succeeds on fvwm2 which the testbot
> > machines use.
>
> It fails here, which is why it's marked todo:
>
> ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so msg && touch msg.ok
> msg.c:5090: Test failed: ShowWindow(SW_SHOWMINIMIZED):overlapped: 52: the msg sequence is not complete: expected 0000 - actual 001f
> msg.c:13507: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1'
> msg.c:13823: Tests skipped: Unable to load Greek keyboard layout
> Makefile:498: recipe for target 'msg.ok' failed

Is that on fvwm2? My reasoning was, since it's WM-dependent, it doesn't 
really matter which WMs we cause test failures on, so we might as well 
ensure that the testbot works.

[Alexandre Julliard]

Zebediah Figura <z.figura12(a)gmail.com> writes:
> On 11/27/2017 03:57 AM, Alexandre Julliard wrote:
> > Zebediah Figura <z.figura12(a)gmail.com> writes:
> > > This is window manager-dependent, but it succeeds on fvwm2 which the testbot
> > > machines use.
> >
> > It fails here, which is why it's marked todo:
> >
> > ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so msg && touch msg.ok
> > msg.c:5090: Test failed: ShowWindow(SW_SHOWMINIMIZED):overlapped: 52: the msg sequence is not complete: expected 0000 - actual 001f
> > msg.c:13507: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1'
> > msg.c:13823: Tests skipped: Unable to load Greek keyboard layout
> > Makefile:498: recipe for target 'msg.ok' failed
>
> Is that on fvwm2? My reasoning was, since it's WM-dependent, it
> doesn't really matter which WMs we cause test failures on, so we might
> as well ensure that the testbot works.

Yes, it's fvwm2. I'm not sure why it fails on the testbot, but this
should be addressed by tweaking the testbot config.

-- 
Alexandre Julliard
julliard(a)winehq.org