Re: [PATCH 2/4] d3drm: Fix frame object creation method.
Am 08.06.2016 um 23:49 schrieb Aaryaman Vasishta:
There is a warning generated while compiling this. It's because IDirect3DRMFrame stubs aren't in yet. I'll be adding them next patch.
Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> ---
Hi Aaryaman, You should rather not send patches which generate Warnings at compile/link time...
Not even if it's fixed in patch 3/4? I don't mind remaking the patches, but still wondering why. Cheers, Aaryaman On Thu, Jun 9, 2016 at 6:01 PM, André Hentschel <nerv(a)dawncrow.de> wrote:
Am 08.06.2016 um 23:49 schrieb Aaryaman Vasishta:
There is a warning generated while compiling this. It's because IDirect3DRMFrame stubs aren't in yet. I'll be adding them next patch.
Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> ---
Hi Aaryaman,
You should rather not send patches which generate Warnings at compile/link time...
On 9 June 2016 at 14:57, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote:
Not even if it's fixed in patch 3/4? I don't mind remaking the patches, but still wondering why.
Mostly because patches are supposed to stand on their own. I.e., if only the first two patches of the series would be applied, they should still make sense. And during a bisect, you can very well end up in the middle of such a series. The patch doesn't really change the behaviour of course, so in that regard you could just add a cast and remove it again in the following patch. Still, if you can reorder things in a way that avoids that cast, that's even better.
Right, I understand, it makes sense. I'll avoid the cast and reorder the things. :) Cheers, Aaryaman On Thu, Jun 9, 2016 at 6:34 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
On 9 June 2016 at 14:57, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote:
Not even if it's fixed in patch 3/4? I don't mind remaking the patches, but still wondering why.
Mostly because patches are supposed to stand on their own. I.e., if only the first two patches of the series would be applied, they should still make sense. And during a bisect, you can very well end up in the middle of such a series. The patch doesn't really change the behaviour of course, so in that regard you could just add a cast and remove it again in the following patch. Still, if you can reorder things in a way that avoids that cast, that's even better.
participants (3)
-
Aaryaman Vasishta -
André Hentschel -
Henri Verbeet