Re: user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

[Alexandre Julliard]

André Hentschel <nerv(a)dawncrow.de> writes:
> @@ -5173,10 +5173,10 @@ const struct builtin_class_descr EDIT_builtin_class =
>      editW,                /* name */
>      CS_DBLCLKS | CS_PARENTDC,   /* style */
>      WINPROC_EDIT,         /* proc */
> -#ifdef __i386__
> -    sizeof(EDITSTATE *) + sizeof(WORD), /* extra */
> -#else
> +#ifdef _WIN64
>      sizeof(EDITSTATE *),  /* extra */
> +#else
> +    sizeof(EDITSTATE *) + sizeof(WORD), /* extra */
>  #endif

Why do you need that?

-- 
Alexandre Julliard
julliard(a)winehq.org

user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

[André Hentschel]

Am 04.10.2012 10:40, schrieb Alexandre Julliard:
> André Hentschel <nerv(a)dawncrow.de> writes:
> > @@ -5173,10 +5173,10 @@ const struct builtin_class_descr EDIT_builtin_class =
> >      editW,                /* name */
> >      CS_DBLCLKS | CS_PARENTDC,   /* style */
> >      WINPROC_EDIT,         /* proc */
> > -#ifdef __i386__
> > -    sizeof(EDITSTATE *) + sizeof(WORD), /* extra */
> > -#else
> > +#ifdef _WIN64
> >      sizeof(EDITSTATE *),  /* extra */
> > +#else
> > +    sizeof(EDITSTATE *) + sizeof(WORD), /* extra */
> >  #endif
>
> Why do you need that?

Sry, seen this too late.
I need it for user32/tests/edit.c: test_extra_values()
It expects the size of the edit class like this:

#ifdef _WIN64
    {"Edit",8,8},
#else
    {"Edit",6,8},
#endif

So this fails on e.g. ARM because code and test use different conditions.

-- 

Best Regards, André Hentschel

user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

[Alexandre Julliard]

André Hentschel <nerv(a)dawncrow.de> writes:
> Sry, seen this too late.
> I need it for user32/tests/edit.c: test_extra_values()
> It expects the size of the edit class like this:
>
> #ifdef _WIN64
>     {"Edit",8,8},
> #else
>     {"Edit",6,8},
> #endif
>
> So this fails on e.g. ARM because code and test use different conditions.

Did you run that test on Windows ARM?

-- 
Alexandre Julliard
julliard(a)winehq.org

user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

[André Hentschel]

Am 08.10.2012 12:35, schrieb Alexandre Julliard:
> André Hentschel <nerv(a)dawncrow.de> writes:
> > Sry, seen this too late.
> > I need it for user32/tests/edit.c: test_extra_values()
> > It expects the size of the edit class like this:
> >
> > #ifdef _WIN64
> >     {"Edit",8,8},
> > #else
> >     {"Edit",6,8},
> > #endif
> >
> > So this fails on e.g. ARM because code and test use different conditions.
>
> Did you run that test on Windows ARM?

Sadly not... (maybe codeweavers can buy a Windows RT device? :)
I'll try to fix the test, that seems much more logical now.

-- 

Best Regards, André Hentschel