Re: [PATCH 1/4] jscript: Added implementation of Array.reverse

[Jacek Caban]

Hi Piotr,

On 1/15/10 1:17 AM, Piotr Caban wrote:
> ---
>   dlls/jscript/array.c      |   37 +++++++++++++++++++++++++++++++++++--
>   dlls/jscript/tests/api.js |   26 ++++++++++++++++++++++++++
>   2 files changed, 61 insertions(+), 2 deletions(-)

+        if(hres1 == DISP_E_UNKNOWNNAME)
+            jsdisp_delete_idx(jsthis, l);
+        else
+            jsdisp_propput_idx(jsthis, l,&v1, ei, sp);
+
+        if(hres2 == DISP_E_UNKNOWNNAME)
+            jsdisp_delete_idx(jsthis, k);
+        else
+            jsdisp_propput_idx(jsthis, k,&v2, ei, sp);


You should check error codes of these calls.


Jacek