[PATCH 1/5] ntoskrnl.exe/tests: Wait for second report first.

[Rémi Bernon]

And increasing the polling period, so that first queued read is unlikely
to complete before we queued the second one.

This was meant to test that all pending reads are satisfied at once
after a poll, but it causes some spurious failures as they aren't
satisfied atomically (especially on Wine). As there's an increasing seq
counter in each poll it should be enough to compare the report data.

Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com>
---

This should help with spurious failure like:

  https://test.winehq.org/data/3f2850aeaa159270384764843cdb1dc3cbe902c6/linux_...

 dlls/ntoskrnl.exe/tests/ntoskrnl.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index f5ebf21b7f9..6c4dacf3a2d 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -2710,12 +2710,12 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
         ok(!ret, "ReadFile succeded\n");
         ok(GetLastError() == ERROR_IO_PENDING, "ReadFile returned error %u\n", GetLastError());
 
-        /* wait for first report to be ready */
-        ret = GetOverlappedResult(async_file, &overlapped, &value, TRUE);
+        /* wait for second report to be ready */
+        ret = GetOverlappedResult(async_file, &overlapped2, &value, TRUE);
         ok(ret, "GetOverlappedResult failed, last error %u\n", GetLastError());
         ok(value == (report_id ? 3 : 4), "GetOverlappedResult returned length %u, expected 3\n", value);
-        /* second report should be ready and the same */
-        ret = GetOverlappedResult(async_file, &overlapped2, &value, FALSE);
+        /* first report should be ready and the same */
+        ret = GetOverlappedResult(async_file, &overlapped, &value, FALSE);
         ok(ret, "GetOverlappedResult failed, last error %u\n", GetLastError());
         ok(value == (report_id ? 3 : 4), "GetOverlappedResult returned length %u, expected 3\n", value);
         ok(memcmp(report, buffer + caps.InputReportByteLength, caps.InputReportByteLength),
@@ -2839,7 +2839,7 @@ static void test_hid_device(DWORD report_id, DWORD polled)
         todo_wine ok(poll_freq == 5, "got poll_freq %u, expected 5\n", poll_freq);
 
         out_len = 0;
-        poll_freq = 50;
+        poll_freq = 500;
         SetLastError(0xdeadbeef);
         ret = sync_ioctl(file, IOCTL_HID_SET_POLL_FREQUENCY_MSEC, &poll_freq, sizeof(ULONG), NULL, &out_len);
         ok(ret, "IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error %u\n", GetLastError());
@@ -2850,14 +2850,14 @@ static void test_hid_device(DWORD report_id, DWORD polled)
         ret = sync_ioctl(file, IOCTL_HID_GET_POLL_FREQUENCY_MSEC, NULL, 0, &poll_freq, &out_len);
         ok(ret, "IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error %u\n", GetLastError());
         ok(out_len == sizeof(ULONG), "got out_len %u, expected sizeof(ULONG)\n", out_len);
-        ok(poll_freq == 50, "got poll_freq %u, expected 100\n", poll_freq);
+        ok(poll_freq == 500, "got poll_freq %u, expected 100\n", poll_freq);
 
         out_len = sizeof(ULONG);
         SetLastError(0xdeadbeef);
         ret = sync_ioctl(async_file, IOCTL_HID_GET_POLL_FREQUENCY_MSEC, NULL, 0, &poll_freq, &out_len);
         ok(ret, "IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error %u\n", GetLastError());
         ok(out_len == sizeof(ULONG), "got out_len %u, expected sizeof(ULONG)\n", out_len);
-        ok(poll_freq == 50, "got poll_freq %u, expected 100\n", poll_freq);
+        ok(poll_freq == 500, "got poll_freq %u, expected 100\n", poll_freq);
     }
 
     test_hidp(file, async_file, report_id, polled);
-- 
2.32.0

[PATCH 2/5] hidclass.sys: Use hid_device_xfer_report for IOCTL_HID_SET_OUTPUT_REPORT.

[Rémi Bernon]

Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com>
---
 dlls/hidclass.sys/device.c           | 32 ++++++++++++++++++----------
 dlls/ntoskrnl.exe/tests/driver_hid.c |  3 +--
 dlls/ntoskrnl.exe/tests/ntoskrnl.c   |  8 +++----
 3 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c
index 81ddd7e6d7e..8a57516d5d5 100644
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -303,16 +303,32 @@ static void hid_device_xfer_report( BASE_DEVICE_EXTENSION *ext, ULONG code, IRP
 {
     const WINE_HIDP_PREPARSED_DATA *preparsed = ext->u.pdo.preparsed_data;
     IO_STACK_LOCATION *stack = IoGetCurrentIrpStackLocation( irp );
-    ULONG report_len = 0, buffer_len = stack->Parameters.DeviceIoControl.OutputBufferLength;
-    BYTE *buffer = MmGetSystemAddressForMdlSafe( irp->MdlAddress, NormalPagePriority );
     BYTE report_id = HID_INPUT_VALUE_CAPS( preparsed )->report_id;
+    ULONG report_len = 0, buffer_len = 0;
     HID_XFER_PACKET packet;
+    BYTE *buffer = NULL;
+
+    switch (code)
+    {
+    case IOCTL_HID_GET_FEATURE:
+    case IOCTL_HID_GET_INPUT_REPORT:
+        buffer_len = stack->Parameters.DeviceIoControl.OutputBufferLength;
+        buffer = MmGetSystemAddressForMdlSafe( irp->MdlAddress, NormalPagePriority );
+        break;
+    case IOCTL_HID_SET_OUTPUT_REPORT:
+        buffer_len = stack->Parameters.DeviceIoControl.InputBufferLength;
+        buffer = irp->AssociatedIrp.SystemBuffer;
+        break;
+    }
 
     switch (code)
     {
     case IOCTL_HID_GET_INPUT_REPORT:
         report_len = preparsed->caps.InputReportByteLength;
         break;
+    case IOCTL_HID_SET_OUTPUT_REPORT:
+        report_len = preparsed->caps.OutputReportByteLength;
+        break;
     case IOCTL_HID_GET_FEATURE:
         report_len = preparsed->caps.FeatureReportByteLength;
         break;
@@ -357,19 +373,13 @@ static void HID_set_to_device( DEVICE_OBJECT *device, IRP *irp )
     {
         packet.reportBuffer = &((BYTE*)irp->AssociatedIrp.SystemBuffer)[1];
         packet.reportBufferLen = irpsp->Parameters.DeviceIoControl.InputBufferLength - 1;
-        if (irpsp->Parameters.DeviceIoControl.IoControlCode == IOCTL_HID_SET_FEATURE)
-            max_len = data->caps.FeatureReportByteLength;
-        else
-            max_len = data->caps.OutputReportByteLength;
+        max_len = data->caps.FeatureReportByteLength;
     }
     else
     {
         packet.reportBuffer = irp->AssociatedIrp.SystemBuffer;
         packet.reportBufferLen = irpsp->Parameters.DeviceIoControl.InputBufferLength;
-        if (irpsp->Parameters.DeviceIoControl.IoControlCode == IOCTL_HID_SET_FEATURE)
-            max_len = data->reports[data->reportIdx[HidP_Feature][packet.reportId]].bitSize;
-        else
-            max_len = data->reports[data->reportIdx[HidP_Output][packet.reportId]].bitSize;
+        max_len = data->reports[data->reportIdx[HidP_Feature][packet.reportId]].bitSize;
         max_len = (max_len + 7) / 8;
     }
     if (packet.reportBufferLen > max_len)
@@ -497,10 +507,10 @@ NTSTATUS WINAPI pdo_ioctl(DEVICE_OBJECT *device, IRP *irp)
         }
         case IOCTL_HID_GET_FEATURE:
         case IOCTL_HID_GET_INPUT_REPORT:
+        case IOCTL_HID_SET_OUTPUT_REPORT:
             hid_device_xfer_report( ext, code, irp );
             break;
         case IOCTL_HID_SET_FEATURE:
-        case IOCTL_HID_SET_OUTPUT_REPORT:
             HID_set_to_device( device, irp );
             break;
         default:
diff --git a/dlls/ntoskrnl.exe/tests/driver_hid.c b/dlls/ntoskrnl.exe/tests/driver_hid.c
index d268b62d288..422b9b74daa 100644
--- a/dlls/ntoskrnl.exe/tests/driver_hid.c
+++ b/dlls/ntoskrnl.exe/tests/driver_hid.c
@@ -552,9 +552,8 @@ static NTSTATUS WINAPI driver_internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
             todo_wine ok(in_size == sizeof(*packet), "got input size %u\n", in_size);
             todo_wine ok(!out_size, "got output size %u\n", out_size);
 
-            todo_wine_if(packet->reportId != report_id)
+            todo_wine_if(packet->reportId == 0x5a)
             ok(packet->reportId == report_id, "got id %u\n", packet->reportId);
-            todo_wine_if(packet->reportBufferLen == 0 || packet->reportBufferLen == 1)
             ok(packet->reportBufferLen >= expected_size, "got len %u\n", packet->reportBufferLen);
             ok(!!packet->reportBuffer, "got buffer %p\n", packet->reportBuffer);
 
diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index 6c4dacf3a2d..b2b918001fe 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -2581,14 +2581,12 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
 
     SetLastError(0xdeadbeef);
     ret = HidD_SetOutputReport(file, report, 0);
-    todo_wine ok(!ret, "HidD_SetOutputReport succeeded\n");
+    ok(!ret, "HidD_SetOutputReport succeeded\n");
     todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_SetOutputReport returned error %u\n", GetLastError());
 
     SetLastError(0xdeadbeef);
     ret = HidD_SetOutputReport(file, report, caps.OutputReportByteLength - 1);
-    todo_wine
     ok(!ret, "HidD_SetOutputReport succeeded\n");
-    todo_wine
     ok(GetLastError() == ERROR_INVALID_PARAMETER || broken(GetLastError() == ERROR_CRC),
        "HidD_SetOutputReport returned error %u\n", GetLastError());
 
@@ -2615,13 +2613,13 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
     value = caps.OutputReportByteLength * 2;
     SetLastError(0xdeadbeef);
     ret = sync_ioctl(file, IOCTL_HID_SET_OUTPUT_REPORT, NULL, 0, report, &value);
-    todo_wine ok(!ret, "IOCTL_HID_SET_OUTPUT_REPORT succeeded\n");
+    ok(!ret, "IOCTL_HID_SET_OUTPUT_REPORT succeeded\n");
     todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "IOCTL_HID_SET_OUTPUT_REPORT returned error %u\n", GetLastError());
     value = 0;
     SetLastError(0xdeadbeef);
     ret = sync_ioctl(file, IOCTL_HID_SET_OUTPUT_REPORT, report, caps.OutputReportByteLength * 2, NULL, &value);
     ok(ret, "IOCTL_HID_SET_OUTPUT_REPORT failed, last error %u\n", GetLastError());
-    todo_wine ok(value == 3, "got length %u, expected 3\n", value);
+    ok(value == 3, "got length %u, expected 3\n", value);
 
 
     SetLastError(0xdeadbeef);
-- 
2.32.0

[PATCH 3/5] hidclass.sys: Pass sizeof(packet) as input for IOCTL_HID_SET_OUTPUT_REPORT.

[Rémi Bernon]

Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com>
---
 dlls/hidclass.sys/device.c           | 11 ++++++++++-
 dlls/ntoskrnl.exe/tests/driver_hid.c |  4 ++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c
index 8a57516d5d5..123feeb6032 100644
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -356,7 +356,16 @@ static void hid_device_xfer_report( BASE_DEVICE_EXTENSION *ext, ULONG code, IRP
         packet.reportBufferLen--;
     }
 
-    call_minidriver( code, ext->u.pdo.parent_fdo, NULL, 0, &packet, sizeof(packet), &irp->IoStatus );
+    switch (code)
+    {
+    case IOCTL_HID_GET_FEATURE:
+    case IOCTL_HID_GET_INPUT_REPORT:
+        call_minidriver( code, ext->u.pdo.parent_fdo, NULL, 0, &packet, sizeof(packet), &irp->IoStatus );
+        break;
+    case IOCTL_HID_SET_OUTPUT_REPORT:
+        call_minidriver( code, ext->u.pdo.parent_fdo, NULL, sizeof(packet), &packet, 0, &irp->IoStatus );
+        break;
+    }
 }
 
 static void HID_set_to_device( DEVICE_OBJECT *device, IRP *irp )
diff --git a/dlls/ntoskrnl.exe/tests/driver_hid.c b/dlls/ntoskrnl.exe/tests/driver_hid.c
index 422b9b74daa..8ddbfe3850f 100644
--- a/dlls/ntoskrnl.exe/tests/driver_hid.c
+++ b/dlls/ntoskrnl.exe/tests/driver_hid.c
@@ -549,8 +549,8 @@ static NTSTATUS WINAPI driver_internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
         {
             HID_XFER_PACKET *packet = irp->UserBuffer;
             ULONG expected_size = 2;
-            todo_wine ok(in_size == sizeof(*packet), "got input size %u\n", in_size);
-            todo_wine ok(!out_size, "got output size %u\n", out_size);
+            ok(in_size == sizeof(*packet), "got input size %u\n", in_size);
+            ok(!out_size, "got output size %u\n", out_size);
 
             todo_wine_if(packet->reportId == 0x5a)
             ok(packet->reportId == report_id, "got id %u\n", packet->reportId);
-- 
2.32.0

[PATCH 4/5] hidclass.sys: Return STATUS_INVALID_USER_BUFFER if buffer_len is 0.

[Rémi Bernon]

Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com>
---
 dlls/hidclass.sys/device.c         | 2 +-
 dlls/ntoskrnl.exe/tests/ntoskrnl.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c
index 123feeb6032..e2a2e7c39d4 100644
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -334,7 +334,7 @@ static void hid_device_xfer_report( BASE_DEVICE_EXTENSION *ext, ULONG code, IRP
         break;
     }
 
-    if (!buffer)
+    if (!buffer || !buffer_len)
     {
         irp->IoStatus.Status = STATUS_INVALID_USER_BUFFER;
         return;
diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index b2b918001fe..43a87add0f9 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -2582,7 +2582,7 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
     SetLastError(0xdeadbeef);
     ret = HidD_SetOutputReport(file, report, 0);
     ok(!ret, "HidD_SetOutputReport succeeded\n");
-    todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_SetOutputReport returned error %u\n", GetLastError());
+    ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_SetOutputReport returned error %u\n", GetLastError());
 
     SetLastError(0xdeadbeef);
     ret = HidD_SetOutputReport(file, report, caps.OutputReportByteLength - 1);
@@ -2614,7 +2614,7 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
     SetLastError(0xdeadbeef);
     ret = sync_ioctl(file, IOCTL_HID_SET_OUTPUT_REPORT, NULL, 0, report, &value);
     ok(!ret, "IOCTL_HID_SET_OUTPUT_REPORT succeeded\n");
-    todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "IOCTL_HID_SET_OUTPUT_REPORT returned error %u\n", GetLastError());
+    ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "IOCTL_HID_SET_OUTPUT_REPORT returned error %u\n", GetLastError());
     value = 0;
     SetLastError(0xdeadbeef);
     ret = sync_ioctl(file, IOCTL_HID_SET_OUTPUT_REPORT, report, caps.OutputReportByteLength * 2, NULL, &value);
-- 
2.32.0

[PATCH 5/5] hidclass.sys: Use hid_device_xfer_report for IOCTL_HID_SET_FEATURE.

[Rémi Bernon]

Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com>
---
 dlls/hidclass.sys/device.c           | 46 +++-------------------------
 dlls/ntoskrnl.exe/tests/driver_hid.c |  7 ++---
 dlls/ntoskrnl.exe/tests/ntoskrnl.c   | 12 +++-----
 3 files changed, 12 insertions(+), 53 deletions(-)

diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c
index e2a2e7c39d4..83c0c1159ff 100644
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -315,6 +315,7 @@ static void hid_device_xfer_report( BASE_DEVICE_EXTENSION *ext, ULONG code, IRP
         buffer_len = stack->Parameters.DeviceIoControl.OutputBufferLength;
         buffer = MmGetSystemAddressForMdlSafe( irp->MdlAddress, NormalPagePriority );
         break;
+    case IOCTL_HID_SET_FEATURE:
     case IOCTL_HID_SET_OUTPUT_REPORT:
         buffer_len = stack->Parameters.DeviceIoControl.InputBufferLength;
         buffer = irp->AssociatedIrp.SystemBuffer;
@@ -330,6 +331,7 @@ static void hid_device_xfer_report( BASE_DEVICE_EXTENSION *ext, ULONG code, IRP
         report_len = preparsed->caps.OutputReportByteLength;
         break;
     case IOCTL_HID_GET_FEATURE:
+    case IOCTL_HID_SET_FEATURE:
         report_len = preparsed->caps.FeatureReportByteLength;
         break;
     }
@@ -362,51 +364,13 @@ static void hid_device_xfer_report( BASE_DEVICE_EXTENSION *ext, ULONG code, IRP
     case IOCTL_HID_GET_INPUT_REPORT:
         call_minidriver( code, ext->u.pdo.parent_fdo, NULL, 0, &packet, sizeof(packet), &irp->IoStatus );
         break;
+    case IOCTL_HID_SET_FEATURE:
     case IOCTL_HID_SET_OUTPUT_REPORT:
         call_minidriver( code, ext->u.pdo.parent_fdo, NULL, sizeof(packet), &packet, 0, &irp->IoStatus );
         break;
     }
 }
 
-static void HID_set_to_device( DEVICE_OBJECT *device, IRP *irp )
-{
-    IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation(irp);
-    BASE_DEVICE_EXTENSION *ext = device->DeviceExtension;
-    const WINE_HIDP_PREPARSED_DATA *data = ext->u.pdo.preparsed_data;
-    HID_XFER_PACKET packet;
-    ULONG max_len;
-
-    TRACE_(hid_report)("Device %p Buffer length %i Buffer %p\n", device, irpsp->Parameters.DeviceIoControl.InputBufferLength, irp->AssociatedIrp.SystemBuffer);
-    packet.reportId = ((BYTE*)irp->AssociatedIrp.SystemBuffer)[0];
-    if (packet.reportId == 0)
-    {
-        packet.reportBuffer = &((BYTE*)irp->AssociatedIrp.SystemBuffer)[1];
-        packet.reportBufferLen = irpsp->Parameters.DeviceIoControl.InputBufferLength - 1;
-        max_len = data->caps.FeatureReportByteLength;
-    }
-    else
-    {
-        packet.reportBuffer = irp->AssociatedIrp.SystemBuffer;
-        packet.reportBufferLen = irpsp->Parameters.DeviceIoControl.InputBufferLength;
-        max_len = data->reports[data->reportIdx[HidP_Feature][packet.reportId]].bitSize;
-        max_len = (max_len + 7) / 8;
-    }
-    if (packet.reportBufferLen > max_len)
-        packet.reportBufferLen = max_len;
-
-    TRACE_(hid_report)("(id %i, len %i buffer %p)\n", packet.reportId, packet.reportBufferLen, packet.reportBuffer);
-
-    call_minidriver( irpsp->Parameters.DeviceIoControl.IoControlCode, ext->u.pdo.parent_fdo, NULL,
-                     0, &packet, sizeof(packet), &irp->IoStatus );
-
-    if (irp->IoStatus.Status == STATUS_SUCCESS)
-        irp->IoStatus.Information = irpsp->Parameters.DeviceIoControl.InputBufferLength;
-    else
-        irp->IoStatus.Information = 0;
-
-    TRACE_(hid_report)( "Result 0x%x set %li bytes\n", irp->IoStatus.Status, irp->IoStatus.Information );
-}
-
 NTSTATUS WINAPI pdo_ioctl(DEVICE_OBJECT *device, IRP *irp)
 {
     IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation( irp );
@@ -515,13 +479,11 @@ NTSTATUS WINAPI pdo_ioctl(DEVICE_OBJECT *device, IRP *irp)
             break;
         }
         case IOCTL_HID_GET_FEATURE:
+        case IOCTL_HID_SET_FEATURE:
         case IOCTL_HID_GET_INPUT_REPORT:
         case IOCTL_HID_SET_OUTPUT_REPORT:
             hid_device_xfer_report( ext, code, irp );
             break;
-        case IOCTL_HID_SET_FEATURE:
-            HID_set_to_device( device, irp );
-            break;
         default:
         {
             ULONG code = irpsp->Parameters.DeviceIoControl.IoControlCode;
diff --git a/dlls/ntoskrnl.exe/tests/driver_hid.c b/dlls/ntoskrnl.exe/tests/driver_hid.c
index 8ddbfe3850f..4f0a8591299 100644
--- a/dlls/ntoskrnl.exe/tests/driver_hid.c
+++ b/dlls/ntoskrnl.exe/tests/driver_hid.c
@@ -585,12 +585,11 @@ static NTSTATUS WINAPI driver_internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
         {
             HID_XFER_PACKET *packet = irp->UserBuffer;
             ULONG expected_size = 17;
-            todo_wine ok(in_size == sizeof(*packet), "got input size %u\n", in_size);
-            todo_wine ok(!out_size, "got output size %u\n", out_size);
+            ok(in_size == sizeof(*packet), "got input size %u\n", in_size);
+            ok(!out_size, "got output size %u\n", out_size);
 
-            todo_wine_if(packet->reportId != report_id)
+            todo_wine_if(packet->reportId == 0x5a)
             ok(packet->reportId == report_id, "got id %u\n", packet->reportId);
-            todo_wine_if(packet->reportBufferLen == 0 || packet->reportBufferLen == 16)
             ok(packet->reportBufferLen >= expected_size, "got len %u\n", packet->reportBufferLen);
             ok(!!packet->reportBuffer, "got buffer %p\n", packet->reportBuffer);
 
diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index 43a87add0f9..128a81a5f83 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -2530,14 +2530,12 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
 
     SetLastError(0xdeadbeef);
     ret = HidD_SetFeature(file, report, 0);
-    todo_wine ok(!ret, "HidD_SetFeature succeeded\n");
-    todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_SetFeature returned error %u\n", GetLastError());
+    ok(!ret, "HidD_SetFeature succeeded\n");
+    ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_SetFeature returned error %u\n", GetLastError());
 
     SetLastError(0xdeadbeef);
     ret = HidD_SetFeature(file, report, caps.FeatureReportByteLength - 1);
-    todo_wine
     ok(!ret, "HidD_SetFeature succeeded\n");
-    todo_wine
     ok(GetLastError() == ERROR_INVALID_PARAMETER || broken(GetLastError() == ERROR_CRC),
        "HidD_SetFeature returned error %u\n", GetLastError());
 
@@ -2564,13 +2562,13 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
     value = caps.FeatureReportByteLength * 2;
     SetLastError(0xdeadbeef);
     ret = sync_ioctl(file, IOCTL_HID_SET_FEATURE, NULL, 0, report, &value);
-    todo_wine ok(!ret, "IOCTL_HID_SET_FEATURE succeeded\n");
-    todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "IOCTL_HID_SET_FEATURE returned error %u\n", GetLastError());
+    ok(!ret, "IOCTL_HID_SET_FEATURE succeeded\n");
+    ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "IOCTL_HID_SET_FEATURE returned error %u\n", GetLastError());
     value = 0;
     SetLastError(0xdeadbeef);
     ret = sync_ioctl(file, IOCTL_HID_SET_FEATURE, report, caps.FeatureReportByteLength * 2, NULL, &value);
     ok(ret, "IOCTL_HID_SET_FEATURE failed, last error %u\n", GetLastError());
-    todo_wine ok(value == 3, "got length %u, expected 3\n", value);
+    ok(value == 3, "got length %u, expected 3\n", value);
 
 
     memset(report, 0xcd, sizeof(report));
-- 
2.32.0

[PATCH 5/5] hidclass.sys: Use hid_device_xfer_report for IOCTL_HID_SET_FEATURE.

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=95168

Your paranoid android.


=== w7u_2qxl (32 bit report) ===

ntoskrnl.exe:
ntoskrnl.c:2938: Test failed: failed to register device, error 0xe000020b
ntoskrnl.c:2771: Test failed: id 0 poll: didn't find device
ntoskrnl.c:2775: Test failed: id 0 poll: got error 5
ntoskrnl.c:2780: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
ntoskrnl.c:2781: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
ntoskrnl.c:2786: Test failed: id 0 poll: HidD_SetNumInputBuffers returned error 6
ntoskrnl.c:2790: Test failed: id 0 poll: HidD_SetNumInputBuffers returned error 6
ntoskrnl.c:2794: Test failed: id 0 poll: HidD_SetNumInputBuffers failed last error 6
ntoskrnl.c:2799: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
ntoskrnl.c:2800: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
ntoskrnl.c:2805: Test failed: id 0 poll: got error 5
ntoskrnl.c:2810: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
ntoskrnl.c:2811: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
ntoskrnl.c:2815: Test failed: id 0 poll: HidD_SetNumInputBuffers failed last error 6
ntoskrnl.c:2820: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
ntoskrnl.c:2821: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
ntoskrnl.c:2825: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
ntoskrnl.c:2826: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
ntoskrnl.c:2833: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
ntoskrnl.c:2835: Test failed: id 0 poll: got poll_freq 6567056, expected 5
ntoskrnl.c:2841: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
ntoskrnl.c:2847: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
ntoskrnl.c:2854: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
ntoskrnl.c:1890: Test failed: id 0 poll: HidD_GetPreparsedData failed with error 6
ntoskrnl.c:1896: Test failed: id 0 poll: HidP_GetCaps returned 0xc0110001
ntoskrnl.c:1897: Test failed: id 0 poll: got InputReportByteLength 23, expected 24
ntoskrnl.c:1897: Test failed: id 0 poll: got OutputReportByteLength 2, expected 3
ntoskrnl.c:1897: Test failed: id 0 poll: got FeatureReportByteLength 17, expected 18
ntoskrnl.c:1901: Test failed: id 0 poll: HidP_GetLinkCollectionNodes returned 0xc0110001
ntoskrnl.c:1902: Test failed: id 0 poll: got 0 collection nodes, expected 10
ntoskrnl.c:1908: Test failed: id 0 poll: HidP_GetLinkCollectionNodes returned 0xc0110001
ntoskrnl.c:1909: Test failed: id 0 poll: got 16 collection nodes, expected 10
ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got LinkUsage 0074, expected 0004
ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got LinkUsagePage 0076, expected 0001
ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got Parent 56000, expected 0
ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got NumberOfChildren 65, expected 7
ntoskrnl.c:1921: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
ntoskrnl.c:1923: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
ntoskrnl.c:1926: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
ntoskrnl.c:1927: Test failed: id 0 poll: HidP_GetButtonCaps returned count 0, expected 13
ntoskrnl.c:1934: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
ntoskrnl.c:1935: Test failed: id 0 poll: HidP_GetButtonCaps returned count 16, expected 13
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got UsagePage 0000, expected 0009
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got BitField 0, expected 2
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got LinkCollection 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got LinkUsage 0000, expected 0004
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got LinkUsagePage 0000, expected 0001
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got IsRange 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got IsAbsolute 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got UsagePage 0000, expected 0009
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got BitField 0, expected 3
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got LinkCollection 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got LinkUsage 0000, expected 0004
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got LinkUsagePage 0000, expected 0001
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got IsRange 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got IsAbsolute 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got UsagePage 0000, expected 0007
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got BitField 0, expected 508
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got LinkCollection 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got LinkUsage 0000, expected 0004
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got LinkUsagePage 0000, expected 0001
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got IsRange 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got UsagePage 0000, expected 0009
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got BitField 0, expected 2
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got LinkCollection 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got LinkUsage 0000, expected 0004
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got LinkUsagePage 0000, expected 0001
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got IsAbsolute 0, expected 1
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got NotRange.Usage 0000, expected 0020
ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got NotRange.DataIndex 0, expected 26
ntoskrnl.c:1947: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1949: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1952: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1953: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 0, expected 13
ntoskrnl.c:1960: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1961: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 15, expected 13
ntoskrnl.c:1967: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1968: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 15, expected 1
ntoskrnl.c:1973: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1974: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 48879, expected 0
ntoskrnl.c:1977: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1978: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 48879, expected 0
ntoskrnl.c:1981: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
ntoskrnl.c:1982: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 48879, expected 0
ntoskrnl.c:1986: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
ntoskrnl.c:1988: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
ntoskrnl.c:1991: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
ntoskrnl.c:1992: Test failed: id 0 poll: HidP_GetValueCaps returned count 0, expected 7
ntoskrnl.c:1998: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
ntoskrnl.c:1999: Test failed: id 0 poll: HidP_GetValueCaps returned count 16, expected 7
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got UsagePage 3a43, expected 0001
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got ReportID 92, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsAlias 87, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got BitField 28265, expected 2
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got LinkCollection 28516, expected 1
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got LinkUsage 29559, expected 4
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got LinkUsagePage 18780, expected 1
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsRange 78, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsStringRange 70, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsDesignatorRange 92, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsAbsolute 111, expected 1
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got HasNull 101, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got BitSize 11830, expected 8
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got ReportCount 28265, expected 1
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[1]: got ReportID 1, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[2]: got ReportID 1, expected 0
ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[3]: got ReportID 1, expected 0
ntoskrnl.c:2011: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2013: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2016: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2017: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 0, expected 7
ntoskrnl.c:2024: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2025: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 12, expected 7
ntoskrnl.c:2027: Test failed: id 0 poll: got UsagePage 0001, expected 3a43
ntoskrnl.c:2027: Test failed: id 0 poll: got ReportID 1, expected 92
ntoskrnl.c:2027: Test failed: id 0 poll: got IsAlias 0, expected 87
ntoskrnl.c:2027: Test failed: id 0 poll: got BitField 2, expected 28265
ntoskrnl.c:2027: Test failed: id 0 poll: got LinkCollection 1, expected 28516
ntoskrnl.c:2027: Test failed: id 0 poll: got LinkUsage 4, expected 29559
ntoskrnl.c:2027: Test failed: id 0 poll: got LinkUsagePage 1, expected 18780
ntoskrnl.c:2027: Test failed: id 0 poll: got IsRange 0, expected 78
ntoskrnl.c:2027: Test failed: id 0 poll: got IsStringRange 0, expected 70
ntoskrnl.c:2027: Test failed: id 0 poll: got IsDesignatorRange 0, expected 92
ntoskrnl.c:2027: Test failed: id 0 poll: got IsAbsolute 1, expected 111
ntoskrnl.c:2027: Test failed: id 0 poll: got HasNull 0, expected 101
ntoskrnl.c:2027: Test failed: id 0 poll: got BitSize 4, expected 11830
ntoskrnl.c:2027: Test failed: id 0 poll: got ReportCount 2, expected 28265
ntoskrnl.c:2027: Test failed: id 0 poll: got LogicalMin 1, expected -128
ntoskrnl.c:2027: Test failed: id 0 poll: got LogicalMax 8, expected 127
ntoskrnl.c:2035: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2041: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2042: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 57005, expected 0
ntoskrnl.c:2045: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2046: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 57005, expected 0
ntoskrnl.c:2049: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
ntoskrnl.c:2050: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 57005, expected 0
ntoskrnl.c:2055: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2057: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2059: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2061: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2065: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2070: Test failed: id 0 poll: unexpected report data
ntoskrnl.c:2074: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
ntoskrnl.c:2078: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
ntoskrnl.c:2082: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
ntoskrnl.c:2086: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
ntoskrnl.c:2090: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
ntoskrnl.c:2094: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
ntoskrnl.c:2099: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2103: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2104: Test failed: id 0 poll: got value deadbeef, expected 0x80
ntoskrnl.c:2108: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2109: Test failed: id 0 poll: got value deadbeef, expected 0xffffff80
ntoskrnl.c:2114: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2118: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2119: Test failed: id 0 poll: got value deadbeef, expected 0x7f
ntoskrnl.c:2124: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2128: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2129: Test failed: id 0 poll: got value deadbeef, expected 0
ntoskrnl.c:2134: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2138: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2139: Test failed: id 0 poll: got value deadbeef, expected 0
ntoskrnl.c:2143: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2144: Test failed: id 0 poll: got value deadbeef, expected 0x7fffffff
ntoskrnl.c:2149: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2153: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2154: Test failed: id 0 poll: got value deadbeef, expected 0x7fffffff
ntoskrnl.c:2159: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2163: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2164: Test failed: id 0 poll: got value deadbeef, expected 0x80000000
ntoskrnl.c:2169: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2173: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2174: Test failed: id 0 poll: got value deadbeef, expected 0
ntoskrnl.c:2179: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2183: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
ntoskrnl.c:2184: Test failed: id 0 poll: got value deadbeef, expected 0
ntoskrnl.c:2189: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Input, 0) returned 0, expected 42
ntoskrnl.c:2191: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Input, HID_USAGE_PAGE_BUTTON) returned 0, expected 32
ntoskrnl.c:2193: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Input, HID_USAGE_PAGE_LED) returned 0, expected 8
ntoskrnl.c:2195: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Feature, HID_USAGE_PAGE_BUTTON) returned 0, expected 8
ntoskrnl.c:2203: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
ntoskrnl.c:2209: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
ntoskrnl.c:2215: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
ntoskrnl.c:2221: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
ntoskrnl.c:2227: Test failed: id 0 poll: got report[6] ffffffcd expected 0
ntoskrnl.c:2228: Test failed: id 0 poll: got report[7] ffffffcd expected 0
ntoskrnl.c:2232: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
ntoskrnl.c:2235: Test failed: id 0 poll: unexpected report data
ntoskrnl.c:2239: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2244: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2250: Test failed: id 0 poll: HidP_GetUsages returned 0xc0110001
ntoskrnl.c:2251: Test failed: id 0 poll: got usage count 1, expected 2
ntoskrnl.c:2256: Test failed: id 0 poll: HidP_GetUsages returned 0xc0110001
ntoskrnl.c:2257: Test failed: id 0 poll: got usage count 16, expected 2
ntoskrnl.c:2258: Test failed: id 0 poll: got usages[0] cdcd, expected 4
ntoskrnl.c:2259: Test failed: id 0 poll: got usages[1] cdcd, expected 6
ntoskrnl.c:2265: Test failed: id 0 poll: HidP_GetUsages returned 0xc0110001
ntoskrnl.c:2266: Test failed: id 0 poll: got usage count 16, expected 2
ntoskrnl.c:2267: Test failed: id 0 poll: got usages[0] cdcd, expected 6
ntoskrnl.c:2268: Test failed: id 0 poll: got usages[1] cdcd, expected 4
ntoskrnl.c:2274: Test failed: id 0 poll: HidP_GetUsagesEx returned 0xc0110001
ntoskrnl.c:2275: Test failed: id 0 poll: got usage count 16, expected 4
ntoskrnl.c:2276: Test failed: id 0 poll: got usage_and_pages[0] UsagePage cdcd, expected 9
ntoskrnl.c:2278: Test failed: id 0 poll: got usage_and_pages[1] UsagePage cdcd, expected 9
ntoskrnl.c:2280: Test failed: id 0 poll: got usage_and_pages[2] UsagePage cdcd, expected 7
ntoskrnl.c:2282: Test failed: id 0 poll: got usage_and_pages[3] UsagePage cdcd, expected 7
ntoskrnl.c:2284: Test failed: id 0 poll: got usage_and_pages[4] UsagePage cdcd, expected 8
ntoskrnl.c:2286: Test failed: id 0 poll: got usage_and_pages[5] UsagePage cdcd, expected 8
ntoskrnl.c:2288: Test failed: id 0 poll: got usage_and_pages[0] Usage cdcd, expected 4
ntoskrnl.c:2290: Test failed: id 0 poll: got usage_and_pages[1] Usage cdcd, expected 6
ntoskrnl.c:2292: Test failed: id 0 poll: got usage_and_pages[2] Usage cdcd, expected 9
ntoskrnl.c:2294: Test failed: id 0 poll: got usage_and_pages[3] Usage cdcd, expected b
ntoskrnl.c:2296: Test failed: id 0 poll: got usage_and_pages[4] Usage cdcd, expected 6
ntoskrnl.c:2298: Test failed: id 0 poll: got usage_and_pages[5] Usage cdcd, expected 4
ntoskrnl.c:2304: Test failed: id 0 poll: HidP_MaxDataListLength(HidP_Input) returned 0, expected 50
ntoskrnl.c:2308: Test failed: id 0 poll: HidP_MaxDataListLength(HidP_Feature) returned 0, expected 13
ntoskrnl.c:2312: Test failed: id 0 poll: HidP_GetData returned 0xc0110001
ntoskrnl.c:2313: Test failed: id 0 poll: got data count 1, expected 11
ntoskrnl.c:2316: Test failed: id 0 poll: HidP_GetData returned 0xc0110001
ntoskrnl.c:2320: Test failed: id 0 poll: data[1]: got DataIndex 0, expected 1
ntoskrnl.c:2320: Test failed: id 0 poll: data[2]: got DataIndex 0, expected 5
ntoskrnl.c:2321: Test failed: id 0 poll: data[2]: got RawValue 0, expected 1
ntoskrnl.c:2320: Test failed: id 0 poll: data[3]: got DataIndex 0, expected 7
ntoskrnl.c:2321: Test failed: id 0 poll: data[3]: got RawValue 0, expected 1
ntoskrnl.c:2320: Test failed: id 0 poll: data[4]: got DataIndex 0, expected 19
ntoskrnl.c:2321: Test failed: id 0 poll: data[4]: got RawValue 0, expected 1
ntoskrnl.c:2320: Test failed: id 0 poll: data[5]: got DataIndex 0, expected 21
ntoskrnl.c:2321: Test failed: id 0 poll: data[5]: got RawValue 0, expected 1
ntoskrnl.c:2320: Test failed: id 0 poll: data[6]: got DataIndex 0, expected 30
ntoskrnl.c:2320: Test failed: id 0 poll: data[7]: got DataIndex 0, expected 31
ntoskrnl.c:2320: Test failed: id 0 poll: data[8]: got DataIndex 0, expected 32
ntoskrnl.c:2321: Test failed: id 0 poll: data[8]: got RawValue 0, expected -17970434
ntoskrnl.c:2320: Test failed: id 0 poll: data[9]: got DataIndex 0, expected 37
ntoskrnl.c:2321: Test failed: id 0 poll: data[9]: got RawValue 0, expected 1
ntoskrnl.c:2320: Test failed: id 0 poll: data[10]: got DataIndex 0, expected 39
ntoskrnl.c:2321: Test failed: id 0 poll: data[10]: got RawValue 0, expected 1
ntoskrnl.c:2327: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2331: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2336: Test failed: id 0 poll: unexpected report data
ntoskrnl.c:2354: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2358: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2363: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2369: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2373: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2378: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
ntoskrnl.c:2385: Test failed: id 0 poll: unexpected report data
ntoskrnl.c:2392: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2395: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2399: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2404: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2408: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2413: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
ntoskrnl.c:2414: Test failed: id 0 poll: got value deadbeef, expected 0x1005
ntoskrnl.c:2420: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
ntoskrnl.c:2423: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
ntoskrnl.c:2424: Test failed: id 0 poll: unexpected report data
ntoskrnl.c:2429: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
ntoskrnl.c:2432: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
ntoskrnl.c:2434: Test failed: id 0 poll: unexpected report value
ntoskrnl.c:2439: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2444: Test failed: id 0 poll: HidD_GetInputReport returned error 6
ntoskrnl.c:2449: Test failed: id 0 poll: HidD_GetInputReport returned error 6
ntoskrnl.c:2460: Test failed: id 0 poll: HidD_GetInputReport returned error 6
ntoskrnl.c:2471: Test failed: id 0 poll: HidD_GetInputReport failed, last error 6
ntoskrnl.c:2472: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
ntoskrnl.c:2477: Test failed: id 0 poll: IOCTL_HID_GET_INPUT_REPORT failed, last error 6
ntoskrnl.c:2478: Test failed: id 0 poll: got length 46, expected 3
ntoskrnl.c:2479: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
ntoskrnl.c:2484: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2489: Test failed: id 0 poll: HidD_GetFeature returned error 6
ntoskrnl.c:2494: Test failed: id 0 poll: HidD_GetFeature returned error 6
ntoskrnl.c:2505: Test failed: id 0 poll: HidD_GetFeature returned error 6
ntoskrnl.c:2516: Test failed: id 0 poll: HidD_GetFeature failed, last error 6
ntoskrnl.c:2517: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
ntoskrnl.c:2522: Test failed: id 0 poll: IOCTL_HID_GET_FEATURE failed, last error 6
ntoskrnl.c:2523: Test failed: id 0 poll: got length 34, expected 3
ntoskrnl.c:2524: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
ntoskrnl.c:2529: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2534: Test failed: id 0 poll: HidD_SetFeature returned error 6
ntoskrnl.c:2539: Test failed: id 0 poll: HidD_SetFeature returned error 6
ntoskrnl.c:2550: Test failed: id 0 poll: HidD_SetFeature returned error 6
ntoskrnl.c:2560: Test failed: id 0 poll: HidD_SetFeature failed, last error 6
ntoskrnl.c:2566: Test failed: id 0 poll: IOCTL_HID_SET_FEATURE returned error 6
ntoskrnl.c:2570: Test failed: id 0 poll: IOCTL_HID_SET_FEATURE failed, last error 6
ntoskrnl.c:2571: Test failed: id 0 poll: got length 0, expected 3
ntoskrnl.c:2576: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
ntoskrnl.c:2583: Test failed: id 0 poll: HidD_SetOutputReport returned error 6
ntoskrnl.c:2588: Test failed: id 0 poll: HidD_SetOutputReport returned error 6
ntoskrnl.c:2599: Test failed: id 0 poll: HidD_SetOutputReport returned error 6
ntoskrnl.c:2609: Test failed: id 0 poll: HidD_SetOutputReport failed, last error 6
ntoskrnl.c:2615: Test failed: id 0 poll: IOCTL_HID_SET_OUTPUT_REPORT returned error 6
ntoskrnl.c:2619: Test failed: id 0 poll: IOCTL_HID_SET_OUTPUT_REPORT failed, last error 6
ntoskrnl.c:2620: Test failed: id 0 poll: got length 0, expected 3
ntoskrnl.c:2626: Test failed: id 0 poll: WriteFile returned error 6
ntoskrnl.c:2631: Test failed: id 0 poll: WriteFile returned error 6
ntoskrnl.c:2644: Test failed: id 0 poll: WriteFile returned error 6
ntoskrnl.c:2659: Test failed: id 0 poll: WriteFile failed, last error 6
ntoskrnl.c:2660: Test failed: id 0 poll: WriteFile wrote 0
ntoskrnl.c:2667: Test failed: id 0 poll: ReadFile failed, last error 6
ntoskrnl.c:2671: Test failed: id 0 poll: ReadFile failed, last error 6
ntoskrnl.c:2679: Test failed: id 0 poll: ReadFile failed, last error 6
ntoskrnl.c:2680: Test failed: id 0 poll: ReadFile returned 0
ntoskrnl.c:2681: Test failed: id 0 poll: unexpected report data
ntoskrnl.c:2690: Test failed: id 0 poll: ReadFile returned error 6
ntoskrnl: Timeout

[PATCH 5/5] hidclass.sys: Use hid_device_xfer_report for IOCTL_HID_SET_FEATURE.

[Rémi Bernon]

On 8/6/21 10:25 AM, Marvin wrote:
> Hi,
>
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=95168
>
> Your paranoid android.
>
> === w7u_2qxl (32 bit report) ===
>
> ntoskrnl.exe:
> ntoskrnl.c:2938: Test failed: failed to register device, error 0xe000020b
> ntoskrnl.c:2771: Test failed: id 0 poll: didn't find device
> ntoskrnl.c:2775: Test failed: id 0 poll: got error 5
> ntoskrnl.c:2780: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
> ntoskrnl.c:2781: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
> ntoskrnl.c:2786: Test failed: id 0 poll: HidD_SetNumInputBuffers returned error 6
> ntoskrnl.c:2790: Test failed: id 0 poll: HidD_SetNumInputBuffers returned error 6
> ntoskrnl.c:2794: Test failed: id 0 poll: HidD_SetNumInputBuffers failed last error 6
> ntoskrnl.c:2799: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
> ntoskrnl.c:2800: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
> ntoskrnl.c:2805: Test failed: id 0 poll: got error 5
> ntoskrnl.c:2810: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
> ntoskrnl.c:2811: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
> ntoskrnl.c:2815: Test failed: id 0 poll: HidD_SetNumInputBuffers failed last error 6
> ntoskrnl.c:2820: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
> ntoskrnl.c:2821: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
> ntoskrnl.c:2825: Test failed: id 0 poll: HidD_GetNumInputBuffers failed last error 6
> ntoskrnl.c:2826: Test failed: id 0 poll: HidD_GetNumInputBuffers returned 3735928559
> ntoskrnl.c:2833: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
> ntoskrnl.c:2835: Test failed: id 0 poll: got poll_freq 6567056, expected 5
> ntoskrnl.c:2841: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
> ntoskrnl.c:2847: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
> ntoskrnl.c:2854: Test failed: id 0 poll: IOCTL_HID_GET_POLL_FREQUENCY_MSEC failed last error 6
> ntoskrnl.c:1890: Test failed: id 0 poll: HidD_GetPreparsedData failed with error 6
> ntoskrnl.c:1896: Test failed: id 0 poll: HidP_GetCaps returned 0xc0110001
> ntoskrnl.c:1897: Test failed: id 0 poll: got InputReportByteLength 23, expected 24
> ntoskrnl.c:1897: Test failed: id 0 poll: got OutputReportByteLength 2, expected 3
> ntoskrnl.c:1897: Test failed: id 0 poll: got FeatureReportByteLength 17, expected 18
> ntoskrnl.c:1901: Test failed: id 0 poll: HidP_GetLinkCollectionNodes returned 0xc0110001
> ntoskrnl.c:1902: Test failed: id 0 poll: got 0 collection nodes, expected 10
> ntoskrnl.c:1908: Test failed: id 0 poll: HidP_GetLinkCollectionNodes returned 0xc0110001
> ntoskrnl.c:1909: Test failed: id 0 poll: got 16 collection nodes, expected 10
> ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got LinkUsage 0074, expected 0004
> ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got LinkUsagePage 0076, expected 0001
> ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got Parent 56000, expected 0
> ntoskrnl.c:1915: Test failed: id 0 poll: collections[0]: got NumberOfChildren 65, expected 7
> ntoskrnl.c:1921: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
> ntoskrnl.c:1923: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
> ntoskrnl.c:1926: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
> ntoskrnl.c:1927: Test failed: id 0 poll: HidP_GetButtonCaps returned count 0, expected 13
> ntoskrnl.c:1934: Test failed: id 0 poll: HidP_GetButtonCaps returned 0xc0110001
> ntoskrnl.c:1935: Test failed: id 0 poll: HidP_GetButtonCaps returned count 16, expected 13
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got UsagePage 0000, expected 0009
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got BitField 0, expected 2
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got LinkCollection 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got LinkUsage 0000, expected 0004
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got LinkUsagePage 0000, expected 0001
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got IsRange 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[0]: got IsAbsolute 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got UsagePage 0000, expected 0009
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got BitField 0, expected 3
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got LinkCollection 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got LinkUsage 0000, expected 0004
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got LinkUsagePage 0000, expected 0001
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got IsRange 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[1]: got IsAbsolute 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got UsagePage 0000, expected 0007
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got BitField 0, expected 508
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got LinkCollection 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got LinkUsage 0000, expected 0004
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got LinkUsagePage 0000, expected 0001
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[2]: got IsRange 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got UsagePage 0000, expected 0009
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got BitField 0, expected 2
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got LinkCollection 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got LinkUsage 0000, expected 0004
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got LinkUsagePage 0000, expected 0001
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got IsAbsolute 0, expected 1
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got NotRange.Usage 0000, expected 0020
> ntoskrnl.c:1941: Test failed: id 0 poll: button_caps[3]: got NotRange.DataIndex 0, expected 26
> ntoskrnl.c:1947: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1949: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1952: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1953: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 0, expected 13
> ntoskrnl.c:1960: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1961: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 15, expected 13
> ntoskrnl.c:1967: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1968: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 15, expected 1
> ntoskrnl.c:1973: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1974: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 48879, expected 0
> ntoskrnl.c:1977: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1978: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 48879, expected 0
> ntoskrnl.c:1981: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned 0xc0110001
> ntoskrnl.c:1982: Test failed: id 0 poll: HidP_GetSpecificButtonCaps returned count 48879, expected 0
> ntoskrnl.c:1986: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
> ntoskrnl.c:1988: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
> ntoskrnl.c:1991: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
> ntoskrnl.c:1992: Test failed: id 0 poll: HidP_GetValueCaps returned count 0, expected 7
> ntoskrnl.c:1998: Test failed: id 0 poll: HidP_GetValueCaps returned 0xc0110001
> ntoskrnl.c:1999: Test failed: id 0 poll: HidP_GetValueCaps returned count 16, expected 7
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got UsagePage 3a43, expected 0001
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got ReportID 92, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsAlias 87, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got BitField 28265, expected 2
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got LinkCollection 28516, expected 1
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got LinkUsage 29559, expected 4
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got LinkUsagePage 18780, expected 1
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsRange 78, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsStringRange 70, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsDesignatorRange 92, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got IsAbsolute 111, expected 1
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got HasNull 101, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got BitSize 11830, expected 8
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[0]: got ReportCount 28265, expected 1
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[1]: got ReportID 1, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[2]: got ReportID 1, expected 0
> ntoskrnl.c:2005: Test failed: id 0 poll: value_caps[3]: got ReportID 1, expected 0
> ntoskrnl.c:2011: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2013: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2016: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2017: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 0, expected 7
> ntoskrnl.c:2024: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2025: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 12, expected 7
> ntoskrnl.c:2027: Test failed: id 0 poll: got UsagePage 0001, expected 3a43
> ntoskrnl.c:2027: Test failed: id 0 poll: got ReportID 1, expected 92
> ntoskrnl.c:2027: Test failed: id 0 poll: got IsAlias 0, expected 87
> ntoskrnl.c:2027: Test failed: id 0 poll: got BitField 2, expected 28265
> ntoskrnl.c:2027: Test failed: id 0 poll: got LinkCollection 1, expected 28516
> ntoskrnl.c:2027: Test failed: id 0 poll: got LinkUsage 4, expected 29559
> ntoskrnl.c:2027: Test failed: id 0 poll: got LinkUsagePage 1, expected 18780
> ntoskrnl.c:2027: Test failed: id 0 poll: got IsRange 0, expected 78
> ntoskrnl.c:2027: Test failed: id 0 poll: got IsStringRange 0, expected 70
> ntoskrnl.c:2027: Test failed: id 0 poll: got IsDesignatorRange 0, expected 92
> ntoskrnl.c:2027: Test failed: id 0 poll: got IsAbsolute 1, expected 111
> ntoskrnl.c:2027: Test failed: id 0 poll: got HasNull 0, expected 101
> ntoskrnl.c:2027: Test failed: id 0 poll: got BitSize 4, expected 11830
> ntoskrnl.c:2027: Test failed: id 0 poll: got ReportCount 2, expected 28265
> ntoskrnl.c:2027: Test failed: id 0 poll: got LogicalMin 1, expected -128
> ntoskrnl.c:2027: Test failed: id 0 poll: got LogicalMax 8, expected 127
> ntoskrnl.c:2035: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2041: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2042: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 57005, expected 0
> ntoskrnl.c:2045: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2046: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 57005, expected 0
> ntoskrnl.c:2049: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned 0xc0110001
> ntoskrnl.c:2050: Test failed: id 0 poll: HidP_GetSpecificValueCaps returned count 57005, expected 0
> ntoskrnl.c:2055: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2057: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2059: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2061: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2065: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2070: Test failed: id 0 poll: unexpected report data
> ntoskrnl.c:2074: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2078: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2082: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2086: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2090: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2094: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2099: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2103: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2104: Test failed: id 0 poll: got value deadbeef, expected 0x80
> ntoskrnl.c:2108: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2109: Test failed: id 0 poll: got value deadbeef, expected 0xffffff80
> ntoskrnl.c:2114: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2118: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2119: Test failed: id 0 poll: got value deadbeef, expected 0x7f
> ntoskrnl.c:2124: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2128: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2129: Test failed: id 0 poll: got value deadbeef, expected 0
> ntoskrnl.c:2134: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2138: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2139: Test failed: id 0 poll: got value deadbeef, expected 0
> ntoskrnl.c:2143: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2144: Test failed: id 0 poll: got value deadbeef, expected 0x7fffffff
> ntoskrnl.c:2149: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2153: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2154: Test failed: id 0 poll: got value deadbeef, expected 0x7fffffff
> ntoskrnl.c:2159: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2163: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2164: Test failed: id 0 poll: got value deadbeef, expected 0x80000000
> ntoskrnl.c:2169: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2173: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2174: Test failed: id 0 poll: got value deadbeef, expected 0
> ntoskrnl.c:2179: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2183: Test failed: id 0 poll: HidP_GetScaledUsageValue returned 0xc0110001
> ntoskrnl.c:2184: Test failed: id 0 poll: got value deadbeef, expected 0
> ntoskrnl.c:2189: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Input, 0) returned 0, expected 42
> ntoskrnl.c:2191: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Input, HID_USAGE_PAGE_BUTTON) returned 0, expected 32
> ntoskrnl.c:2193: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Input, HID_USAGE_PAGE_LED) returned 0, expected 8
> ntoskrnl.c:2195: Test failed: id 0 poll: HidP_MaxUsageListLength(HidP_Feature, HID_USAGE_PAGE_BUTTON) returned 0, expected 8
> ntoskrnl.c:2203: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
> ntoskrnl.c:2209: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
> ntoskrnl.c:2215: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
> ntoskrnl.c:2221: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
> ntoskrnl.c:2227: Test failed: id 0 poll: got report[6] ffffffcd expected 0
> ntoskrnl.c:2228: Test failed: id 0 poll: got report[7] ffffffcd expected 0
> ntoskrnl.c:2232: Test failed: id 0 poll: HidP_SetUsages returned 0xc0110001
> ntoskrnl.c:2235: Test failed: id 0 poll: unexpected report data
> ntoskrnl.c:2239: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2244: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2250: Test failed: id 0 poll: HidP_GetUsages returned 0xc0110001
> ntoskrnl.c:2251: Test failed: id 0 poll: got usage count 1, expected 2
> ntoskrnl.c:2256: Test failed: id 0 poll: HidP_GetUsages returned 0xc0110001
> ntoskrnl.c:2257: Test failed: id 0 poll: got usage count 16, expected 2
> ntoskrnl.c:2258: Test failed: id 0 poll: got usages[0] cdcd, expected 4
> ntoskrnl.c:2259: Test failed: id 0 poll: got usages[1] cdcd, expected 6
> ntoskrnl.c:2265: Test failed: id 0 poll: HidP_GetUsages returned 0xc0110001
> ntoskrnl.c:2266: Test failed: id 0 poll: got usage count 16, expected 2
> ntoskrnl.c:2267: Test failed: id 0 poll: got usages[0] cdcd, expected 6
> ntoskrnl.c:2268: Test failed: id 0 poll: got usages[1] cdcd, expected 4
> ntoskrnl.c:2274: Test failed: id 0 poll: HidP_GetUsagesEx returned 0xc0110001
> ntoskrnl.c:2275: Test failed: id 0 poll: got usage count 16, expected 4
> ntoskrnl.c:2276: Test failed: id 0 poll: got usage_and_pages[0] UsagePage cdcd, expected 9
> ntoskrnl.c:2278: Test failed: id 0 poll: got usage_and_pages[1] UsagePage cdcd, expected 9
> ntoskrnl.c:2280: Test failed: id 0 poll: got usage_and_pages[2] UsagePage cdcd, expected 7
> ntoskrnl.c:2282: Test failed: id 0 poll: got usage_and_pages[3] UsagePage cdcd, expected 7
> ntoskrnl.c:2284: Test failed: id 0 poll: got usage_and_pages[4] UsagePage cdcd, expected 8
> ntoskrnl.c:2286: Test failed: id 0 poll: got usage_and_pages[5] UsagePage cdcd, expected 8
> ntoskrnl.c:2288: Test failed: id 0 poll: got usage_and_pages[0] Usage cdcd, expected 4
> ntoskrnl.c:2290: Test failed: id 0 poll: got usage_and_pages[1] Usage cdcd, expected 6
> ntoskrnl.c:2292: Test failed: id 0 poll: got usage_and_pages[2] Usage cdcd, expected 9
> ntoskrnl.c:2294: Test failed: id 0 poll: got usage_and_pages[3] Usage cdcd, expected b
> ntoskrnl.c:2296: Test failed: id 0 poll: got usage_and_pages[4] Usage cdcd, expected 6
> ntoskrnl.c:2298: Test failed: id 0 poll: got usage_and_pages[5] Usage cdcd, expected 4
> ntoskrnl.c:2304: Test failed: id 0 poll: HidP_MaxDataListLength(HidP_Input) returned 0, expected 50
> ntoskrnl.c:2308: Test failed: id 0 poll: HidP_MaxDataListLength(HidP_Feature) returned 0, expected 13
> ntoskrnl.c:2312: Test failed: id 0 poll: HidP_GetData returned 0xc0110001
> ntoskrnl.c:2313: Test failed: id 0 poll: got data count 1, expected 11
> ntoskrnl.c:2316: Test failed: id 0 poll: HidP_GetData returned 0xc0110001
> ntoskrnl.c:2320: Test failed: id 0 poll: data[1]: got DataIndex 0, expected 1
> ntoskrnl.c:2320: Test failed: id 0 poll: data[2]: got DataIndex 0, expected 5
> ntoskrnl.c:2321: Test failed: id 0 poll: data[2]: got RawValue 0, expected 1
> ntoskrnl.c:2320: Test failed: id 0 poll: data[3]: got DataIndex 0, expected 7
> ntoskrnl.c:2321: Test failed: id 0 poll: data[3]: got RawValue 0, expected 1
> ntoskrnl.c:2320: Test failed: id 0 poll: data[4]: got DataIndex 0, expected 19
> ntoskrnl.c:2321: Test failed: id 0 poll: data[4]: got RawValue 0, expected 1
> ntoskrnl.c:2320: Test failed: id 0 poll: data[5]: got DataIndex 0, expected 21
> ntoskrnl.c:2321: Test failed: id 0 poll: data[5]: got RawValue 0, expected 1
> ntoskrnl.c:2320: Test failed: id 0 poll: data[6]: got DataIndex 0, expected 30
> ntoskrnl.c:2320: Test failed: id 0 poll: data[7]: got DataIndex 0, expected 31
> ntoskrnl.c:2320: Test failed: id 0 poll: data[8]: got DataIndex 0, expected 32
> ntoskrnl.c:2321: Test failed: id 0 poll: data[8]: got RawValue 0, expected -17970434
> ntoskrnl.c:2320: Test failed: id 0 poll: data[9]: got DataIndex 0, expected 37
> ntoskrnl.c:2321: Test failed: id 0 poll: data[9]: got RawValue 0, expected 1
> ntoskrnl.c:2320: Test failed: id 0 poll: data[10]: got DataIndex 0, expected 39
> ntoskrnl.c:2321: Test failed: id 0 poll: data[10]: got RawValue 0, expected 1
> ntoskrnl.c:2327: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2331: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2336: Test failed: id 0 poll: unexpected report data
> ntoskrnl.c:2354: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2358: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2363: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2369: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2373: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2378: Test failed: id 0 poll: HidP_SetUsageValue returned 0xc0110001
> ntoskrnl.c:2385: Test failed: id 0 poll: unexpected report data
> ntoskrnl.c:2392: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2395: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2399: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2404: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2408: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2413: Test failed: id 0 poll: HidP_GetUsageValue returned 0xc0110001
> ntoskrnl.c:2414: Test failed: id 0 poll: got value deadbeef, expected 0x1005
> ntoskrnl.c:2420: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2423: Test failed: id 0 poll: HidP_SetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2424: Test failed: id 0 poll: unexpected report data
> ntoskrnl.c:2429: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2432: Test failed: id 0 poll: HidP_GetUsageValueArray returned 0xc0110001
> ntoskrnl.c:2434: Test failed: id 0 poll: unexpected report value
> ntoskrnl.c:2439: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2444: Test failed: id 0 poll: HidD_GetInputReport returned error 6
> ntoskrnl.c:2449: Test failed: id 0 poll: HidD_GetInputReport returned error 6
> ntoskrnl.c:2460: Test failed: id 0 poll: HidD_GetInputReport returned error 6
> ntoskrnl.c:2471: Test failed: id 0 poll: HidD_GetInputReport failed, last error 6
> ntoskrnl.c:2472: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
> ntoskrnl.c:2477: Test failed: id 0 poll: IOCTL_HID_GET_INPUT_REPORT failed, last error 6
> ntoskrnl.c:2478: Test failed: id 0 poll: got length 46, expected 3
> ntoskrnl.c:2479: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
> ntoskrnl.c:2484: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2489: Test failed: id 0 poll: HidD_GetFeature returned error 6
> ntoskrnl.c:2494: Test failed: id 0 poll: HidD_GetFeature returned error 6
> ntoskrnl.c:2505: Test failed: id 0 poll: HidD_GetFeature returned error 6
> ntoskrnl.c:2516: Test failed: id 0 poll: HidD_GetFeature failed, last error 6
> ntoskrnl.c:2517: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
> ntoskrnl.c:2522: Test failed: id 0 poll: IOCTL_HID_GET_FEATURE failed, last error 6
> ntoskrnl.c:2523: Test failed: id 0 poll: got length 34, expected 3
> ntoskrnl.c:2524: Test failed: id 0 poll: got report[0] ffffffcd, expected 00
> ntoskrnl.c:2529: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2534: Test failed: id 0 poll: HidD_SetFeature returned error 6
> ntoskrnl.c:2539: Test failed: id 0 poll: HidD_SetFeature returned error 6
> ntoskrnl.c:2550: Test failed: id 0 poll: HidD_SetFeature returned error 6
> ntoskrnl.c:2560: Test failed: id 0 poll: HidD_SetFeature failed, last error 6
> ntoskrnl.c:2566: Test failed: id 0 poll: IOCTL_HID_SET_FEATURE returned error 6
> ntoskrnl.c:2570: Test failed: id 0 poll: IOCTL_HID_SET_FEATURE failed, last error 6
> ntoskrnl.c:2571: Test failed: id 0 poll: got length 0, expected 3
> ntoskrnl.c:2576: Test failed: id 0 poll: HidP_InitializeReportForID returned 0xc0110001
> ntoskrnl.c:2583: Test failed: id 0 poll: HidD_SetOutputReport returned error 6
> ntoskrnl.c:2588: Test failed: id 0 poll: HidD_SetOutputReport returned error 6
> ntoskrnl.c:2599: Test failed: id 0 poll: HidD_SetOutputReport returned error 6
> ntoskrnl.c:2609: Test failed: id 0 poll: HidD_SetOutputReport failed, last error 6
> ntoskrnl.c:2615: Test failed: id 0 poll: IOCTL_HID_SET_OUTPUT_REPORT returned error 6
> ntoskrnl.c:2619: Test failed: id 0 poll: IOCTL_HID_SET_OUTPUT_REPORT failed, last error 6
> ntoskrnl.c:2620: Test failed: id 0 poll: got length 0, expected 3
> ntoskrnl.c:2626: Test failed: id 0 poll: WriteFile returned error 6
> ntoskrnl.c:2631: Test failed: id 0 poll: WriteFile returned error 6
> ntoskrnl.c:2644: Test failed: id 0 poll: WriteFile returned error 6
> ntoskrnl.c:2659: Test failed: id 0 poll: WriteFile failed, last error 6
> ntoskrnl.c:2660: Test failed: id 0 poll: WriteFile wrote 0
> ntoskrnl.c:2667: Test failed: id 0 poll: ReadFile failed, last error 6
> ntoskrnl.c:2671: Test failed: id 0 poll: ReadFile failed, last error 6
> ntoskrnl.c:2679: Test failed: id 0 poll: ReadFile failed, last error 6
> ntoskrnl.c:2680: Test failed: id 0 poll: ReadFile returned 0
> ntoskrnl.c:2681: Test failed: id 0 poll: unexpected report data
> ntoskrnl.c:2690: Test failed: id 0 poll: ReadFile returned error 6
> ntoskrnl: Timeout

These are pre-existing rare spurious failures on Windows where the 
device driver sometimes fails to install. I'm not sure why (yet?).
-- 
Rémi Bernon <rbernon(a)codeweavers.com>