glXGetProcAddressARB causing dozens of warnings
I'm afraid the following patch date: 2003/05/07 03:18:51; author: julliard; state: Exp; lines: +1 -0 Michael Schlüter <michael(a)johalla.de> Added wglGetExtensionsStringARB. to dlls/opengl32/opengl32.spec, dlls/opengl32/wgl.c and dlls/opengl32/wgl.h is responsible for the following warnings (seen on FreeBSD 4.8/i386 with XFree86-4.3.0 and Mesa-3.4.2). Would you mind fixing these? stateblock.c:203: warning: implicit declaration of function `glActiveTextureARB' wgl.c:325: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: comparison between pointer and integer wgl.c:334: warning: assignment makes pointer from integer without a cast opengl_norm.c:28: warning: implicit declaration of function `glActiveTextureARB' opengl_norm.c:210: warning: implicit declaration of function `glClientActiveTextureARB' opengl_norm.c:2152: warning: implicit declaration of function `glMultiTexCoord1dARB' opengl_norm.c:2162: warning: implicit declaration of function `glMultiTexCoord1dvARB' opengl_norm.c:2172: warning: implicit declaration of function `glMultiTexCoord1fARB' opengl_norm.c:2182: warning: implicit declaration of function `glMultiTexCoord1fvARB' opengl_norm.c:2192: warning: implicit declaration of function `glMultiTexCoord1iARB' opengl_norm.c:2202: warning: implicit declaration of function `glMultiTexCoord1ivARB' opengl_norm.c:2212: warning: implicit declaration of function `glMultiTexCoord1sARB' opengl_norm.c:2222: warning: implicit declaration of function `glMultiTexCoord1svARB' opengl_norm.c:2232: warning: implicit declaration of function `glMultiTexCoord2dARB' opengl_norm.c:2242: warning: implicit declaration of function `glMultiTexCoord2dvARB' opengl_norm.c:2252: warning: implicit declaration of function `glMultiTexCoord2fARB' opengl_norm.c:2262: warning: implicit declaration of function `glMultiTexCoord2fvARB' opengl_norm.c:2272: warning: implicit declaration of function `glMultiTexCoord2iARB' opengl_norm.c:2282: warning: implicit declaration of function `glMultiTexCoord2ivARB' opengl_norm.c:2292: warning: implicit declaration of function `glMultiTexCoord2sARB' opengl_norm.c:2302: warning: implicit declaration of function `glMultiTexCoord2svARB' opengl_norm.c:2312: warning: implicit declaration of function `glMultiTexCoord3dARB' opengl_norm.c:2322: warning: implicit declaration of function `glMultiTexCoord3dvARB' opengl_norm.c:2332: warning: implicit declaration of function `glMultiTexCoord3fARB' opengl_norm.c:2342: warning: implicit declaration of function `glMultiTexCoord3fvARB' opengl_norm.c:2352: warning: implicit declaration of function `glMultiTexCoord3iARB' opengl_norm.c:2362: warning: implicit declaration of function `glMultiTexCoord3ivARB' opengl_norm.c:2372: warning: implicit declaration of function `glMultiTexCoord3sARB' opengl_norm.c:2382: warning: implicit declaration of function `glMultiTexCoord3svARB' opengl_norm.c:2392: warning: implicit declaration of function `glMultiTexCoord4dARB' opengl_norm.c:2402: warning: implicit declaration of function `glMultiTexCoord4dvARB' opengl_norm.c:2412: warning: implicit declaration of function `glMultiTexCoord4fARB' opengl_norm.c:2422: warning: implicit declaration of function `glMultiTexCoord4fvARB' opengl_norm.c:2432: warning: implicit declaration of function `glMultiTexCoord4iARB' opengl_norm.c:2442: warning: implicit declaration of function `glMultiTexCoord4ivARB' opengl_norm.c:2452: warning: implicit declaration of function `glMultiTexCoord4sARB' opengl_norm.c:2462: warning: implicit declaration of function `glMultiTexCoord4svARB' Thanks, Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/
On Fri, May 09, 2003 at 11:49:26AM +0200, Gerald Pfeifer wrote:
I'm afraid the following patch
date: 2003/05/07 03:18:51; author: julliard; state: Exp; lines: +1 -0 Michael Schlüter <michael(a)johalla.de> Added wglGetExtensionsStringARB.
to dlls/opengl32/opengl32.spec, dlls/opengl32/wgl.c and dlls/opengl32/wgl.h is responsible for the following warnings (seen on FreeBSD 4.8/i386 with XFree86-4.3.0 and Mesa-3.4.2).
Would you mind fixing these?
Gerald, You sure you do not have something else that changed on your box between your two Wine compiles ? I really do not see how this patch could have added additionnal warnings (and I have none on my Linux box with this patch applied). Could you try to revert this patch and check if you still have the same warnings or not ? Lionel -- Lionel Ulmer - http://www.bbrox.org/
Lionel, I have the same issue here. In fact, I was about to work on it. Seems im not the only one who has the problem :)
Gerald,
You sure you do not have something else that changed on your box between your two Wine compiles ?
I really do not see how this patch could have added additionnal warnings (and I have none on my Linux box with this patch applied).
Could you try to revert this patch and check if you still have the same warnings or not ?
Lionel
-- Lionel Ulmer - http://www.bbrox.org/
===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all, can you say me the opengl headers version you have ? I think you have mesa headers with GL_VERSION_1_3 defined since 1.3 all ARB_multexturing extension things are supported by main opengl implementation (no more extension) and for glXGetProcAddressARB it become glXGetProcAddress if you have glx1.4 Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+vPlpp7NA3AmQTU4RAjmnAJ4+sJP1qDXb/TyIj5VbH7yDYFwfvACeIHY4 VI/LftKFaNxguiaxbP0g/RE= =rlwE -----END PGP SIGNATURE-----
On Sat, 10 May 2003, Sylvain Petreolle wrote:
Lionel, I have the same issue here. In fact, I was about to work on it.
Thanks! On Sat, 10 May 2003, Raphaël Junqueira wrote:
can you say me the opengl headers version you have ? I think you have mesa headers with GL_VERSION_1_3 defined
Mesa-3.4.2, which has % grep GL_VERSION gl.h #define GL_VERSION_1_1 1 #define GL_VERSION_1_2 1 #define GL_VERSION_1_3 1 #define GL_VERSION 0x1F02
since 1.3 all ARB_multexturing extension things are supported by main opengl implementation (no more extension)
and for glXGetProcAddressARB it become glXGetProcAddress if you have glx1.4
Sorry, I'm afraid I don't understand. Perhaps Sylvain has fixed the problem already, but in case he hasn't, how do you suggest to get rid of all those warnings? Gerald PS: I have `grep glXGetProcAddress *` result in glx.h:extern void (*glXGetProcAddress(const GLubyte *procname))(void); glx.h:extern void (*glXGetProcAddressARB(const GLubyte *procName))( void ); glxext.h:extern __GLXextFuncPtr glXGetProcAddress (const GLubyte *); glxext.h:extern __GLXextFuncPtr glXGetProcAddressARB (const GLubyte *);
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Mesa-3.4.2, which has
% grep GL_VERSION gl.h #define GL_VERSION_1_1 1 #define GL_VERSION_1_2 1 #define GL_VERSION_1_3 1 #define GL_VERSION 0x1F02
ok
Sorry, I'm afraid I don't understand. Perhaps Sylvain has fixed the problem already, but in case he hasn't, how do you suggest to get rid of all those warnings?
very easy :) for the glx things: ... if (glXGetProcAddressARB(lpszProc) != NULL) { ... become ... #if !defined(GLX_VERSION_1_4) if (glXGetProcAddressARB(lpszProc) != NULL) { #else if (glXGetProcAddress(lpszProc) != NULL) { #endif ... for the gl*ARB: ... glActiveTextureARB( texture ); ... become ... #if !defined(GLX_VERSION_1_3) glActiveTextureARB( texture ); #else glActiveTexture( texture ); #endif ... you only have to remove ARB prefixes to defines and functions names Regards, Raphael
Gerald
PS: I have `grep glXGetProcAddress *` result in glx.h:extern void (*glXGetProcAddress(const GLubyte *procname))(void); glx.h:extern void (*glXGetProcAddressARB(const GLubyte *procName))( void ); glxext.h:extern __GLXextFuncPtr glXGetProcAddress (const GLubyte *); glxext.h:extern __GLXextFuncPtr glXGetProcAddressARB (const GLubyte *);
yes but glXGetProcAddressARB is only defined when GLX_ARB_get_proc_address not defined before -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+vTbEp7NA3AmQTU4RAlLcAJ0TADAIqzyIL8r2tUnkia4DarDHUgCggTJB ZnidN8IBesazdDd2yS3Ipks= =RroJ -----END PGP SIGNATURE-----
On Sat, 10 May 2003, Raphaël Junqueira wrote:
very easy :)
Sorry, but I'm afraid that solution wasn't the right one. The patch below worked fine for me, though. Alexandre? Gerald ChangeLog: #define GL_GLEXT_PROTOTYPES to obtain proper prototypes. Index: make_opengl =================================================================== RCS file: /home/wine/wine/dlls/opengl32/make_opengl,v retrieving revision 1.16 diff -u -3 -p -r1.16 make_opengl --- make_opengl 7 May 2003 03:18:51 -0000 1.16 +++ make_opengl 19 May 2003 17:05:36 -0000 @@ -564,6 +564,7 @@ open(NORM, ">" . $norm_file); print NORM " /* Auto-generated file... Do not edit ! */ +#define GL_GLEXT_PROTOTYPES #include \"config.h\" #include \"opengl_ext.h\" #include \"wine/debug.h\" Index: opengl_norm.c =================================================================== RCS file: /home/wine/wine/dlls/opengl32/opengl_norm.c,v retrieving revision 1.7 diff -u -3 -p -r1.7 opengl_norm.c --- opengl_norm.c 25 Sep 2002 00:29:57 -0000 1.7 +++ opengl_norm.c 19 May 2003 17:05:37 -0000 @@ -1,6 +1,7 @@ /* Auto-generated file... Do not edit ! */ +#define GL_GLEXT_PROTOTYPES #include "config.h" #include "opengl_ext.h" #include "wine/debug.h"
participants (4)
-
Gerald Pfeifer -
Lionel Ulmer -
Raphaël Junqueira -
Sylvain Petreolle