[PATCH v2] regedit: Dont expand items on initial tree creation.

[Alistair Leslie-Hughes]

The Message TVM_EXPAND is captured in treeview_notify, then passes
g_pChildWnd->hTreeWnd on to OnTreeExpanding which hasn't been initialized
yet.
The function get_last_key is already called after the hTreeWnd has been
assigned to select the previous selected item (if it exists).

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 programs/regedit/childwnd.c | 7 ++++++-
 programs/regedit/treeview.c | 3 ---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/programs/regedit/childwnd.c b/programs/regedit/childwnd.c
index d8431f1..04399fe 100644
--- a/programs/regedit/childwnd.c
+++ b/programs/regedit/childwnd.c
@@ -240,15 +240,20 @@ static void get_last_key(HWND hwndTV)
 
     if (RegCreateKeyExW(HKEY_CURRENT_USER, wszKeyName, 0, NULL, 0, KEY_READ, NULL, &hkey, NULL) == ERROR_SUCCESS)
     {
+        HTREEITEM selection;
         if (RegQueryValueExW(hkey, wszLastKey, NULL, NULL, (LPBYTE)wszVal, &dwSize) == ERROR_SUCCESS)
         {
-            HTREEITEM selection;
             if (!strcmpW(wszVal, g_pChildWnd->szPath))
                 selection = (HTREEITEM)SendMessageW(g_pChildWnd->hTreeWnd, TVM_GETNEXTITEM, TVGN_ROOT, 0);
             else
                 selection = FindPathInTree(hwndTV, wszVal);
             SendMessageW(hwndTV, TVM_SELECTITEM, TVGN_CARET, (LPARAM)selection);
         }
+        else
+        {
+            selection = (HTREEITEM)SendMessageW(g_pChildWnd->hTreeWnd, TVM_GETNEXTITEM, TVGN_ROOT, 0);
+            SendMessageW(hwndTV, TVM_EXPAND, TVE_EXPAND, (LPARAM)selection );
+        }
 
         RegCloseKey(hkey);
     }
diff --git a/programs/regedit/treeview.c b/programs/regedit/treeview.c
index d5a6767..15a5136 100644
--- a/programs/regedit/treeview.c
+++ b/programs/regedit/treeview.c
@@ -572,9 +572,6 @@ static BOOL InitTreeViewItems(HWND hwndTV, LPWSTR pHostName)
     if (!AddEntryToTree(hwndTV, hRoot, hkcc, HKEY_CURRENT_CONFIG, 1)) return FALSE;
     if (!AddEntryToTree(hwndTV, hRoot, hkdd, HKEY_DYN_DATA, 1)) return FALSE;
 
-    /* expand and select host name */
-    SendMessageW(hwndTV, TVM_EXPAND, TVE_EXPAND, (LPARAM)hRoot );
-    SendMessageW(hwndTV, TVM_SELECTITEM, TVGN_CARET, (LPARAM)hRoot);
     return TRUE;
 }
 
-- 
1.9.1

[Alexandre Julliard]

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes:
> The Message TVM_EXPAND is captured in treeview_notify, then passes
> g_pChildWnd->hTreeWnd on to OnTreeExpanding which hasn't been initialized
> yet.
> The function get_last_key is already called after the hTreeWnd has been
> assigned to select the previous selected item (if it exists).
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  programs/regedit/childwnd.c | 7 ++++++-
>  programs/regedit/treeview.c | 3 ---
>  2 files changed, 6 insertions(+), 4 deletions(-)

This breaks the initial expansion of the root node.

-- 
Alexandre Julliard
julliard(a)winehq.org