[PATCH] user32: use SWP_NOACTIVATE flag when resizing etched static control
Signed-off-by: Rafał Harabień <rafalh92(a)outlook.com> --- dlls/user32/static.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/static.c b/dlls/user32/static.c index e81e553f7d8..3c9b67b20ac 100644 --- a/dlls/user32/static.c +++ b/dlls/user32/static.c @@ -426,7 +426,7 @@ LRESULT StaticWndProc_common( HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam rc.right = rc.left; AdjustWindowRectEx(&rc, full_style, FALSE, GetWindowLongW(hwnd, GWL_EXSTYLE)); NtUserSetWindowPos( hwnd, NULL, 0, 0, rc.right - rc.left, rc.bottom - rc.top, - SWP_NOMOVE | SWP_NOZORDER ); + SWP_NOACTIVATE | SWP_NOMOVE | SWP_NOZORDER ); } switch (style) { -- 2.25.1
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=112274 Your paranoid android. === debian11 (32 bit report) === user32: input.c:2163: Test failed: Unexpected rawinput data: -8 input.c:2182: Test failed: Unexpected rawinput data: -5 input.c:2217: Test failed: Unexpected rawinput data: 7 input.c:1628: Test failed: wrong position 5, expected 61x122 got 60x120 input.c:1628: Test failed: wrong position 6, expected 60x120 got 64x128 input.c:1628: Test failed: wrong position 11, expected 55x110 got 57x114 input.c:1628: Test failed: wrong position 13, expected 53x106 got 56x112 input.c:1628: Test failed: wrong position 14, expected 52x104 got 55x110 input.c:1628: Test failed: wrong position 15, expected 51x102 got 54x108 input.c:1628: Test failed: wrong position 16, expected 50x100 got 60x120 input.c:1628: Test failed: wrong position 17, expected 49x98 got 53x106 input.c:1628: Test failed: wrong position 18, expected 48x96 got 59x118 input.c:1628: Test failed: wrong position 19, expected 47x94 got 58x116 input.c:1628: Test failed: wrong position 20, expected 46x92 got 57x114 input.c:1628: Test failed: wrong position 21, expected 45x90 got 56x112 input.c:1628: Test failed: wrong position 26, expected 40x80 got 54x108 input.c:1628: Test failed: wrong position 28, expected 38x76 got 53x106 input.c:1628: Test failed: wrong position 33, expected 33x66 got 49x98 input.c:1628: Test failed: wrong position 34, expected 32x64 got 47x94 input.c:1628: Test failed: wrong position 43, expected 23x46 got 45x90 input.c:1628: Test failed: wrong position 49, expected 17x34 got 42x84 input.c:1628: Test failed: wrong position 52, expected 14x28 got 37x74 input.c:1628: Test failed: wrong position 54, expected 12x24 got 40x80 win.c:11344: Test failed: expected 00DC00E6, got 000D0138 win.c:11353: Test failed: GetActiveWindow() = 00000000 win.c:11353: Test failed: GetFocus() = 00000000 win.c:11361: Test failed: expected 00DC00E6, got 000D0138 === debian11 (32 bit Chinese:China report) === user32: input.c:1315: Test failed: Wrong hook coords: (106 106) != (150,150) input.c:1323: Test failed: GetCursorPos: (106,106) input.c:2162: Test failed: Unexpected rawinput data: 7 input.c:1628: Test failed: wrong position 19, expected 47x94 got 54x108 input.c:1628: Test failed: wrong position 23, expected 43x86 got 52x104 input.c:1628: Test failed: wrong position 31, expected 35x70 got 48x96 input.c:1628: Test failed: wrong position 55, expected 11x22 got 35x70 win.c:11344: Test failed: expected 01C8015A, got 00490086 win.c:11353: Test failed: GetActiveWindow() = 00000000 win.c:11353: Test failed: GetFocus() = 00000000 win.c:11361: Test failed: expected 01C8015A, got 00490086 win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11763: Test failed: 012F00BA: expected NOT topmost win.c:11787: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11810: Test failed: 00BF00C0: expected NOT topmost win.c:11811: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11811: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11834: Test failed: 00BF00C0: expected NOT topmost win.c:11835: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11835: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11869: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11869: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11892: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11903: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11903: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost === debian11 (32 bit WoW report) === user32: win.c:11361: Test failed: expected 01FC0160, got 00460086 win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11763: Test failed: 015000EA: expected NOT topmost win.c:11787: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11810: Test failed: 001F0156: expected NOT topmost win.c:11811: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11811: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11834: Test failed: 001F0156: expected NOT topmost win.c:11835: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11835: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11869: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11869: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11892: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11903: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11903: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost === debian11 (64 bit WoW report) === user32: input.c:2793: Test failed: 4: unexpected WM_MOUSEMOVE message input.c:2804: Test failed: 9: Unexpected cursor movement input.c:2521: Test failed: 10: foreground process expected WM_MOUSEMOVE message input.c:2521: Test failed: 11: foreground process expected WM_MOUSEMOVE message input.c:2521: Test failed: 12: foreground process expected WM_MOUSEMOVE message input.c:1733: Test failed: expected to get 64 mouse move points but got -1 input.c:1744: Test failed: expected to get 64 mouse move points but got -1 win.c:11361: Test failed: expected 0000000000D300AC, got 0000000000130144
This test is broken on the master branch... I can see similar failures with other patches. My change could not cause it. On 09.04.2022 13:31, Marvin wrote:
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=112274
Your paranoid android.
=== debian11 (32 bit report) ===
user32: input.c:2163: Test failed: Unexpected rawinput data: -8 input.c:2182: Test failed: Unexpected rawinput data: -5 input.c:2217: Test failed: Unexpected rawinput data: 7 input.c:1628: Test failed: wrong position 5, expected 61x122 got 60x120 input.c:1628: Test failed: wrong position 6, expected 60x120 got 64x128 input.c:1628: Test failed: wrong position 11, expected 55x110 got 57x114 input.c:1628: Test failed: wrong position 13, expected 53x106 got 56x112 input.c:1628: Test failed: wrong position 14, expected 52x104 got 55x110 input.c:1628: Test failed: wrong position 15, expected 51x102 got 54x108 input.c:1628: Test failed: wrong position 16, expected 50x100 got 60x120 input.c:1628: Test failed: wrong position 17, expected 49x98 got 53x106 input.c:1628: Test failed: wrong position 18, expected 48x96 got 59x118 input.c:1628: Test failed: wrong position 19, expected 47x94 got 58x116 input.c:1628: Test failed: wrong position 20, expected 46x92 got 57x114 input.c:1628: Test failed: wrong position 21, expected 45x90 got 56x112 input.c:1628: Test failed: wrong position 26, expected 40x80 got 54x108 input.c:1628: Test failed: wrong position 28, expected 38x76 got 53x106 input.c:1628: Test failed: wrong position 33, expected 33x66 got 49x98 input.c:1628: Test failed: wrong position 34, expected 32x64 got 47x94 input.c:1628: Test failed: wrong position 43, expected 23x46 got 45x90 input.c:1628: Test failed: wrong position 49, expected 17x34 got 42x84 input.c:1628: Test failed: wrong position 52, expected 14x28 got 37x74 input.c:1628: Test failed: wrong position 54, expected 12x24 got 40x80 win.c:11344: Test failed: expected 00DC00E6, got 000D0138 win.c:11353: Test failed: GetActiveWindow() = 00000000 win.c:11353: Test failed: GetFocus() = 00000000 win.c:11361: Test failed: expected 00DC00E6, got 000D0138
=== debian11 (32 bit Chinese:China report) ===
user32: input.c:1315: Test failed: Wrong hook coords: (106 106) != (150,150) input.c:1323: Test failed: GetCursorPos: (106,106) input.c:2162: Test failed: Unexpected rawinput data: 7 input.c:1628: Test failed: wrong position 19, expected 47x94 got 54x108 input.c:1628: Test failed: wrong position 23, expected 43x86 got 52x104 input.c:1628: Test failed: wrong position 31, expected 35x70 got 48x96 input.c:1628: Test failed: wrong position 55, expected 11x22 got 35x70 win.c:11344: Test failed: expected 01C8015A, got 00490086 win.c:11353: Test failed: GetActiveWindow() = 00000000 win.c:11353: Test failed: GetFocus() = 00000000 win.c:11361: Test failed: expected 01C8015A, got 00490086 win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11763: Test failed: 012F00BA: expected NOT topmost win.c:11787: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11810: Test failed: 00BF00C0: expected NOT topmost win.c:11811: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11811: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11834: Test failed: 00BF00C0: expected NOT topmost win.c:11835: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11835: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11869: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11869: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11892: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11903: Test failed: 012F00BA: expected next 00070146, got 00000000 win.c:11903: Test failed: 012F00BA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost win.c:11606: Test failed: 1: hwnd 00BF00C0 is still topmost win.c:11606: Test failed: 2: hwnd 001100C8 is still topmost win.c:11606: Test failed: 3: hwnd 00070146 is still topmost win.c:11606: Test failed: 4: hwnd 012F00BA is still topmost
=== debian11 (32 bit WoW report) ===
user32: win.c:11361: Test failed: expected 01FC0160, got 00460086 win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11763: Test failed: 015000EA: expected NOT topmost win.c:11787: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11810: Test failed: 001F0156: expected NOT topmost win.c:11811: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11811: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11834: Test failed: 001F0156: expected NOT topmost win.c:11835: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11835: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11869: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11869: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11892: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11903: Test failed: 015000EA: expected next 00070148, got 00000000 win.c:11903: Test failed: 015000EA: expected NOT topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost win.c:11606: Test failed: 1: hwnd 001F0156 is still topmost win.c:11606: Test failed: 2: hwnd 00EA0052 is still topmost win.c:11606: Test failed: 3: hwnd 00070148 is still topmost win.c:11606: Test failed: 4: hwnd 015000EA is still topmost
=== debian11 (64 bit WoW report) ===
user32: input.c:2793: Test failed: 4: unexpected WM_MOUSEMOVE message input.c:2804: Test failed: 9: Unexpected cursor movement input.c:2521: Test failed: 10: foreground process expected WM_MOUSEMOVE message input.c:2521: Test failed: 11: foreground process expected WM_MOUSEMOVE message input.c:2521: Test failed: 12: foreground process expected WM_MOUSEMOVE message input.c:1733: Test failed: expected to get 64 mouse move points but got -1 input.c:1744: Test failed: expected to get 64 mouse move points but got -1 win.c:11361: Test failed: expected 0000000000D300AC, got 0000000000130144
I through so but after my previous iteration of sending patches, patches that passed CI were merged and this one got ignored so I concluded that Testbot failure was the reason. I am trying to contribute this patch for 1.5 month already (it was first sent on 24 Feb and Testbot didn't fail at that time). It is super small, looks non-controversial for me and fixes issues that I introduced in my other patch so I don't know what could possibly be the reason for it not being merged. <rant-mode>It is not the first time I wait weeks for my patches to be merged or at least reviewed. Seeing how fast patches from CodeWeavers employees are merged (around 1 day) I have impression that this project is unwelcoming to outsiders and it makes me sad.</rant-mode> On 09.04.2022 15:47, Jinoh Kang wrote:
On 4/9/22 21:58, Rafal Harabień wrote:
This test is broken on the master branch... I can see similar failures with other patches. My change could not cause it. It's commonplace. You don't actually have to explain it.
On 4/10/22 04:48, Rafal Harabień wrote:
I through so but after my previous iteration of sending patches, patches that passed CI were merged and this one got ignored so I concluded that Testbot failure was the reason. I am trying to contribute this patch for 1.5 month already (it was first sent on 24 Feb and Testbot didn't fail at that time). It is super small, looks non-controversial for me and fixes issues that I introduced in my other patch so I don't know what could possibly be the reason for it not being merged.
I'm not a maintainer, but here's a few things you could add to make your patch more convincing: 1. An explanation for why the patch is necessary, and would not probably introduce other regression. 2. A unit test that justifies the fix, and ensures that regression that you previously introduced won't happen again. 3. An associated bug report (https://bugs.winehq.org/), linked with a trailer "Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=<ID>".
<rant-mode>It is not the first time I wait weeks for my patches to be merged or at least reviewed. Seeing how fast patches from CodeWeavers employees are merged (around 1 day) I have impression that this project is unwelcoming to outsiders and it makes me sad.</rant-mode>
See: https://wiki.winehq.org/Developer_FAQ#I_sent_a_patch.2C_but_it_got_ignored._...
On 09.04.2022 15:47, Jinoh Kang wrote:
On 4/9/22 21:58, Rafal Harabień wrote:
This test is broken on the master branch... I can see similar failures with other patches. My change could not cause it. It's commonplace. You don't actually have to explain it.
-- Sincerely, Jinoh Kang
participants (4)
-
Jinoh Kang -
Marvin -
Rafal Harabień -
Rafał Harabień