[PATCH] kernel32: update version to win7

[Louis Lenders]

https://bugs.winehq.org/show_bug.cgi?id=48304


Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
---
 dlls/kernel32/version.rc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/kernel32/version.rc b/dlls/kernel32/version.rc
index d4b994f28d..82287e5da7 100644
--- a/dlls/kernel32/version.rc
+++ b/dlls/kernel32/version.rc
@@ -25,10 +25,10 @@ LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
 #define WINE_FILEDESCRIPTION_STR "Wine kernel DLL"
 #define WINE_FILENAME_STR "kernel32.dll"
 
-/* these values come from Windows XP SP2 */
-#define WINE_FILEVERSION 5,1,2600,2180
-#define WINE_FILEVERSION_STR "5.01.2600.2180"
-#define WINE_PRODUCTVERSION 5,1,2600,2180
-#define WINE_PRODUCTVERSION_STR "5.01.2600.2180"
+/* these values come from Windows 7 SP1 */
+#define WINE_FILEVERSION 6,1,7601,17514
+#define WINE_FILEVERSION_STR "6.1.7601.17514"
+#define WINE_PRODUCTVERSION 6,1,7601,17514
+#define WINE_PRODUCTVERSION_STR "6.1.7601.17514"
 
 #include "wine/wine_common_ver.rc"
-- 
2.24.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=62301

Your paranoid android.


=== debian10 (32 bit report) ===

kernel32:
comm.c:918: Test failed: OutQueue should not be empty

=== debian10 (32 bit WoW report) ===

kernel32:
debugger: Timeout

=== debian10 (64 bit WoW report) ===

kernel32:
debugger.c:320: Test failed: GetThreadContext failed: 5

[Fabian Maurer]

Just curious, shouldn't this best be dependent on the set windows version?

Regards,
Fabian Maurer

[Sveinar Søpler]

On 18.12.2019 20:10, Fabian Maurer wrote:
> Just curious, shouldn't this best be dependent on the set windows version?
>
> Regards,
> Fabian Maurer

I do not think that is possible. These "version strings" set the version 
on the fake-dll's. I have had similar issues when diddling with the 
nvapi testing project. This is cos some apps just check the version of 
the dll, while the "windows version" you set with winecfg is just via 
the registry really.

Probably not a standard on how windows apps should verify the running 
version. Since this something that is linked during compile it would be 
a bit of work to implement, cos you would really need a set of 
fake-dll's for each windows version you choose.

If anyone are up to the task of figuring out the differences of 
dll'version between all supported windows versions of wine and set up 
some mechanic that would replace needed fake-dll's each time you change 
windows version it could be interesting.

Not sure what could break if the kernel32.dll is "too new" (or any other 
dll for that matter), but if the answer is "probably nothing", this 
should be changed to the highest supported version imo... so not stop at 
windows 7. For info, Win10 1909 has version "10.0.18362.329"

Sveinar