Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

[James McKenzie]

Max TenEyck Woodbury wrote:
> On 07/25/2010 01:55 PM, James McKenzie wrote:
> > Andrew Eikum wrote:
> > > On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote:
> > > > On 07/25/2010 09:45 AM, James McKenzie wrote:
> > > > > I think you missed what Nicolay and Dmitry are trying to tell you.
> > > > > We are trying to implement, bug for bug, the functionality of what
> > > > > Windows does. Does Windows return "STATUS_NOT_IMPLEMENTED" when this
> > > > > call is made? If not, your fix is WRONG. Silencing a 'fixme' is NOT a
> > > > > fix and this will be REJECTED.
> > > > > If this is correct and is what Windows does, then state so. 
> > > > > Otherwise,
> > > > > withdraw the patch and fix it the right way.
> > > > >
> > > > > James McKenzie
> > > >
> > > > Frankly, I do not know what Microsoft does, but the test would fail on
> > > > their implementation if they did something else, so I think it is safe
> > > > to assume the test is implemented properly. Given that, the fixme is
> > > > wrong.
> > > > You had very well much know what Microsoft does and care very much about
> > > > what they do. The goal of this project, as it has been since the mid
> > > > 1990s is to fully emulate, bug and all, the Microsoft Windows32 and
> > > > Windows64 (since 64 bit versions of Windows arrived) APIs. Thus we have
> > > > test cases that demonstrate what the actions are of the API/ABI. That is
> > > > what I've been working on with several richedit functions that I need to
> > > > have for programs that I personally use. I'm 'eating my own dog food' to
> > > > speak.
>
> Since I do not have (and should never have if I work on Wine) access to
> Microsoft's code, I can not know what they actually do.
> Upon the insistance of AJ and others, I will no longer be working on or 
> for the Wine project.

Your code does have an error, it was just recently pointed out that the 
return value was incorrect.

Thank you for sufficiently flogging me with the whip I was attempting to 
flog you with.

James McKenzie