Re: advapi32: Remove redundant "is NULL and error out" code (coccicheck).
Alexandre, please disregard this patch as I missed somehow that the error codes are different. And to figure out which to use needs a test. bye michael Michael Stefaniuc wrote:
--- dlls/advapi32/crypt.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c index bb019d0..395879f 100644 --- a/dlls/advapi32/crypt.c +++ b/dlls/advapi32/crypt.c @@ -1413,11 +1413,6 @@ BOOL WINAPI CryptGenKey (HCRYPTPROV hProv, ALG_ID Algid, DWORD dwFlags, HCRYPTKE
TRACE("(0x%lx, %d, %08x, %p)\n", hProv, Algid, dwFlags, phKey);
- if (!prov) - { - SetLastError(ERROR_INVALID_HANDLE); - return FALSE; - } if (!phKey || !prov || prov->dwMagic != MAGIC_CRYPTPROV) { SetLastError(ERROR_INVALID_PARAMETER);
participants (1)
-
Michael Stefaniuc